-
Notifications
You must be signed in to change notification settings - Fork 63
Feature: Add functionality to mesh handle #2084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2084 +/- ##
==========================================
+ Coverage 77.56% 77.95% +0.39%
==========================================
Files 113 113
Lines 19025 19087 +62
==========================================
+ Hits 14757 14880 +123
+ Misses 4268 4207 -61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
spenke91
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is well-written and -documented code, thanks! :-)
I just have a bunch of minor remarks. As usual, feel free to ignore them or argue with me on them -- I think this time I would consider pretty much all of them optional 👍
Co-authored-by: spenke91 <thomas.spenke@dlr.de>
spenke91
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go 👍
Closes #2085
Describe your changes here:
This PR adds multiple functions to the element of a mesh handle, e.g. the diameter and face related functionality as the area of a specific face. We have caches for new functions and new functionality is tested.
Moreover the code is largely restructured to make it shorter and important functions in the element are more visible now.
The testing strategy is sharpened and documented.
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).