Improvement: Move CAD management to t8_cad_handle with cmesh ownership #2093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LenaRadmer
changed the title
sandro-elsweijer
requested changes
Jan 27, 2026
|
|
||
| #include <t8.h> | ||
| #include <t8_cad/t8_cad.hxx> | ||
| #include <t8_cad_handle/t8_cad_handle.hxx> |
Member
There was a problem hiding this comment.
The folder should still be called t8_cad. It is the t8code module about cad. t8_cad_handle is just one part of it
| { | ||
| /* Map the new cad shape. */ | ||
| t8_cad_handle::map_cad_shape (new_cad_shape); | ||
| } |
Member
There was a problem hiding this comment.
There is probably a way to achieve the same thing with less functions. What we definitely need are:
constructor from file
constructor from shape
destructor
load from file
load from shape
| public: | ||
| /** | ||
| * Constructor of the cad shape. | ||
| * Constructor of the cad shape handler. |
Member
There was a problem hiding this comment.
Suggested change
| * Constructor of the cad shape handler. | |
| * Constructor of the cad shape handle. |
| * \param [in] fileprefix Prefix of a .brep file from which to extract cad geometry. | ||
| * \return The loaded cad shape. | ||
| */ | ||
| static TopoDS_Shape |
Member
There was a problem hiding this comment.
A static member function means something different than a static function
Member
There was a problem hiding this comment.
what you probably want to use is private
| unref () | ||
| { | ||
| if (t8_refcount_unref (&rc)) { | ||
| t8_debugf ("Deleting the cad_handler.\n"); |
Member
There was a problem hiding this comment.
Suggested change
| t8_debugf ("Deleting the cad_handler.\n"); | |
| t8_debugf ("Deleting the cad_handle.\n"); |
| } | ||
|
|
||
| /** | ||
| * Decrease the reference count of the cad handler. |
Member
There was a problem hiding this comment.
Suggested change
| * Decrease the reference count of the cad handler. | |
| * Decrease the reference count of the cad handle. |
| is_surface_closed (int geometry_index, int parameter) const; | ||
|
|
||
| /** | ||
| * Increase the reference count of the cad handler. |
Member
There was a problem hiding this comment.
Suggested change
| * Increase the reference count of the cad handler. | |
| * Increase the reference count of the cad handle. |
| t8_cad_handle (); | ||
|
|
||
| /** | ||
| * Destructor of the cad shape handler. |
Member
There was a problem hiding this comment.
Suggested change
| * Destructor of the cad shape handler. | |
| * Destructor of the cad shape handle. |
|
|
||
| /** | ||
| * Decrease the reference count of the cad handler. | ||
| * If the reference count reaches zero, the cad handler is deleted. |
Member
There was a problem hiding this comment.
Suggested change
| * If the reference count reaches zero, the cad handler is deleted. | |
| * If the reference count reaches zero, the cad handle is deleted. |
| cad_shape_vertex2edge_map; /**< Maps all TopoDS_Vertex of shape to all its connected TopoDS_Edge */ | ||
| TopTools_IndexedDataMapOfShapeListOfShape | ||
| cad_shape_edge2face_map; /**< Maps all TopoDS_Edge of shape to all its connected TopoDS_Face */ | ||
| /** The reference count of the cad handler. TODO: Replace by shared_ptr when cmesh becomes a class. */ |
Member
There was a problem hiding this comment.
Suggested change
| /** The reference count of the cad handler. TODO: Replace by shared_ptr when cmesh becomes a class. */ | |
| /** The reference count of the cad handle. TODO: Replace by shared_ptr when cmesh becomes a class. */ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes here:
Changing t8_cad to t8_cad_handle for a more explicit CAD shape management. The cmesh now owns the CAD handle and uses a reference counter to manage it.
Also, the t8_geom prefix was removed for everything related to CAD shape management for cleanup. The mesh reader and geometry implementations were updated to support this new handle system.
All these boxes must be checked by the AUTHOR before requesting review:
Documentation:,Bugfix:,Feature:,Improvement:orOther:.All these boxes must be checked by the REVIEWERS before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
Tests
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scpto check the indentation of these files.License
doc/(or already has one).