[ACE6] Fixes for IPv6 multicast and inet_ntop/inet_pton on Windows #1352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwillemsen
reviewed
Dec 23, 2020
Member
|
Also open a PR with the same change for master |
Contributor
Author
Sure. I am new to the process - should I have just opened this PR to the master, or should I have both PRs open in parallel? |
Member
|
You can open both in paralllel when you want to have the change in ACE 7x and ACE 6.x |
mitza-oci
requested changes
Jan 4, 2021
mitza-oci
requested changes
Jan 4, 2021
mitza-oci
approved these changes
Jan 4, 2021
Member
|
@jwillemsen how do we see what actually failed? The "Details" link doesn't show anything |
Member
I have the same issue in #1357 |
Member
|
Strange, that worked in the past, maybe an issue on github actions currently, I restarted the failing checks |
mitza-oci
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed logic for GetAdaptersAddresses as per Microsoft guidelines:
https://docs.microsoft.com/en-us/windows/win32/api/iphlpapi/nf-iphlpapi-getadaptersaddresses
Fixed definitions for