Fix Floating Point Constant Expressions in tao_idl #1715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes DOCGroup#1713 and adds a test. Also makes some other minor fixes and improvments to AST_Expression.
mitza-oci
requested changes
Nov 4, 2021
jwillemsen
reviewed
Nov 5, 2021
| const double div = a / b; | ||
| const double mul = a * b; | ||
| const double add = a + b; | ||
| const double sub = a - b; |
Member
There was a problem hiding this comment.
Maybe add long double and long long test cases?
jwillemsen
approved these changes
Nov 5, 2021
mitza-oci
approved these changes
Nov 5, 2021
iguessthislldo
added a commit
to iguessthislldo/ACE_TAO
that referenced
this pull request
Nov 9, 2021
Backport of DOCGroup#1715 Fixes DOCGroup#1713 and adds some regression tests for constant expressions. Also tried to do some more cleanup and minor fixes related to DOCGroup#840.
Member
|
One new warning, see https://buildlogs.remedy.nl/win_vs2019_opendds_debug/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1713 and adds some regression tests for constant expressions. Also tried to do some more cleanup and minor fixes related to #840.