Skip to content

Conversation

@jwillemsen
Copy link
Member

@jwillemsen jwillemsen commented Jan 7, 2026

Forward port of #2498

Summary by CodeRabbit

  • Chores
    • Updated build configuration settings to optimize code compilation behavior.

✏️ Tip: You can customize this high-level summary in your review settings.

    * ACE/bin/MakeProjectCreator/config/acedefaults.mpb:
@jwillemsen jwillemsen merged commit 63243fd into DOCGroup:master Jan 7, 2026
34 of 36 checks passed
@jwillemsen jwillemsen deleted the jwi-bmakenoinline branch January 7, 2026 12:40
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 7, 2026

Caution

Review failed

The pull request is closed.

Walkthrough

Removed the ACE_NO_INLINE=1 macro assignment from the Borland Make project type's debug configuration in the ACE build defaults file. This allows inlining to remain enabled for Borland Make debug builds rather than being explicitly disabled.

Changes

Cohort / File(s) Summary
Build Configuration
ACE/bin/MakeProjectCreator/config/acedefaults.mpb
Removed ACE_NO_INLINE=1 from debug_macros in the Borland Make project type block, enabling inlining for bmake debug configurations

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit hops with glee so bright,
One line removed—no more!—takes flight,
Now inlining flows like morning dew,
Borland builds faster, bold and true! 🐰✨

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4d74f4c and 36c40ac.

📒 Files selected for processing (1)
  • ACE/bin/MakeProjectCreator/config/acedefaults.mpb

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant