Fixes Related to The Test Matrix #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `scoreboard.pl`:
- Removed an what looks like an unused function call to fix
DOCGroup#75.
- Fix a warning
- Clean up `*.build.json` files.
- `matrix.py`:
- Fixed a issue on Chromium browsers where the test names would always
get a scroll bar that would about double the size of the rows and
impact the usability of the matrix. Removed explicit overflow
property to fix this.
- Fixes so ACE/TAO scoreboard can use the test matrix:
- Remove dependency on `scoreboard.pl -c` option, which creates
the build directories and downloads the `*.build.json` files.
- Fix a Python Type error for average test time when a matrix is
empty. This is the case for ACE6 builds at the moment.
Member
Author
|
As far as I know, basically everything about the test matrix should work with ACE/TAO. The one thing I can't fix easily for ACE is the fact that it doesn't use real paths and that results in invalid GitHub file links:
For TAO and OpenDDS these go to the |
Member
|
When it doesn't break anything ok for me |
mitza-oci
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for #74
scoreboard.pl:*.build.jsonfiles.matrix.py:overflow-x: scrollCSS property to fix this.scoreboard.pl -coption, which creates the build directories and downloads the*.build.jsonfiles for us. OpenDDS uses-c, but ACE/TAO doesn't.