Revert changes

[iguessthislldo]

Revert changes from #79 that broke OpenDDS scoreboard.

[coderabbitai]

Walkthrough

The changes introduce a new subroutine, update_latest_build_info, in scoreboard.pl. This subroutine reads the file latest.txt from a given directory to extract build information with a regular expression, updating a global %builds hash and delegating to set_latest_build_info. The existing local_update_cache subroutine is modified to call update_latest_build_info directly, centralizing and simplifying the error handling and update mechanism.

Changes

File(s)	Summary
scoreboard.pl	- Added the update_latest_build_info subroutine to read and update build info from latest.txt. - Modified local_update_cache to call the new subroutine and removed previous error handling.

Sequence Diagram(s)

sequenceDiagram
    participant LUC as local_update_cache
    participant ULB as update_latest_build_info
    participant SLI as set_latest_build_info
    participant IO as File (latest.txt)
    
    LUC->>ULB: Call update_latest_build_info(directory, build name)
    ULB->>IO: Read latest.txt
    IO-->>ULB: Return file content / error
    alt File found
        ULB->>Global: Update %builds with latest build info
        ULB->>SLI: Call set_latest_build_info
        ULB-->>LUC: Return success (1)
    else File missing/error
        ULB-->>LUC: Print error and return failure (0)
    end

Loading

Possibly related PRs

• Clean up *.build.json files #79: Related changes in scoreboard.pl integrating output functions, affecting build information and log deletion.

Suggested reviewers

• mitza-oci
• jwillemsen

Poem

I'm the coding rabbit, hopping with delight,
Found new grooves where build info shines bright.
update_latest_build_info leads the clever parade,
Queueing updates in each code barricade.
With a hop and a skip, our logs are all right!
🐇💻

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1d5cb73 and eccf995.

📒 Files selected for processing (1)

• scoreboard.pl (2 hunks)

🔇 Additional comments (2)

scoreboard.pl (2)

209-235: Well-implemented centralized function for updating latest build info.

This new subroutine centralizes the logic for reading the latest build information from a file and updating the %builds hash. It has proper error handling for file operations and returns appropriate status codes.

---

795-795: Simplifies code by using the new centralized function.

This change replaces previous error handling and update logic with a single call to the new update_latest_build_info function, improving code maintainability.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.