Conversation
Collaborator
|
Looks good to me. Normally, we should avoid patching the upstream API; however, this is a shorterm fix until the |
thodson-usgs
approved these changes
Jun 13, 2025
BojanMilinic
left a comment
There was a problem hiding this comment.
The code itself looks good and all the checks at least pass on windows. I am interested in the "Did you mean to use assert instead of return?" error for the Ubuntu runs.
Collaborator
Author
Thanks for identifying this bug with the services and taking a look, @BojanMilinic. @thodson-usgs and I plan to address this testing issue in a subsequent PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small PR adds a filtering step to the
get_gwlevelsfunction that ensures only the requested pcodes are returned. For whatever reason, the "new" gwlevels endpoint doesn't seem to recognize theparameterCdargument, even though it is still specified in the documentation: https://nwis.waterservices.usgs.gov/docs/groundwater-levels/groundwater-levels-details/See Issue #179