Skip to content

Align sass version pin with ecosystem#5104

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
alanorth:sass-deps
Feb 13, 2026
Merged

Align sass version pin with ecosystem#5104
tdonohue merged 1 commit intoDSpace:mainfrom
alanorth:sass-deps

Conversation

@alanorth
Copy link
Contributor

@alanorth alanorth commented Feb 12, 2026

Description

Use "^" instead of "~" to match dependabot's behavior, which bumps minor and patch releases. This is also closer to the behavior of sass-loader, which we use and also depends on sass.

See: https://github.com/DSpace/dspace-angular/blob/main/.github/dependabot.yml#L73-L80
See: https://github.com/webpack/sass-loader/blob/v12.6.0/package.json

Note: next we should evaluate moving to a newer version of sass-loader, as ours is 4 years old, as well as migrating to sass-embedded, which is the recommended implementation of sass as of 2024. This can also result in massive performance increases.

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

List of changes in this PR:

  • Update sass version pin in package.json

Include guidance for how to test or review your PR.

To test this PR you should run npm install and then npm run start:prod and make sure the build works without any new errors or warnings, and that the site's style looks OK.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

Use "^" instead of "~" to match dependabot's behavior, which bumps
minor and patch releases. This is also closer to the behavior of
sass-loader, which we use and also depends on sass.
@alanorth alanorth added dependencies Pull requests that update a dependency file 1 APPROVAL pull request only requires a single approval to merge labels Feb 12, 2026
@tdonohue tdonohue moved this to 👍 Reviewer Approved in DSpace 10.0 Release Feb 12, 2026
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @alanorth ! This looks good to me too

@tdonohue tdonohue added this to the 10.0 milestone Feb 13, 2026
@tdonohue tdonohue merged commit b5f4c94 into DSpace:main Feb 13, 2026
16 checks passed
@github-project-automation github-project-automation bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 10.0 Release Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge dependencies Pull requests that update a dependency file

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants

Comments