Align sass version pin with ecosystem#5104
Merged
tdonohue merged 1 commit intoDSpace:mainfrom Feb 13, 2026
Merged
Conversation
Use "^" instead of "~" to match dependabot's behavior, which bumps minor and patch releases. This is also closer to the behavior of sass-loader, which we use and also depends on sass.
pcg-kk
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use "^" instead of "~" to match dependabot's behavior, which bumps minor and patch releases. This is also closer to the behavior of sass-loader, which we use and also depends on sass.
See: https://github.com/DSpace/dspace-angular/blob/main/.github/dependabot.yml#L73-L80
See: https://github.com/webpack/sass-loader/blob/v12.6.0/package.json
Note: next we should evaluate moving to a newer version of sass-loader, as ours is 4 years old, as well as migrating to sass-embedded, which is the recommended implementation of sass as of 2024. This can also result in massive performance increases.
Instructions for Reviewers
Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.
List of changes in this PR:
package.jsonInclude guidance for how to test or review your PR.
To test this PR you should run
npm installand thennpm run start:prodand make sure the build works without any new errors or warnings, and that the site's style looks OK.Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.