Skip to content

[Port dspace-9_x] Enhance FileSizePipe to support localization#5110

Merged
tdonohue merged 1 commit intoDSpace:dspace-9_xfrom
saschaszott:saschaszott-patch-16
Feb 13, 2026
Merged

[Port dspace-9_x] Enhance FileSizePipe to support localization#5110
tdonohue merged 1 commit intoDSpace:dspace-9_xfrom
saschaszott:saschaszott-patch-16

Conversation

@saschaszott
Copy link
Contributor

Description

This PR backports #5055 to DSpace version 9 and is expected to apply to versions 7 and 8 as well.

@saschaszott
Copy link
Contributor Author

@tdonohue , this PR is ready for review ;)

@tdonohue tdonohue changed the title Enhance FileSizePipe to support locale in formatting [Port dspace-9_x] Enhance FileSizePipe to support localization Feb 13, 2026
@tdonohue tdonohue added i18n / l10n Internationalisation and localisation, related to message catalogs 1 APPROVAL pull request only requires a single approval to merge labels Feb 13, 2026
@tdonohue tdonohue added this to the 9.3 milestone Feb 13, 2026
@tdonohue tdonohue added port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Feb 13, 2026
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @saschaszott ! I've verified this is an accurate backport of #5055. Merging immediately & attempting to auto-backport to 8.x and 7.x

@tdonohue tdonohue merged commit 13435e6 into DSpace:dspace-9_x Feb 13, 2026
16 checks passed
@github-project-automation github-project-automation bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace Maintenance (9.x, 8.x, 7.6.x) Feb 13, 2026
@dspace-bot
Copy link
Contributor

Backport failed for dspace-7_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-7_x
git worktree add -d .worktree/backport-5110-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-5110-to-dspace-7_x
git switch --create backport-5110-to-dspace-7_x
git cherry-pick -x e75bb3d25e50367afae66aff939c6035be2f225a

@dspace-bot
Copy link
Contributor

Backport failed for dspace-8_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-8_x
git worktree add -d .worktree/backport-5110-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-5110-to-dspace-8_x
git switch --create backport-5110-to-dspace-8_x
git cherry-pick -x e75bb3d25e50367afae66aff939c6035be2f225a

@tdonohue
Copy link
Member

@saschaszott : The auto-backport to 8.x and 7.x failed from this PR as well. In my opinion, it's "good enough" to just backport this fix to 9.x (as that's all we promise in our software support policy).

But, if you had an interest in backporting it further, I'd help review the PRs.

@tdonohue tdonohue removed port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs

Projects

Development

Successfully merging this pull request may close these issues.

3 participants

Comments