Skip to content

fix: align action buttons in empty bundles on Bitstreams tab#5116

Merged
tdonohue merged 1 commit intoDSpace:mainfrom
LakshmiSravya123:fix/5115-bundle-action-alignment
Feb 16, 2026
Merged

fix: align action buttons in empty bundles on Bitstreams tab#5116
tdonohue merged 1 commit intoDSpace:mainfrom
LakshmiSravya123:fix/5115-bundle-action-alignment

Conversation

@LakshmiSravya123
Copy link

Summary

  • Add missing columnSizes.columns[3].buildClasses() to the bundle-row action <td> in item-edit-bitstream-bundle.component.html
  • The header <th> and bitstream-row <td> already use this class to size the Actions column, but the bundle-row <td> was missing it
  • Without this class, when a bundle is empty (no bitstreams), the action buttons don't align vertically because the column width isn't constrained

Closes #5115

Test plan

  • Create 2+ empty bundles in Edit Item → Bitstreams tab
  • Verify the upload and settings buttons are vertically aligned across all empty bundles
  • Verify bundles with bitstreams still display correctly

…5115)

The bundle row's action column was missing the column size class that
the header and bitstream rows use. Without it, the action buttons
don't align vertically when a bundle has no bitstreams.

Add columnSizes.columns[3].buildClasses() to the bundle-row action td,
matching the pattern used in the header th and bitstream-row td elements.
@MMilosz
Copy link
Contributor

MMilosz commented Feb 15, 2026

Tested locally. LGTM!

Before

image

After

image image

@MMilosz MMilosz self-requested a review February 15, 2026 09:55
@lgeggleston lgeggleston added bug 1 APPROVAL pull request only requires a single approval to merge low priority component: Item (Archived) Item display or editing ux User Experience related works labels Feb 16, 2026
@lgeggleston lgeggleston moved this to 👍 Reviewer Approved in DSpace 10.0 Release Feb 16, 2026
@tdonohue tdonohue added the port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release label Feb 16, 2026
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @LakshmiSravya123 ! Looks good. This same flaw seems to exist also on 9.x, so I'm backporting to 9.x

@tdonohue tdonohue added this to the 10.0 milestone Feb 16, 2026
@tdonohue tdonohue merged commit a59cdfd into DSpace:main Feb 16, 2026
16 checks passed
@github-project-automation github-project-automation bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 10.0 Release Feb 16, 2026
@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-9_x:

@tdonohue tdonohue removed the port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release label Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug component: Item (Archived) Item display or editing low priority ux User Experience related works

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Visual misalignment of action buttons in empty DSpace bundles (Bitstreams tab in Edit Item view)

5 participants