Renderer: use exposure even when tone mapping is off #1885
Conversation
Multiply the pixel color by r_toneMappingExposure even when tone mapping is disabled. For the next release the cvar should be renamed to reflect its separation from tone mapping. Fixes DaemonEngine#1628.
since it can now be used without tone mapping.
|
That seems like it can break configs if someone e. g. used it in |
This renames the internal variable, not the |
The comment says:
|
|
Ah yes. The sentence you quoted didn't mention that, and the currently proposed code doesn't do that yet. To be honest I'm in favor of the renaming of the cvar. We are still in beta and if every first implementation is written in stone and we cannot use our experience and testing to make it better it becomes hard to do things. As a side note I would like to have a cvar alias mechanism so using an old name sets the new cvar, but we haven't that yet. |
| // TODO(0.56): rename because it can be used without tone mapping now | ||
| Cvar::Cvar<float> r_toneMappingExposure( | ||
| "r_toneMappingExposure", "Tonemap exposure", Cvar::NONE, 1.0f ); | ||
| "r_toneMappingExposure", "exposure (brightness adjustment)", Cvar::NONE, 1.0f ); |
illwieckz
left a comment
illwieckz
left a comment
There was a problem hiding this comment.
LGTM, with the capitalization.
3 participants
Fixes #1628