-
Notifications
You must be signed in to change notification settings - Fork 323
Mitigate user prefs lock #10231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Mitigate user prefs lock #10231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 12 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.57.0-SNAPSHOT~f2184f4bf5, baseline=1.57.0-SNAPSHOT~dda618e90d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.089 s) : 0, 1088609
Total [baseline] (8.791 s) : 0, 8790532
Agent [candidate] (1.082 s) : 0, 1081925
Total [candidate] (8.723 s) : 0, 8722975
section iast
Agent [baseline] (1.218 s) : 0, 1218405
Total [baseline] (9.339 s) : 0, 9338991
Agent [candidate] (1.22 s) : 0, 1220084
Total [candidate] (9.316 s) : 0, 9316441
gantt
title insecure-bank - break down per module: candidate=1.57.0-SNAPSHOT~f2184f4bf5, baseline=1.57.0-SNAPSHOT~dda618e90d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (652.869 ms) : 0, 652869
BytebuddyAgent [candidate] (649.234 ms) : 0, 649234
GlobalTracer [baseline] (284.694 ms) : 0, 284694
GlobalTracer [candidate] (283.312 ms) : 0, 283312
AppSec [baseline] (32.672 ms) : 0, 32672
AppSec [candidate] (32.353 ms) : 0, 32353
Debugger [baseline] (67.682 ms) : 0, 67682
Debugger [candidate] (66.864 ms) : 0, 66864
Remote Config [baseline] (659.874 µs) : 0, 660
Remote Config [candidate] (620.826 µs) : 0, 621
Telemetry [baseline] (9.228 ms) : 0, 9228
Telemetry [candidate] (9.076 ms) : 0, 9076
Flare Poller [baseline] (3.851 ms) : 0, 3851
Flare Poller [candidate] (3.716 ms) : 0, 3716
section iast
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (788.217 ms) : 0, 788217
BytebuddyAgent [candidate] (788.821 ms) : 0, 788821
GlobalTracer [baseline] (255.291 ms) : 0, 255291
GlobalTracer [candidate] (256.097 ms) : 0, 256097
IAST [baseline] (27.019 ms) : 0, 27019
IAST [candidate] (26.902 ms) : 0, 26902
AppSec [baseline] (34.31 ms) : 0, 34310
AppSec [candidate] (34.494 ms) : 0, 34494
Debugger [baseline] (64.53 ms) : 0, 64530
Debugger [candidate] (64.713 ms) : 0, 64713
Remote Config [baseline] (571.481 µs) : 0, 571
Remote Config [candidate] (591.403 µs) : 0, 591
Telemetry [baseline] (8.352 ms) : 0, 8352
Telemetry [candidate] (8.397 ms) : 0, 8397
Flare Poller [baseline] (3.523 ms) : 0, 3523
Flare Poller [candidate] (3.479 ms) : 0, 3479
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.57.0-SNAPSHOT~f2184f4bf5, baseline=1.57.0-SNAPSHOT~dda618e90d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.09 s) : 0, 1089548
Total [baseline] (10.883 s) : 0, 10883200
Agent [candidate] (1.084 s) : 0, 1083588
Total [candidate] (10.966 s) : 0, 10966277
section appsec
Agent [baseline] (1.262 s) : 0, 1262299
Total [baseline] (11.026 s) : 0, 11025632
Agent [candidate] (1.265 s) : 0, 1264726
Total [candidate] (11.089 s) : 0, 11089093
section iast
Agent [baseline] (1.24 s) : 0, 1239946
Total [baseline] (11.272 s) : 0, 11271501
Agent [candidate] (1.224 s) : 0, 1223849
Total [candidate] (11.198 s) : 0, 11198319
section profiling
Agent [baseline] (1.205 s) : 0, 1205458
Total [baseline] (10.995 s) : 0, 10995121
Agent [candidate] (1.205 s) : 0, 1204967
Total [candidate] (10.91 s) : 0, 10910384
gantt
title petclinic - break down per module: candidate=1.57.0-SNAPSHOT~f2184f4bf5, baseline=1.57.0-SNAPSHOT~dda618e90d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (653.449 ms) : 0, 653449
BytebuddyAgent [candidate] (649.984 ms) : 0, 649984
GlobalTracer [baseline] (284.426 ms) : 0, 284426
GlobalTracer [candidate] (282.975 ms) : 0, 282975
AppSec [baseline] (32.635 ms) : 0, 32635
AppSec [candidate] (32.424 ms) : 0, 32424
Debugger [baseline] (67.138 ms) : 0, 67138
Debugger [candidate] (67.965 ms) : 0, 67965
Remote Config [baseline] (629.348 µs) : 0, 629
Remote Config [candidate] (632.535 µs) : 0, 633
Telemetry [baseline] (9.74 ms) : 0, 9740
Telemetry [candidate] (9.045 ms) : 0, 9045
Flare Poller [baseline] (4.661 ms) : 0, 4661
Flare Poller [candidate] (3.734 ms) : 0, 3734
section appsec
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (687.907 ms) : 0, 687907
BytebuddyAgent [candidate] (689.054 ms) : 0, 689054
GlobalTracer [baseline] (258.935 ms) : 0, 258935
GlobalTracer [candidate] (258.788 ms) : 0, 258788
IAST [baseline] (24.529 ms) : 0, 24529
IAST [candidate] (24.698 ms) : 0, 24698
AppSec [baseline] (171.301 ms) : 0, 171301
AppSec [candidate] (172.118 ms) : 0, 172118
Debugger [baseline] (69.351 ms) : 0, 69351
Debugger [candidate] (69.719 ms) : 0, 69719
Remote Config [baseline] (706.263 µs) : 0, 706
Remote Config [candidate] (689.585 µs) : 0, 690
Telemetry [baseline] (9.016 ms) : 0, 9016
Telemetry [candidate] (9.026 ms) : 0, 9026
Flare Poller [baseline] (3.76 ms) : 0, 3760
Flare Poller [candidate] (3.794 ms) : 0, 3794
section iast
crashtracking [baseline] (1.198 ms) : 0, 1198
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (802.263 ms) : 0, 802263
BytebuddyAgent [candidate] (789.914 ms) : 0, 789914
GlobalTracer [baseline] (259.292 ms) : 0, 259292
GlobalTracer [candidate] (255.963 ms) : 0, 255963
IAST [baseline] (27.606 ms) : 0, 27606
IAST [candidate] (27.185 ms) : 0, 27185
AppSec [baseline] (34.973 ms) : 0, 34973
AppSec [candidate] (33.607 ms) : 0, 33607
Debugger [baseline] (66.264 ms) : 0, 66264
Debugger [candidate] (67.688 ms) : 0, 67688
Remote Config [baseline] (559.869 µs) : 0, 560
Remote Config [candidate] (608.621 µs) : 0, 609
Telemetry [baseline] (8.5 ms) : 0, 8500
Telemetry [candidate] (8.612 ms) : 0, 8612
Flare Poller [baseline] (3.487 ms) : 0, 3487
Flare Poller [candidate] (3.559 ms) : 0, 3559
section profiling
crashtracking [baseline] (1.223 ms) : 0, 1223
crashtracking [candidate] (1.207 ms) : 0, 1207
BytebuddyAgent [baseline] (701.073 ms) : 0, 701073
BytebuddyAgent [candidate] (702.174 ms) : 0, 702174
GlobalTracer [baseline] (221.593 ms) : 0, 221593
GlobalTracer [candidate] (221.126 ms) : 0, 221126
AppSec [baseline] (32.004 ms) : 0, 32004
AppSec [candidate] (32.16 ms) : 0, 32160
Debugger [baseline] (68.532 ms) : 0, 68532
Debugger [candidate] (68.372 ms) : 0, 68372
Remote Config [baseline] (630.603 µs) : 0, 631
Remote Config [candidate] (635.909 µs) : 0, 636
Telemetry [baseline] (9.013 ms) : 0, 9013
Telemetry [candidate] (8.806 ms) : 0, 8806
Flare Poller [baseline] (3.792 ms) : 0, 3792
Flare Poller [candidate] (3.729 ms) : 0, 3729
ProfilingAgent [baseline] (97.818 ms) : 0, 97818
ProfilingAgent [candidate] (96.872 ms) : 0, 96872
Profiling [baseline] (98.42 ms) : 0, 98420
Profiling [candidate] (97.439 ms) : 0, 97439
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~f2184f4bf5, baseline=1.57.0-SNAPSHOT~dda618e90d
dateFormat X
axisFormat %s
section baseline
no_agent (18.018 ms) : 17836, 18200
. : milestone, 18018,
appsec (19.577 ms) : 19377, 19778
. : milestone, 19577,
code_origins (17.826 ms) : 17649, 18002
. : milestone, 17826,
iast (18.17 ms) : 17988, 18352
. : milestone, 18170,
profiling (18.606 ms) : 18421, 18791
. : milestone, 18606,
tracing (18.623 ms) : 18435, 18812
. : milestone, 18623,
section candidate
no_agent (18.216 ms) : 18027, 18405
. : milestone, 18216,
appsec (18.97 ms) : 18778, 19163
. : milestone, 18970,
code_origins (18.818 ms) : 18628, 19009
. : milestone, 18818,
iast (17.859 ms) : 17680, 18038
. : milestone, 17859,
profiling (18.622 ms) : 18434, 18809
. : milestone, 18622,
tracing (17.532 ms) : 17357, 17706
. : milestone, 17532,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.57.0-SNAPSHOT~f2184f4bf5, baseline=1.57.0-SNAPSHOT~dda618e90d
dateFormat X
axisFormat %s
section baseline
no_agent (1.184 ms) : 1173, 1195
. : milestone, 1184,
iast (3.108 ms) : 3072, 3145
. : milestone, 3108,
iast_FULL (5.889 ms) : 5829, 5949
. : milestone, 5889,
iast_GLOBAL (3.638 ms) : 3583, 3693
. : milestone, 3638,
profiling (2.008 ms) : 1989, 2026
. : milestone, 2008,
tracing (1.764 ms) : 1749, 1778
. : milestone, 1764,
section candidate
no_agent (1.17 ms) : 1158, 1181
. : milestone, 1170,
iast (3.198 ms) : 3158, 3238
. : milestone, 3198,
iast_FULL (5.857 ms) : 5798, 5916
. : milestone, 5857,
iast_GLOBAL (3.615 ms) : 3558, 3672
. : milestone, 3615,
profiling (1.912 ms) : 1896, 1928
. : milestone, 1912,
tracing (1.795 ms) : 1780, 1811
. : milestone, 1795,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~f2184f4bf5, baseline=1.57.0-SNAPSHOT~dda618e90d
dateFormat X
axisFormat %s
section baseline
no_agent (15.547 s) : 15547000, 15547000
. : milestone, 15547000,
appsec (14.698 s) : 14698000, 14698000
. : milestone, 14698000,
iast (18.35 s) : 18350000, 18350000
. : milestone, 18350000,
iast_GLOBAL (17.769 s) : 17769000, 17769000
. : milestone, 17769000,
profiling (14.964 s) : 14964000, 14964000
. : milestone, 14964000,
tracing (14.771 s) : 14771000, 14771000
. : milestone, 14771000,
section candidate
no_agent (14.958 s) : 14958000, 14958000
. : milestone, 14958000,
appsec (14.736 s) : 14736000, 14736000
. : milestone, 14736000,
iast (18.141 s) : 18141000, 18141000
. : milestone, 18141000,
iast_GLOBAL (18.118 s) : 18118000, 18118000
. : milestone, 18118000,
profiling (14.627 s) : 14627000, 14627000
. : milestone, 14627000,
tracing (14.738 s) : 14738000, 14738000
. : milestone, 14738000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.57.0-SNAPSHOT~f2184f4bf5, baseline=1.57.0-SNAPSHOT~dda618e90d
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (2.453 ms) : 2402, 2505
. : milestone, 2453,
iast (2.211 ms) : 2147, 2275
. : milestone, 2211,
iast_GLOBAL (2.245 ms) : 2181, 2309
. : milestone, 2245,
profiling (2.089 ms) : 2035, 2144
. : milestone, 2089,
tracing (2.037 ms) : 1986, 2087
. : milestone, 2037,
section candidate
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (3.628 ms) : 3412, 3843
. : milestone, 3628,
iast (2.197 ms) : 2133, 2261
. : milestone, 2197,
iast_GLOBAL (2.245 ms) : 2181, 2309
. : milestone, 2245,
profiling (2.063 ms) : 2011, 2116
. : milestone, 2063,
tracing (2.04 ms) : 1989, 2090
. : milestone, 2040,
|
AlexeyKuznetsov-DD
approved these changes
Dec 17, 2025
jandro996
pushed a commit
that referenced
this pull request
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Move the Gradle daemon user prefs location to a different location.
Motivation
Filing steps, due to user preferences locking contention.
Symptom:
User preferences are still a bottleneck for some steps, in particular the
5/6slot for instrumentation tests.Analysis
This is still happening, the reason is that on Linux, the
Preferencesbackend is aFileSystemPreferences.Whoever request the user preferences, trigger the following automatic flush mechanism, that will happen
java.util.prefs.syncIntervalproperty, default 30s)Gradle is configured to have 4 active parallel workers via the
--max-workersflag (otherwise the default would be 10, the number of requested CPU). Possibly they are started around the same time and contend on this lock.Who is writing there
Groovy !
This is a follow-up of the mitigations in
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]