-
Notifications
You must be signed in to change notification settings - Fork 322
Add CapturedContext interface implementation #10248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SpanDecorationProbe use also the CaptureContext instrumentation so need to implement the interface. this fixes the class cast exception.
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (324.935 µs) : 283, 367
. : milestone, 325,
basic (278.227 µs) : 271, 285
. : milestone, 278,
loop (8.971 ms) : 8966, 8976
. : milestone, 8971,
section candidate
noprobe (313.412 µs) : 284, 343
. : milestone, 313,
basic (273.252 µs) : 267, 280
. : milestone, 273,
loop (8.962 ms) : 8957, 8966
. : milestone, 8962,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.58.0-SNAPSHOT~02de9b7ed9, baseline=1.58.0-SNAPSHOT~c2f3bfbd56
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.093 s) : 0, 1093092
Total [baseline] (8.769 s) : 0, 8769337
Agent [candidate] (1.084 s) : 0, 1083887
Total [candidate] (8.764 s) : 0, 8763587
section iast
Agent [baseline] (1.231 s) : 0, 1230737
Total [baseline] (9.352 s) : 0, 9351637
Agent [candidate] (1.22 s) : 0, 1219644
Total [candidate] (9.396 s) : 0, 9395669
gantt
title insecure-bank - break down per module: candidate=1.58.0-SNAPSHOT~02de9b7ed9, baseline=1.58.0-SNAPSHOT~c2f3bfbd56
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.206 ms) : 0, 1206
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (657.828 ms) : 0, 657828
BytebuddyAgent [candidate] (650.712 ms) : 0, 650712
GlobalTracer [baseline] (284.355 ms) : 0, 284355
GlobalTracer [candidate] (283.32 ms) : 0, 283320
AppSec [baseline] (32.57 ms) : 0, 32570
AppSec [candidate] (32.261 ms) : 0, 32261
Debugger [baseline] (67.75 ms) : 0, 67750
Debugger [candidate] (67.281 ms) : 0, 67281
Remote Config [baseline] (632.285 µs) : 0, 632
Remote Config [candidate] (635.295 µs) : 0, 635
Telemetry [baseline] (9.167 ms) : 0, 9167
Telemetry [candidate] (9.117 ms) : 0, 9117
Flare Poller [baseline] (3.712 ms) : 0, 3712
Flare Poller [candidate] (3.775 ms) : 0, 3775
section iast
crashtracking [baseline] (1.204 ms) : 0, 1204
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (796.147 ms) : 0, 796147
BytebuddyAgent [candidate] (788.28 ms) : 0, 788280
GlobalTracer [baseline] (257.835 ms) : 0, 257835
GlobalTracer [candidate] (255.694 ms) : 0, 255694
AppSec [baseline] (34.803 ms) : 0, 34803
AppSec [candidate] (31.055 ms) : 0, 31055
Debugger [baseline] (65.139 ms) : 0, 65139
Debugger [candidate] (68.239 ms) : 0, 68239
Remote Config [baseline] (601.538 µs) : 0, 602
Remote Config [candidate] (598.385 µs) : 0, 598
Telemetry [baseline] (8.501 ms) : 0, 8501
Telemetry [candidate] (8.536 ms) : 0, 8536
Flare Poller [baseline] (3.557 ms) : 0, 3557
Flare Poller [candidate] (3.551 ms) : 0, 3551
IAST [baseline] (27.237 ms) : 0, 27237
IAST [candidate] (27.104 ms) : 0, 27104
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.58.0-SNAPSHOT~02de9b7ed9, baseline=1.58.0-SNAPSHOT~c2f3bfbd56
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.098 s) : 0, 1097924
Total [baseline] (10.82 s) : 0, 10820153
Agent [candidate] (1.081 s) : 0, 1081495
Total [candidate] (10.849 s) : 0, 10848732
section appsec
Agent [baseline] (1.273 s) : 0, 1273453
Total [baseline] (10.99 s) : 0, 10990409
Agent [candidate] (1.267 s) : 0, 1266724
Total [candidate] (11.033 s) : 0, 11032615
section iast
Agent [baseline] (1.227 s) : 0, 1226668
Total [baseline] (11.254 s) : 0, 11253778
Agent [candidate] (1.231 s) : 0, 1231003
Total [candidate] (11.276 s) : 0, 11276418
section profiling
Agent [baseline] (1.207 s) : 0, 1207433
Total [baseline] (10.835 s) : 0, 10835189
Agent [candidate] (1.205 s) : 0, 1205283
Total [candidate] (10.931 s) : 0, 10930987
gantt
title petclinic - break down per module: candidate=1.58.0-SNAPSHOT~02de9b7ed9, baseline=1.58.0-SNAPSHOT~c2f3bfbd56
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.204 ms) : 0, 1204
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (659.027 ms) : 0, 659027
BytebuddyAgent [candidate] (648.463 ms) : 0, 648463
GlobalTracer [baseline] (286.483 ms) : 0, 286483
GlobalTracer [candidate] (282.804 ms) : 0, 282804
AppSec [baseline] (32.806 ms) : 0, 32806
AppSec [candidate] (32.168 ms) : 0, 32168
Debugger [baseline] (69.105 ms) : 0, 69105
Debugger [candidate] (68.208 ms) : 0, 68208
Remote Config [baseline] (611.939 µs) : 0, 612
Remote Config [candidate] (592.37 µs) : 0, 592
Telemetry [baseline] (9.063 ms) : 0, 9063
Telemetry [candidate] (8.901 ms) : 0, 8901
Flare Poller [baseline] (3.742 ms) : 0, 3742
Flare Poller [candidate] (3.7 ms) : 0, 3700
section appsec
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (695.198 ms) : 0, 695198
BytebuddyAgent [candidate] (690.63 ms) : 0, 690630
GlobalTracer [baseline] (261.105 ms) : 0, 261105
GlobalTracer [candidate] (259.408 ms) : 0, 259408
AppSec [baseline] (174.731 ms) : 0, 174731
AppSec [candidate] (173.79 ms) : 0, 173790
Debugger [baseline] (66.832 ms) : 0, 66832
Debugger [candidate] (67.766 ms) : 0, 67766
Remote Config [baseline] (716.261 µs) : 0, 716
Remote Config [candidate] (709.075 µs) : 0, 709
Telemetry [baseline] (9.101 ms) : 0, 9101
Telemetry [candidate] (9.123 ms) : 0, 9123
Flare Poller [baseline] (3.907 ms) : 0, 3907
Flare Poller [candidate] (3.886 ms) : 0, 3886
IAST [baseline] (24.821 ms) : 0, 24821
IAST [candidate] (24.585 ms) : 0, 24585
section iast
crashtracking [baseline] (1.201 ms) : 0, 1201
crashtracking [candidate] (1.21 ms) : 0, 1210
BytebuddyAgent [baseline] (792.862 ms) : 0, 792862
BytebuddyAgent [candidate] (797.0 ms) : 0, 797000
GlobalTracer [baseline] (256.248 ms) : 0, 256248
GlobalTracer [candidate] (257.313 ms) : 0, 257313
AppSec [baseline] (31.993 ms) : 0, 31993
AppSec [candidate] (34.291 ms) : 0, 34291
Debugger [baseline] (69.089 ms) : 0, 69089
Debugger [candidate] (65.713 ms) : 0, 65713
Remote Config [baseline] (581.911 µs) : 0, 582
Remote Config [candidate] (550.199 µs) : 0, 550
Telemetry [baseline] (8.48 ms) : 0, 8480
Telemetry [candidate] (8.434 ms) : 0, 8434
Flare Poller [baseline] (3.568 ms) : 0, 3568
Flare Poller [candidate] (3.493 ms) : 0, 3493
IAST [baseline] (27.077 ms) : 0, 27077
IAST [candidate] (27.435 ms) : 0, 27435
section profiling
crashtracking [baseline] (1.233 ms) : 0, 1233
crashtracking [candidate] (1.219 ms) : 0, 1219
BytebuddyAgent [baseline] (703.479 ms) : 0, 703479
BytebuddyAgent [candidate] (702.489 ms) : 0, 702489
GlobalTracer [baseline] (220.957 ms) : 0, 220957
GlobalTracer [candidate] (220.901 ms) : 0, 220901
AppSec [baseline] (32.157 ms) : 0, 32157
AppSec [candidate] (32.051 ms) : 0, 32051
Debugger [baseline] (68.532 ms) : 0, 68532
Debugger [candidate] (68.301 ms) : 0, 68301
Remote Config [baseline] (665.381 µs) : 0, 665
Remote Config [candidate] (639.105 µs) : 0, 639
Telemetry [baseline] (8.873 ms) : 0, 8873
Telemetry [candidate] (8.858 ms) : 0, 8858
Flare Poller [baseline] (3.793 ms) : 0, 3793
Flare Poller [candidate] (3.767 ms) : 0, 3767
ProfilingAgent [baseline] (97.925 ms) : 0, 97925
ProfilingAgent [candidate] (97.357 ms) : 0, 97357
Profiling [baseline] (98.513 ms) : 0, 98513
Profiling [candidate] (97.938 ms) : 0, 97938
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 18 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~02de9b7ed9, baseline=1.58.0-SNAPSHOT~c2f3bfbd56
dateFormat X
axisFormat %s
section baseline
no_agent (1.189 ms) : 1178, 1200
. : milestone, 1189,
iast (3.265 ms) : 3223, 3307
. : milestone, 3265,
iast_FULL (5.754 ms) : 5696, 5811
. : milestone, 5754,
iast_GLOBAL (3.587 ms) : 3535, 3638
. : milestone, 3587,
profiling (1.919 ms) : 1903, 1935
. : milestone, 1919,
tracing (1.776 ms) : 1762, 1790
. : milestone, 1776,
section candidate
no_agent (1.178 ms) : 1166, 1189
. : milestone, 1178,
iast (3.155 ms) : 3117, 3192
. : milestone, 3155,
iast_FULL (5.687 ms) : 5630, 5743
. : milestone, 5687,
iast_GLOBAL (3.517 ms) : 3466, 3568
. : milestone, 3517,
profiling (2.034 ms) : 2016, 2051
. : milestone, 2034,
tracing (1.788 ms) : 1773, 1802
. : milestone, 1788,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~02de9b7ed9, baseline=1.58.0-SNAPSHOT~c2f3bfbd56
dateFormat X
axisFormat %s
section baseline
no_agent (17.055 ms) : 16885, 17226
. : milestone, 17055,
appsec (18.831 ms) : 18644, 19018
. : milestone, 18831,
code_origins (17.764 ms) : 17585, 17942
. : milestone, 17764,
iast (17.704 ms) : 17530, 17878
. : milestone, 17704,
profiling (18.692 ms) : 18506, 18878
. : milestone, 18692,
tracing (18.027 ms) : 17848, 18206
. : milestone, 18027,
section candidate
no_agent (17.92 ms) : 17739, 18101
. : milestone, 17920,
appsec (18.707 ms) : 18517, 18896
. : milestone, 18707,
code_origins (17.923 ms) : 17744, 18102
. : milestone, 17923,
iast (17.77 ms) : 17594, 17947
. : milestone, 17770,
profiling (19.846 ms) : 19641, 20052
. : milestone, 19846,
tracing (17.6 ms) : 17424, 17776
. : milestone, 17600,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~02de9b7ed9, baseline=1.58.0-SNAPSHOT~c2f3bfbd56
dateFormat X
axisFormat %s
section baseline
no_agent (15.003 s) : 15003000, 15003000
. : milestone, 15003000,
appsec (14.68 s) : 14680000, 14680000
. : milestone, 14680000,
iast (18.646 s) : 18646000, 18646000
. : milestone, 18646000,
iast_GLOBAL (17.841 s) : 17841000, 17841000
. : milestone, 17841000,
profiling (14.93 s) : 14930000, 14930000
. : milestone, 14930000,
tracing (14.678 s) : 14678000, 14678000
. : milestone, 14678000,
section candidate
no_agent (15.399 s) : 15399000, 15399000
. : milestone, 15399000,
appsec (14.744 s) : 14744000, 14744000
. : milestone, 14744000,
iast (18.355 s) : 18355000, 18355000
. : milestone, 18355000,
iast_GLOBAL (17.713 s) : 17713000, 17713000
. : milestone, 17713000,
profiling (14.911 s) : 14911000, 14911000
. : milestone, 14911000,
tracing (14.587 s) : 14587000, 14587000
. : milestone, 14587000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~02de9b7ed9, baseline=1.58.0-SNAPSHOT~c2f3bfbd56
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1457, 1480
. : milestone, 1469,
appsec (3.641 ms) : 3427, 3855
. : milestone, 3641,
iast (2.206 ms) : 2142, 2271
. : milestone, 2206,
iast_GLOBAL (2.245 ms) : 2180, 2310
. : milestone, 2245,
profiling (2.05 ms) : 1997, 2102
. : milestone, 2050,
tracing (2.038 ms) : 1987, 2089
. : milestone, 2038,
section candidate
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (3.69 ms) : 3470, 3909
. : milestone, 3690,
iast (2.198 ms) : 2134, 2263
. : milestone, 2198,
iast_GLOBAL (2.245 ms) : 2180, 2311
. : milestone, 2245,
profiling (2.058 ms) : 2005, 2111
. : milestone, 2058,
tracing (2.048 ms) : 1996, 2099
. : milestone, 2048,
|
What Does This Do
SpanDecorationProbe use also the CaptureContext instrumentation so need to implement the interface.
this fixes the class cast exception.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]