-
Notifications
You must be signed in to change notification settings - Fork 322
Avoid NPE when inspecting spring messaging headers #10254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bric3
approved these changes
Dec 19, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.58.0-SNAPSHOT~daa80d98af, baseline=1.58.0-SNAPSHOT~fbdb1cffac
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1080243
Total [baseline] (8.744 s) : 0, 8744078
Agent [candidate] (1.085 s) : 0, 1085153
Total [candidate] (8.769 s) : 0, 8769131
section iast
Agent [baseline] (1.219 s) : 0, 1219188
Total [baseline] (9.302 s) : 0, 9301883
Agent [candidate] (1.226 s) : 0, 1225686
Total [candidate] (9.325 s) : 0, 9325384
gantt
title insecure-bank - break down per module: candidate=1.58.0-SNAPSHOT~daa80d98af, baseline=1.58.0-SNAPSHOT~fbdb1cffac
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (648.947 ms) : 0, 648947
BytebuddyAgent [candidate] (652.042 ms) : 0, 652042
GlobalTracer [baseline] (282.328 ms) : 0, 282328
GlobalTracer [candidate] (283.549 ms) : 0, 283549
AppSec [baseline] (32.123 ms) : 0, 32123
AppSec [candidate] (32.413 ms) : 0, 32413
Debugger [baseline] (66.3 ms) : 0, 66300
Debugger [candidate] (67.104 ms) : 0, 67104
Remote Config [baseline] (602.504 µs) : 0, 603
Remote Config [candidate] (608.034 µs) : 0, 608
Telemetry [baseline] (8.857 ms) : 0, 8857
Telemetry [candidate] (8.968 ms) : 0, 8968
Flare Poller [baseline] (4.403 ms) : 0, 4403
Flare Poller [candidate] (3.72 ms) : 0, 3720
section iast
crashtracking [baseline] (1.204 ms) : 0, 1204
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (788.796 ms) : 0, 788796
BytebuddyAgent [candidate] (792.866 ms) : 0, 792866
GlobalTracer [baseline] (254.736 ms) : 0, 254736
GlobalTracer [candidate] (256.725 ms) : 0, 256725
AppSec [baseline] (35.038 ms) : 0, 35038
AppSec [candidate] (33.768 ms) : 0, 33768
Debugger [baseline] (64.359 ms) : 0, 64359
Debugger [candidate] (65.906 ms) : 0, 65906
Remote Config [baseline] (598.643 µs) : 0, 599
Remote Config [candidate] (610.902 µs) : 0, 611
Telemetry [baseline] (8.468 ms) : 0, 8468
Telemetry [candidate] (8.49 ms) : 0, 8490
Flare Poller [baseline] (3.557 ms) : 0, 3557
Flare Poller [candidate] (3.579 ms) : 0, 3579
IAST [baseline] (26.977 ms) : 0, 26977
IAST [candidate] (27.052 ms) : 0, 27052
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.58.0-SNAPSHOT~daa80d98af, baseline=1.58.0-SNAPSHOT~fbdb1cffac
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.091 s) : 0, 1091050
Total [baseline] (10.831 s) : 0, 10830698
Agent [candidate] (1.09 s) : 0, 1089938
Total [candidate] (10.894 s) : 0, 10894250
section appsec
Agent [baseline] (1.267 s) : 0, 1267282
Total [baseline] (10.953 s) : 0, 10952801
Agent [candidate] (1.281 s) : 0, 1281121
Total [candidate] (11.03 s) : 0, 11030205
section iast
Agent [baseline] (1.224 s) : 0, 1224190
Total [baseline] (11.105 s) : 0, 11104901
Agent [candidate] (1.223 s) : 0, 1223078
Total [candidate] (11.232 s) : 0, 11232424
section profiling
Agent [baseline] (1.206 s) : 0, 1205802
Total [baseline] (10.97 s) : 0, 10969640
Agent [candidate] (1.205 s) : 0, 1204516
Total [candidate] (10.871 s) : 0, 10870504
gantt
title petclinic - break down per module: candidate=1.58.0-SNAPSHOT~daa80d98af, baseline=1.58.0-SNAPSHOT~fbdb1cffac
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.205 ms) : 0, 1205
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (654.979 ms) : 0, 654979
BytebuddyAgent [candidate] (654.53 ms) : 0, 654530
GlobalTracer [baseline] (284.789 ms) : 0, 284789
GlobalTracer [candidate] (284.648 ms) : 0, 284648
AppSec [baseline] (32.616 ms) : 0, 32616
AppSec [candidate] (32.595 ms) : 0, 32595
Debugger [baseline] (68.439 ms) : 0, 68439
Debugger [candidate] (67.718 ms) : 0, 67718
Remote Config [baseline] (622.126 µs) : 0, 622
Remote Config [candidate] (615.965 µs) : 0, 616
Telemetry [baseline] (8.982 ms) : 0, 8982
Telemetry [candidate] (9.083 ms) : 0, 9083
Flare Poller [baseline] (3.731 ms) : 0, 3731
Flare Poller [candidate] (3.809 ms) : 0, 3809
section appsec
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.205 ms) : 0, 1205
BytebuddyAgent [baseline] (690.866 ms) : 0, 690866
BytebuddyAgent [candidate] (700.697 ms) : 0, 700697
GlobalTracer [baseline] (258.903 ms) : 0, 258903
GlobalTracer [candidate] (262.162 ms) : 0, 262162
AppSec [baseline] (173.636 ms) : 0, 173636
AppSec [candidate] (175.405 ms) : 0, 175405
Debugger [baseline] (69.093 ms) : 0, 69093
Debugger [candidate] (67.145 ms) : 0, 67145
Remote Config [baseline] (722.975 µs) : 0, 723
Remote Config [candidate] (716.175 µs) : 0, 716
Telemetry [baseline] (9.053 ms) : 0, 9053
Telemetry [candidate] (8.933 ms) : 0, 8933
Flare Poller [baseline] (3.805 ms) : 0, 3805
Flare Poller [candidate] (3.856 ms) : 0, 3856
IAST [baseline] (24.508 ms) : 0, 24508
IAST [candidate] (25.119 ms) : 0, 25119
section iast
crashtracking [baseline] (1.177 ms) : 0, 1177
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (791.676 ms) : 0, 791676
BytebuddyAgent [candidate] (790.586 ms) : 0, 790586
GlobalTracer [baseline] (255.681 ms) : 0, 255681
GlobalTracer [candidate] (255.767 ms) : 0, 255767
AppSec [baseline] (32.554 ms) : 0, 32554
AppSec [candidate] (34.55 ms) : 0, 34550
Debugger [baseline] (67.869 ms) : 0, 67869
Debugger [candidate] (65.9 ms) : 0, 65900
Remote Config [baseline] (612.069 µs) : 0, 612
Remote Config [candidate] (624.542 µs) : 0, 625
Telemetry [baseline] (8.521 ms) : 0, 8521
Telemetry [candidate] (8.473 ms) : 0, 8473
Flare Poller [baseline] (3.531 ms) : 0, 3531
Flare Poller [candidate] (3.501 ms) : 0, 3501
IAST [baseline] (27.122 ms) : 0, 27122
IAST [candidate] (27.046 ms) : 0, 27046
section profiling
crashtracking [baseline] (1.22 ms) : 0, 1220
crashtracking [candidate] (1.215 ms) : 0, 1215
BytebuddyAgent [baseline] (703.594 ms) : 0, 703594
BytebuddyAgent [candidate] (702.606 ms) : 0, 702606
GlobalTracer [baseline] (220.703 ms) : 0, 220703
GlobalTracer [candidate] (220.761 ms) : 0, 220761
AppSec [baseline] (32.084 ms) : 0, 32084
AppSec [candidate] (32.068 ms) : 0, 32068
Debugger [baseline] (68.108 ms) : 0, 68108
Debugger [candidate] (68.158 ms) : 0, 68158
Remote Config [baseline] (640.45 µs) : 0, 640
Remote Config [candidate] (627.527 µs) : 0, 628
Telemetry [baseline] (8.879 ms) : 0, 8879
Telemetry [candidate] (8.701 ms) : 0, 8701
Flare Poller [baseline] (3.748 ms) : 0, 3748
Flare Poller [candidate] (3.643 ms) : 0, 3643
ProfilingAgent [baseline] (97.0 ms) : 0, 97000
ProfilingAgent [candidate] (96.882 ms) : 0, 96882
Profiling [baseline] (97.578 ms) : 0, 97578
Profiling [candidate] (97.458 ms) : 0, 97458
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 19 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~daa80d98af, baseline=1.58.0-SNAPSHOT~fbdb1cffac
dateFormat X
axisFormat %s
section baseline
no_agent (19.089 ms) : 18892, 19285
. : milestone, 19089,
appsec (18.337 ms) : 18150, 18523
. : milestone, 18337,
code_origins (17.685 ms) : 17508, 17862
. : milestone, 17685,
iast (17.901 ms) : 17723, 18079
. : milestone, 17901,
profiling (18.943 ms) : 18756, 19129
. : milestone, 18943,
tracing (17.753 ms) : 17579, 17927
. : milestone, 17753,
section candidate
no_agent (18.034 ms) : 17851, 18217
. : milestone, 18034,
appsec (18.642 ms) : 18452, 18831
. : milestone, 18642,
code_origins (17.831 ms) : 17654, 18009
. : milestone, 17831,
iast (17.609 ms) : 17436, 17783
. : milestone, 17609,
profiling (18.616 ms) : 18428, 18805
. : milestone, 18616,
tracing (17.838 ms) : 17661, 18016
. : milestone, 17838,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~daa80d98af, baseline=1.58.0-SNAPSHOT~fbdb1cffac
dateFormat X
axisFormat %s
section baseline
no_agent (1.203 ms) : 1191, 1215
. : milestone, 1203,
iast (3.31 ms) : 3266, 3354
. : milestone, 3310,
iast_FULL (5.89 ms) : 5831, 5949
. : milestone, 5890,
iast_GLOBAL (3.62 ms) : 3564, 3677
. : milestone, 3620,
profiling (1.924 ms) : 1908, 1941
. : milestone, 1924,
tracing (1.854 ms) : 1838, 1870
. : milestone, 1854,
section candidate
no_agent (1.179 ms) : 1167, 1190
. : milestone, 1179,
iast (3.276 ms) : 3238, 3315
. : milestone, 3276,
iast_FULL (5.742 ms) : 5685, 5800
. : milestone, 5742,
iast_GLOBAL (3.726 ms) : 3676, 3775
. : milestone, 3726,
profiling (2.022 ms) : 2001, 2043
. : milestone, 2022,
tracing (1.773 ms) : 1759, 1788
. : milestone, 1773,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~daa80d98af, baseline=1.58.0-SNAPSHOT~fbdb1cffac
dateFormat X
axisFormat %s
section baseline
no_agent (14.895 s) : 14895000, 14895000
. : milestone, 14895000,
appsec (14.882 s) : 14882000, 14882000
. : milestone, 14882000,
iast (18.361 s) : 18361000, 18361000
. : milestone, 18361000,
iast_GLOBAL (18.053 s) : 18053000, 18053000
. : milestone, 18053000,
profiling (14.972 s) : 14972000, 14972000
. : milestone, 14972000,
tracing (14.846 s) : 14846000, 14846000
. : milestone, 14846000,
section candidate
no_agent (15.533 s) : 15533000, 15533000
. : milestone, 15533000,
appsec (14.695 s) : 14695000, 14695000
. : milestone, 14695000,
iast (18.449 s) : 18449000, 18449000
. : milestone, 18449000,
iast_GLOBAL (17.751 s) : 17751000, 17751000
. : milestone, 17751000,
profiling (15.02 s) : 15020000, 15020000
. : milestone, 15020000,
tracing (14.841 s) : 14841000, 14841000
. : milestone, 14841000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~daa80d98af, baseline=1.58.0-SNAPSHOT~fbdb1cffac
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (3.753 ms) : 3533, 3973
. : milestone, 3753,
iast (2.231 ms) : 2166, 2295
. : milestone, 2231,
iast_GLOBAL (2.271 ms) : 2205, 2337
. : milestone, 2271,
profiling (2.5 ms) : 2337, 2664
. : milestone, 2500,
tracing (2.063 ms) : 2011, 2114
. : milestone, 2063,
section candidate
no_agent (1.48 ms) : 1469, 1492
. : milestone, 1480,
appsec (3.738 ms) : 3519, 3958
. : milestone, 3738,
iast (2.232 ms) : 2167, 2297
. : milestone, 2232,
iast_GLOBAL (2.267 ms) : 2202, 2332
. : milestone, 2267,
profiling (2.082 ms) : 2029, 2135
. : milestone, 2082,
tracing (2.067 ms) : 2016, 2118
. : milestone, 2067,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
inst: spring
Spring instrumentation
tag: telemetry error reported
Reported by error telemetry
type: bug
Bug report and fix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Solves:
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]