-
Notifications
You must be signed in to change notification settings - Fork 322
Handle hidden files, for example: .DS_Store.
#10260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.58.0-SNAPSHOT~b46b4d070d, baseline=1.58.0-SNAPSHOT~13c16342ac
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1081062
Total [baseline] (8.743 s) : 0, 8743252
Agent [candidate] (1.085 s) : 0, 1084980
Total [candidate] (8.74 s) : 0, 8740360
section iast
Agent [baseline] (1.224 s) : 0, 1224105
Total [baseline] (9.328 s) : 0, 9328063
Agent [candidate] (1.23 s) : 0, 1229915
Total [candidate] (9.324 s) : 0, 9324150
gantt
title insecure-bank - break down per module: candidate=1.58.0-SNAPSHOT~b46b4d070d, baseline=1.58.0-SNAPSHOT~13c16342ac
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (650.302 ms) : 0, 650302
BytebuddyAgent [candidate] (652.312 ms) : 0, 652312
GlobalTracer [baseline] (281.189 ms) : 0, 281189
GlobalTracer [candidate] (282.542 ms) : 0, 282542
AppSec [baseline] (32.417 ms) : 0, 32417
AppSec [candidate] (32.608 ms) : 0, 32608
Debugger [baseline] (67.088 ms) : 0, 67088
Debugger [candidate] (67.439 ms) : 0, 67439
Remote Config [baseline] (612.932 µs) : 0, 613
Remote Config [candidate] (599.268 µs) : 0, 599
Telemetry [baseline] (8.957 ms) : 0, 8957
Telemetry [candidate] (8.988 ms) : 0, 8988
Flare Poller [baseline] (3.717 ms) : 0, 3717
Flare Poller [candidate] (3.751 ms) : 0, 3751
section iast
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.212 ms) : 0, 1212
BytebuddyAgent [baseline] (792.788 ms) : 0, 792788
BytebuddyAgent [candidate] (796.533 ms) : 0, 796533
GlobalTracer [baseline] (255.285 ms) : 0, 255285
GlobalTracer [candidate] (256.453 ms) : 0, 256453
AppSec [baseline] (33.61 ms) : 0, 33610
AppSec [candidate] (35.654 ms) : 0, 35654
Debugger [baseline] (65.934 ms) : 0, 65934
Debugger [candidate] (64.548 ms) : 0, 64548
Remote Config [baseline] (561.614 µs) : 0, 562
Remote Config [candidate] (607.719 µs) : 0, 608
Telemetry [baseline] (8.489 ms) : 0, 8489
Telemetry [candidate] (8.596 ms) : 0, 8596
Flare Poller [baseline] (3.541 ms) : 0, 3541
Flare Poller [candidate] (3.507 ms) : 0, 3507
IAST [baseline] (27.219 ms) : 0, 27219
IAST [candidate] (27.165 ms) : 0, 27165
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.58.0-SNAPSHOT~b46b4d070d, baseline=1.58.0-SNAPSHOT~13c16342ac
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.083 s) : 0, 1083314
Total [baseline] (10.866 s) : 0, 10866338
Agent [candidate] (1.09 s) : 0, 1089551
Total [candidate] (11.038 s) : 0, 11037832
section appsec
Agent [baseline] (1.276 s) : 0, 1275575
Total [baseline] (10.941 s) : 0, 10941154
Agent [candidate] (1.268 s) : 0, 1267717
Total [candidate] (10.905 s) : 0, 10904888
section iast
Agent [baseline] (1.238 s) : 0, 1238430
Total [baseline] (11.209 s) : 0, 11208705
Agent [candidate] (1.233 s) : 0, 1233194
Total [candidate] (11.343 s) : 0, 11343109
section profiling
Agent [baseline] (1.215 s) : 0, 1214781
Total [baseline] (10.953 s) : 0, 10952790
Agent [candidate] (1.206 s) : 0, 1205532
Total [candidate] (10.965 s) : 0, 10964958
gantt
title petclinic - break down per module: candidate=1.58.0-SNAPSHOT~b46b4d070d, baseline=1.58.0-SNAPSHOT~13c16342ac
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.202 ms) : 0, 1202
BytebuddyAgent [baseline] (651.002 ms) : 0, 651002
BytebuddyAgent [candidate] (653.463 ms) : 0, 653463
GlobalTracer [baseline] (282.125 ms) : 0, 282125
GlobalTracer [candidate] (284.41 ms) : 0, 284410
AppSec [baseline] (32.525 ms) : 0, 32525
AppSec [candidate] (32.734 ms) : 0, 32734
Debugger [baseline] (67.554 ms) : 0, 67554
Debugger [candidate] (68.634 ms) : 0, 68634
Remote Config [baseline] (610.725 µs) : 0, 611
Remote Config [candidate] (606.667 µs) : 0, 607
Telemetry [baseline] (8.988 ms) : 0, 8988
Telemetry [candidate] (9.023 ms) : 0, 9023
Flare Poller [baseline] (3.7 ms) : 0, 3700
Flare Poller [candidate] (3.854 ms) : 0, 3854
section appsec
crashtracking [baseline] (1.222 ms) : 0, 1222
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (698.444 ms) : 0, 698444
BytebuddyAgent [candidate] (692.854 ms) : 0, 692854
GlobalTracer [baseline] (259.83 ms) : 0, 259830
GlobalTracer [candidate] (258.291 ms) : 0, 258291
AppSec [baseline] (174.611 ms) : 0, 174611
AppSec [candidate] (172.467 ms) : 0, 172467
Debugger [baseline] (67.582 ms) : 0, 67582
Debugger [candidate] (68.986 ms) : 0, 68986
Remote Config [baseline] (748.446 µs) : 0, 748
Remote Config [candidate] (780.572 µs) : 0, 781
Telemetry [baseline] (9.212 ms) : 0, 9212
Telemetry [candidate] (9.336 ms) : 0, 9336
Flare Poller [baseline] (3.563 ms) : 0, 3563
Flare Poller [candidate] (3.631 ms) : 0, 3631
IAST [baseline] (24.738 ms) : 0, 24738
IAST [candidate] (24.699 ms) : 0, 24699
section iast
crashtracking [baseline] (1.201 ms) : 0, 1201
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (801.508 ms) : 0, 801508
BytebuddyAgent [candidate] (798.61 ms) : 0, 798610
GlobalTracer [baseline] (258.365 ms) : 0, 258365
GlobalTracer [candidate] (257.443 ms) : 0, 257443
AppSec [baseline] (34.029 ms) : 0, 34029
AppSec [candidate] (35.398 ms) : 0, 35398
Debugger [baseline] (67.186 ms) : 0, 67186
Debugger [candidate] (65.058 ms) : 0, 65058
Remote Config [baseline] (580.639 µs) : 0, 581
Remote Config [candidate] (543.138 µs) : 0, 543
Telemetry [baseline] (8.611 ms) : 0, 8611
Telemetry [candidate] (8.461 ms) : 0, 8461
Flare Poller [baseline] (3.555 ms) : 0, 3555
Flare Poller [candidate] (3.49 ms) : 0, 3490
IAST [baseline] (27.687 ms) : 0, 27687
IAST [candidate] (27.358 ms) : 0, 27358
section profiling
crashtracking [baseline] (1.22 ms) : 0, 1220
crashtracking [candidate] (1.215 ms) : 0, 1215
BytebuddyAgent [baseline] (709.254 ms) : 0, 709254
BytebuddyAgent [candidate] (703.59 ms) : 0, 703590
GlobalTracer [baseline] (221.674 ms) : 0, 221674
GlobalTracer [candidate] (220.362 ms) : 0, 220362
AppSec [baseline] (32.517 ms) : 0, 32517
AppSec [candidate] (32.079 ms) : 0, 32079
Debugger [baseline] (68.685 ms) : 0, 68685
Debugger [candidate] (68.263 ms) : 0, 68263
Remote Config [baseline] (645.276 µs) : 0, 645
Remote Config [candidate] (600.216 µs) : 0, 600
Telemetry [baseline] (8.9 ms) : 0, 8900
Telemetry [candidate] (8.846 ms) : 0, 8846
Flare Poller [baseline] (3.703 ms) : 0, 3703
Flare Poller [candidate] (3.737 ms) : 0, 3737
ProfilingAgent [baseline] (97.785 ms) : 0, 97785
ProfilingAgent [candidate] (96.999 ms) : 0, 96999
Profiling [baseline] (98.367 ms) : 0, 98367
Profiling [candidate] (97.57 ms) : 0, 97570
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 3 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~b46b4d070d, baseline=1.58.0-SNAPSHOT~13c16342ac
dateFormat X
axisFormat %s
section baseline
no_agent (1.196 ms) : 1184, 1208
. : milestone, 1196,
iast (3.232 ms) : 3192, 3271
. : milestone, 3232,
iast_FULL (6.22 ms) : 6156, 6284
. : milestone, 6220,
iast_GLOBAL (3.632 ms) : 3575, 3690
. : milestone, 3632,
profiling (1.924 ms) : 1908, 1939
. : milestone, 1924,
tracing (1.824 ms) : 1808, 1839
. : milestone, 1824,
section candidate
no_agent (1.201 ms) : 1188, 1213
. : milestone, 1201,
iast (3.283 ms) : 3242, 3324
. : milestone, 3283,
iast_FULL (5.67 ms) : 5614, 5726
. : milestone, 5670,
iast_GLOBAL (3.626 ms) : 3572, 3680
. : milestone, 3626,
profiling (1.972 ms) : 1954, 1989
. : milestone, 1972,
tracing (1.841 ms) : 1825, 1857
. : milestone, 1841,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~b46b4d070d, baseline=1.58.0-SNAPSHOT~13c16342ac
dateFormat X
axisFormat %s
section baseline
no_agent (17.311 ms) : 17143, 17479
. : milestone, 17311,
appsec (18.281 ms) : 18096, 18466
. : milestone, 18281,
code_origins (17.9 ms) : 17723, 18077
. : milestone, 17900,
iast (18.656 ms) : 18469, 18843
. : milestone, 18656,
profiling (18.536 ms) : 18351, 18721
. : milestone, 18536,
tracing (17.802 ms) : 17627, 17977
. : milestone, 17802,
section candidate
no_agent (18.186 ms) : 18001, 18372
. : milestone, 18186,
appsec (18.766 ms) : 18575, 18956
. : milestone, 18766,
code_origins (18.65 ms) : 18457, 18843
. : milestone, 18650,
iast (17.578 ms) : 17402, 17753
. : milestone, 17578,
profiling (18.61 ms) : 18426, 18793
. : milestone, 18610,
tracing (17.699 ms) : 17523, 17875
. : milestone, 17699,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~b46b4d070d, baseline=1.58.0-SNAPSHOT~13c16342ac
dateFormat X
axisFormat %s
section baseline
no_agent (14.824 s) : 14824000, 14824000
. : milestone, 14824000,
appsec (14.57 s) : 14570000, 14570000
. : milestone, 14570000,
iast (18.448 s) : 18448000, 18448000
. : milestone, 18448000,
iast_GLOBAL (18.285 s) : 18285000, 18285000
. : milestone, 18285000,
profiling (14.742 s) : 14742000, 14742000
. : milestone, 14742000,
tracing (14.715 s) : 14715000, 14715000
. : milestone, 14715000,
section candidate
no_agent (15.655 s) : 15655000, 15655000
. : milestone, 15655000,
appsec (14.659 s) : 14659000, 14659000
. : milestone, 14659000,
iast (18.528 s) : 18528000, 18528000
. : milestone, 18528000,
iast_GLOBAL (17.801 s) : 17801000, 17801000
. : milestone, 17801000,
profiling (14.698 s) : 14698000, 14698000
. : milestone, 14698000,
tracing (14.496 s) : 14496000, 14496000
. : milestone, 14496000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~b46b4d070d, baseline=1.58.0-SNAPSHOT~13c16342ac
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (2.451 ms) : 2399, 2503
. : milestone, 2451,
iast (2.222 ms) : 2157, 2287
. : milestone, 2222,
iast_GLOBAL (2.252 ms) : 2187, 2317
. : milestone, 2252,
profiling (2.067 ms) : 2015, 2120
. : milestone, 2067,
tracing (2.051 ms) : 2000, 2103
. : milestone, 2051,
section candidate
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (3.724 ms) : 3505, 3943
. : milestone, 3724,
iast (2.21 ms) : 2145, 2274
. : milestone, 2210,
iast_GLOBAL (2.256 ms) : 2191, 2321
. : milestone, 2256,
profiling (2.081 ms) : 2027, 2135
. : milestone, 2081,
tracing (2.05 ms) : 1999, 2101
. : milestone, 2050,
|
|
👏 praise: Good catch. I don't use the MacOS file explorer so I did not encounter the issue. Thanks for the improvement |
What Does This Do
Improves cleanup script.
Motivation
I found that script sometimes keeps folders that obviously should be deleted.
After investigation I found that hidden
.DS_Storeprevented cleanup.