Skip to content

Refactor multiple implementations of W3C trace context building into a dedicated helper #10261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
na-ji merged 7 commits into from
Dec 23, 2025
Merged

Refactor multiple implementations of W3C trace context building into a dedicated helper #10261

na-ji merged 7 commits into from
Dec 23, 2025

Conversation

@na-ji
Copy link
Member

@na-ji na-ji commented Dec 19, 2025

Motivation

In #9589, a comment was made that we already implemented three times a way to build a W3C compliant trace parent. To make things simple, we decided to refactor those implementations into a single helper.

What Does This Do

  • Created a new helper class datadog.trace.api.W3CTraceParent to build this trace parent. I'm not 100% sure it's the right package to put it, I hesitated with datadog.trace.core.propagation
  • Replaced implementations in:
    • MongoCommentInjector
    • JDBCDecorator
    • W3CHttpCodec

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@na-ji na-ji self-assigned this Dec 19, 2025
@na-ji na-ji added comp: core Tracer core type: refactoring inst: jdbc JDBC instrumentation comp: api Tracer public API inst: mongodb MongoDB instrumentation labels Dec 19, 2025
@na-ji na-ji force-pushed the naji.astier/refactor-trace-parent-building branch from 287ce40 to 0dc5a8c Compare December 19, 2025 17:11
@na-ji na-ji marked this pull request as ready for review December 19, 2025 17:12
@na-ji na-ji requested review from a team as code owners December 19, 2025 17:12
@na-ji na-ji requested review from PerfectSlayer and cecile75 and removed request for a team December 19, 2025 17:12
mhlidd
mhlidd approved these changes Dec 19, 2025
View reviewed changes
Copy link
Contributor

@mhlidd mhlidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ IMO this class makes more sense to belong in dd-trace-core/src/main/java/datadog/trace/core/util since it's a helper only meant to be used internally and not by customers.

Thanks for the refactor! Looks great!

PerfectSlayer
PerfectSlayer reviewed Dec 19, 2025
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 thought: ‏I will have a proper review later but I don’t think the public API is the right package.

@pr-commenter
Copy link

pr-commenter bot commented Dec 19, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master naji.astier/refactor-trace-parent-building
git_commit_date 1766160938 1766415524
git_commit_sha 13c1634 625a498
release_version 1.58.0-SNAPSHOT~13c16342ac 1.58.0-SNAPSHOT~625a4988c6
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1766417438 1766417438
ci_job_id 1313612184 1313612184
ci_pipeline_id 88049188 88049188
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-rbpofgij 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-rbpofgij 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.58.0-SNAPSHOT~625a4988c6, baseline=1.58.0-SNAPSHOT~13c16342ac

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.101 s) : 0, 1100749
Total [baseline] (10.829 s) : 0, 10828632
Agent [candidate] (1.093 s) : 0, 1093493
Total [candidate] (10.977 s) : 0, 10977443
section appsec
Agent [baseline] (1.275 s) : 0, 1274792
Total [baseline] (10.884 s) : 0, 10884246
Agent [candidate] (1.266 s) : 0, 1266244
Total [candidate] (11.016 s) : 0, 11015595
section iast
Agent [baseline] (1.223 s) : 0, 1222799
Total [baseline] (11.124 s) : 0, 11123974
Agent [candidate] (1.234 s) : 0, 1234002
Total [candidate] (11.188 s) : 0, 11188106
section profiling
Agent [baseline] (1.206 s) : 0, 1206172
Total [baseline] (10.88 s) : 0, 10880094
Agent [candidate] (1.205 s) : 0, 1205309
Total [candidate] (10.865 s) : 0, 10864698
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.101 s -
Agent appsec 1.275 s 174.043 ms (15.8%)
Agent iast 1.223 s 122.05 ms (11.1%)
Agent profiling 1.206 s 105.423 ms (9.6%)
Total tracing 10.829 s -
Total appsec 10.884 s 55.615 ms (0.5%)
Total iast 11.124 s 295.342 ms (2.7%)
Total profiling 10.88 s 51.463 ms (0.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.093 s -
Agent appsec 1.266 s 172.751 ms (15.8%)
Agent iast 1.234 s 140.509 ms (12.8%)
Agent profiling 1.205 s 111.816 ms (10.2%)
Total tracing 10.977 s -
Total appsec 11.016 s 38.152 ms (0.3%)
Total iast 11.188 s 210.663 ms (1.9%)
Total profiling 10.865 s -112.745 ms (-1.0%) 
gantt
    title petclinic - break down per module: candidate=1.58.0-SNAPSHOT~625a4988c6, baseline=1.58.0-SNAPSHOT~13c16342ac

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.213 ms) : 0, 1213
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (661.493 ms) : 0, 661493
BytebuddyAgent [candidate] (656.751 ms) : 0, 656751
GlobalTracer [baseline] (286.554 ms) : 0, 286554
GlobalTracer [candidate] (284.613 ms) : 0, 284613
AppSec [baseline] (33.091 ms) : 0, 33091
AppSec [candidate] (33.204 ms) : 0, 33204
Debugger [baseline] (69.185 ms) : 0, 69185
Debugger [candidate] (68.555 ms) : 0, 68555
Remote Config [baseline] (617.924 µs) : 0, 618
Remote Config [candidate] (623.201 µs) : 0, 623
Telemetry [baseline] (9.033 ms) : 0, 9033
Telemetry [candidate] (9.149 ms) : 0, 9149
Flare Poller [baseline] (3.798 ms) : 0, 3798
Flare Poller [candidate] (3.829 ms) : 0, 3829
section appsec
crashtracking [baseline] (1.225 ms) : 0, 1225
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (697.44 ms) : 0, 697440
BytebuddyAgent [candidate] (691.378 ms) : 0, 691378
GlobalTracer [baseline] (259.455 ms) : 0, 259455
GlobalTracer [candidate] (257.853 ms) : 0, 257853
AppSec [baseline] (174.848 ms) : 0, 174848
AppSec [candidate] (174.746 ms) : 0, 174746
Debugger [baseline] (67.543 ms) : 0, 67543
Debugger [candidate] (67.318 ms) : 0, 67318
Remote Config [baseline] (782.815 µs) : 0, 783
Remote Config [candidate] (773.51 µs) : 0, 774
Telemetry [baseline] (9.425 ms) : 0, 9425
Telemetry [candidate] (9.395 ms) : 0, 9395
Flare Poller [baseline] (3.681 ms) : 0, 3681
Flare Poller [candidate] (3.697 ms) : 0, 3697
IAST [baseline] (24.908 ms) : 0, 24908
IAST [candidate] (24.643 ms) : 0, 24643
section iast
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (791.828 ms) : 0, 791828
BytebuddyAgent [candidate] (798.995 ms) : 0, 798995
GlobalTracer [baseline] (254.914 ms) : 0, 254914
GlobalTracer [candidate] (257.646 ms) : 0, 257646
AppSec [baseline] (35.016 ms) : 0, 35016
AppSec [candidate] (32.749 ms) : 0, 32749
Debugger [baseline] (64.659 ms) : 0, 64659
Debugger [candidate] (67.727 ms) : 0, 67727
Remote Config [baseline] (589.952 µs) : 0, 590
Remote Config [candidate] (599.53 µs) : 0, 600
Telemetry [baseline] (8.493 ms) : 0, 8493
Telemetry [candidate] (8.551 ms) : 0, 8551
Flare Poller [baseline] (3.461 ms) : 0, 3461
Flare Poller [candidate] (3.512 ms) : 0, 3512
IAST [baseline] (27.252 ms) : 0, 27252
IAST [candidate] (27.449 ms) : 0, 27449
section profiling
crashtracking [baseline] (1.217 ms) : 0, 1217
crashtracking [candidate] (1.21 ms) : 0, 1210
BytebuddyAgent [baseline] (704.916 ms) : 0, 704916
BytebuddyAgent [candidate] (704.43 ms) : 0, 704430
GlobalTracer [baseline] (220.186 ms) : 0, 220186
GlobalTracer [candidate] (220.181 ms) : 0, 220181
AppSec [baseline] (32.125 ms) : 0, 32125
AppSec [candidate] (32.102 ms) : 0, 32102
Debugger [baseline] (67.763 ms) : 0, 67763
Debugger [candidate] (67.952 ms) : 0, 67952
Remote Config [baseline] (655.298 µs) : 0, 655
Remote Config [candidate] (623.666 µs) : 0, 624
Telemetry [baseline] (8.693 ms) : 0, 8693
Telemetry [candidate] (8.663 ms) : 0, 8663
Flare Poller [baseline] (3.679 ms) : 0, 3679
Flare Poller [candidate] (3.671 ms) : 0, 3671
ProfilingAgent [baseline] (97.18 ms) : 0, 97180
ProfilingAgent [candidate] (96.645 ms) : 0, 96645
Profiling [baseline] (97.756 ms) : 0, 97756
Profiling [candidate] (97.217 ms) : 0, 97217
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.58.0-SNAPSHOT~625a4988c6, baseline=1.58.0-SNAPSHOT~13c16342ac

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.091 s) : 0, 1091306
Total [baseline] (8.807 s) : 0, 8806507
Agent [candidate] (1.086 s) : 0, 1086473
Total [candidate] (8.779 s) : 0, 8779096
section iast
Agent [baseline] (1.222 s) : 0, 1221874
Total [baseline] (9.313 s) : 0, 9312789
Agent [candidate] (1.223 s) : 0, 1223080
Total [candidate] (9.376 s) : 0, 9376424
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.091 s -
Agent iast 1.222 s 130.568 ms (12.0%)
Total tracing 8.807 s -
Total iast 9.313 s 506.282 ms (5.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.086 s -
Agent iast 1.223 s 136.607 ms (12.6%)
Total tracing 8.779 s -
Total iast 9.376 s 597.328 ms (6.8%) 
gantt
    title insecure-bank - break down per module: candidate=1.58.0-SNAPSHOT~625a4988c6, baseline=1.58.0-SNAPSHOT~13c16342ac

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.202 ms) : 0, 1202
crashtracking [candidate] (1.199 ms) : 0, 1199
BytebuddyAgent [baseline] (656.521 ms) : 0, 656521
BytebuddyAgent [candidate] (654.007 ms) : 0, 654007
GlobalTracer [baseline] (283.77 ms) : 0, 283770
GlobalTracer [candidate] (282.85 ms) : 0, 282850
AppSec [baseline] (32.997 ms) : 0, 32997
AppSec [candidate] (32.661 ms) : 0, 32661
Debugger [baseline] (67.656 ms) : 0, 67656
Debugger [candidate] (67.02 ms) : 0, 67020
Remote Config [baseline] (614.916 µs) : 0, 615
Remote Config [candidate] (639.321 µs) : 0, 639
Telemetry [baseline] (9.157 ms) : 0, 9157
Telemetry [candidate] (8.92 ms) : 0, 8920
Flare Poller [baseline] (3.764 ms) : 0, 3764
Flare Poller [candidate] (3.708 ms) : 0, 3708
section iast
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (790.996 ms) : 0, 790996
BytebuddyAgent [candidate] (791.584 ms) : 0, 791584
GlobalTracer [baseline] (254.673 ms) : 0, 254673
GlobalTracer [candidate] (255.478 ms) : 0, 255478
AppSec [baseline] (34.51 ms) : 0, 34510
AppSec [candidate] (33.697 ms) : 0, 33697
Debugger [baseline] (65.276 ms) : 0, 65276
Debugger [candidate] (65.797 ms) : 0, 65797
Remote Config [baseline] (605.462 µs) : 0, 605
Remote Config [candidate] (624.594 µs) : 0, 625
Telemetry [baseline] (8.557 ms) : 0, 8557
Telemetry [candidate] (8.632 ms) : 0, 8632
Flare Poller [baseline] (3.533 ms) : 0, 3533
Flare Poller [candidate] (3.635 ms) : 0, 3635
IAST [baseline] (27.155 ms) : 0, 27155
IAST [candidate] (27.065 ms) : 0, 27065
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master naji.astier/refactor-trace-parent-building
git_commit_date 1766160938 1766415524
git_commit_sha 13c1634 625a498
release_version 1.58.0-SNAPSHOT~13c16342ac 1.58.0-SNAPSHOT~625a4988c6
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1766417930 1766417930
ci_job_id 1313612185 1313612185
ci_pipeline_id 88049188 88049188
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-7zzeoic6 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-7zzeoic6 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 18 metrics, 17 unstable metrics.

scenario Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p95 Δ mean throughput candidate mean agg_http_req_duration_p50 candidate mean agg_http_req_duration_p95 candidate mean throughput baseline mean agg_http_req_duration_p50 baseline mean agg_http_req_duration_p95 baseline mean throughput
scenario:load:insecure-bank:profiling:high_load worse
[+36.908µs; +180.055µs] or [+2.319%; +11.314%]		 unstable
[+18.306µs; +962.677µs] or [+0.410%; +21.556%]		 unstable
[-423.324op/s; +136.636op/s] or [-18.287%; +5.903%]		 1.700ms 4.956ms 2171.531op/s 1.591ms 4.466ms 2314.875op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~625a4988c6, baseline=1.58.0-SNAPSHOT~13c16342ac
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.194 ms) : 1182, 1205
.   : milestone, 1194,
iast (3.182 ms) : 3140, 3224
.   : milestone, 3182,
iast_FULL (5.799 ms) : 5741, 5856
.   : milestone, 5799,
iast_GLOBAL (3.457 ms) : 3407, 3506
.   : milestone, 3457,
profiling (1.948 ms) : 1932, 1964
.   : milestone, 1948,
tracing (1.82 ms) : 1803, 1837
.   : milestone, 1820,
section candidate
no_agent (1.189 ms) : 1178, 1201
.   : milestone, 1189,
iast (3.301 ms) : 3259, 3344
.   : milestone, 3301,
iast_FULL (5.858 ms) : 5800, 5916
.   : milestone, 5858,
iast_GLOBAL (3.534 ms) : 3475, 3593
.   : milestone, 3534,
profiling (2.08 ms) : 2062, 2099
.   : milestone, 2080,
tracing (1.794 ms) : 1779, 1809
.   : milestone, 1794,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.194 ms [1.182 ms, 1.205 ms] -
iast 3.182 ms [3.14 ms, 3.224 ms] 1.988 ms (166.6%)
iast_FULL 5.799 ms [5.741 ms, 5.856 ms] 4.605 ms (385.8%)
iast_GLOBAL 3.457 ms [3.407 ms, 3.506 ms] 2.263 ms (189.6%)
profiling 1.948 ms [1.932 ms, 1.964 ms] 754.452 µs (63.2%)
tracing 1.82 ms [1.803 ms, 1.837 ms] 626.236 µs (52.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.189 ms [1.178 ms, 1.201 ms] -
iast 3.301 ms [3.259 ms, 3.344 ms] 2.112 ms (177.5%)
iast_FULL 5.858 ms [5.8 ms, 5.916 ms] 4.668 ms (392.5%)
iast_GLOBAL 3.534 ms [3.475 ms, 3.593 ms] 2.345 ms (197.1%)
profiling 2.08 ms [2.062 ms, 2.099 ms] 890.983 µs (74.9%)
tracing 1.794 ms [1.779 ms, 1.809 ms] 604.458 µs (50.8%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~625a4988c6, baseline=1.58.0-SNAPSHOT~13c16342ac
    dateFormat X
    axisFormat %s
section baseline
no_agent (18.253 ms) : 18062, 18444
.   : milestone, 18253,
appsec (18.698 ms) : 18505, 18890
.   : milestone, 18698,
code_origins (17.85 ms) : 17670, 18031
.   : milestone, 17850,
iast (17.672 ms) : 17497, 17847
.   : milestone, 17672,
profiling (18.983 ms) : 18794, 19173
.   : milestone, 18983,
tracing (18.042 ms) : 17864, 18220
.   : milestone, 18042,
section candidate
no_agent (19.351 ms) : 19148, 19553
.   : milestone, 19351,
appsec (18.703 ms) : 18511, 18894
.   : milestone, 18703,
code_origins (17.875 ms) : 17696, 18053
.   : milestone, 17875,
iast (17.895 ms) : 17713, 18076
.   : milestone, 17895,
profiling (18.699 ms) : 18513, 18885
.   : milestone, 18699,
tracing (17.739 ms) : 17564, 17914
.   : milestone, 17739,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 18.253 ms [18.062 ms, 18.444 ms] -
appsec 18.698 ms [18.505 ms, 18.89 ms] 444.737 µs (2.4%)
code_origins 17.85 ms [17.67 ms, 18.031 ms] -402.661 µs (-2.2%)
iast 17.672 ms [17.497 ms, 17.847 ms] -580.917 µs (-3.2%)
profiling 18.983 ms [18.794 ms, 19.173 ms] 730.258 µs (4.0%)
tracing 18.042 ms [17.864 ms, 18.22 ms] -210.618 µs (-1.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 19.351 ms [19.148 ms, 19.553 ms] -
appsec 18.703 ms [18.511 ms, 18.894 ms] -647.995 µs (-3.3%)
code_origins 17.875 ms [17.696 ms, 18.053 ms] -1.476 ms (-7.6%)
iast 17.895 ms [17.713 ms, 18.076 ms] -1.456 ms (-7.5%)
profiling 18.699 ms [18.513 ms, 18.885 ms] -651.378 µs (-3.4%)
tracing 17.739 ms [17.564 ms, 17.914 ms] -1.612 ms (-8.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master naji.astier/refactor-trace-parent-building
git_commit_date 1766160938 1766415524
git_commit_sha 13c1634 625a498
release_version 1.58.0-SNAPSHOT~13c16342ac 1.58.0-SNAPSHOT~625a4988c6
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1766417666 1766417666
ci_job_id 1313612186 1313612186
ci_pipeline_id 88049188 88049188
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-fw6e5kqd 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-fw6e5kqd 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~625a4988c6, baseline=1.58.0-SNAPSHOT~13c16342ac
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.473 ms) : 1462, 1485
.   : milestone, 1473,
appsec (3.649 ms) : 3433, 3864
.   : milestone, 3649,
iast (2.203 ms) : 2138, 2267
.   : milestone, 2203,
iast_GLOBAL (2.251 ms) : 2186, 2316
.   : milestone, 2251,
profiling (2.452 ms) : 2289, 2614
.   : milestone, 2452,
tracing (2.041 ms) : 1990, 2092
.   : milestone, 2041,
section candidate
no_agent (1.471 ms) : 1459, 1482
.   : milestone, 1471,
appsec (3.726 ms) : 3507, 3945
.   : milestone, 3726,
iast (2.204 ms) : 2140, 2268
.   : milestone, 2204,
iast_GLOBAL (2.245 ms) : 2180, 2310
.   : milestone, 2245,
profiling (2.083 ms) : 2029, 2137
.   : milestone, 2083,
tracing (2.038 ms) : 1987, 2089
.   : milestone, 2038,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.473 ms [1.462 ms, 1.485 ms] -
appsec 3.649 ms [3.433 ms, 3.864 ms] 2.175 ms (147.7%)
iast 2.203 ms [2.138 ms, 2.267 ms] 729.475 µs (49.5%)
iast_GLOBAL 2.251 ms [2.186 ms, 2.316 ms] 777.68 µs (52.8%)
profiling 2.452 ms [2.289 ms, 2.614 ms] 978.676 µs (66.4%)
tracing 2.041 ms [1.99 ms, 2.092 ms] 567.508 µs (38.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.471 ms [1.459 ms, 1.482 ms] -
appsec 3.726 ms [3.507 ms, 3.945 ms] 2.255 ms (153.3%)
iast 2.204 ms [2.14 ms, 2.268 ms] 733.185 µs (49.8%)
iast_GLOBAL 2.245 ms [2.18 ms, 2.31 ms] 773.819 µs (52.6%)
profiling 2.083 ms [2.029 ms, 2.137 ms] 612.432 µs (41.6%)
tracing 2.038 ms [1.987 ms, 2.089 ms] 566.85 µs (38.5%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~625a4988c6, baseline=1.58.0-SNAPSHOT~13c16342ac
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.566 s) : 15566000, 15566000
.   : milestone, 15566000,
appsec (14.842 s) : 14842000, 14842000
.   : milestone, 14842000,
iast (18.073 s) : 18073000, 18073000
.   : milestone, 18073000,
iast_GLOBAL (17.704 s) : 17704000, 17704000
.   : milestone, 17704000,
profiling (14.663 s) : 14663000, 14663000
.   : milestone, 14663000,
tracing (14.829 s) : 14829000, 14829000
.   : milestone, 14829000,
section candidate
no_agent (15.045 s) : 15045000, 15045000
.   : milestone, 15045000,
appsec (14.515 s) : 14515000, 14515000
.   : milestone, 14515000,
iast (18.447 s) : 18447000, 18447000
.   : milestone, 18447000,
iast_GLOBAL (17.882 s) : 17882000, 17882000
.   : milestone, 17882000,
profiling (14.954 s) : 14954000, 14954000
.   : milestone, 14954000,
tracing (14.694 s) : 14694000, 14694000
.   : milestone, 14694000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.566 s [15.566 s, 15.566 s] -
appsec 14.842 s [14.842 s, 14.842 s] -724.0 ms (-4.7%)
iast 18.073 s [18.073 s, 18.073 s] 2.507 s (16.1%)
iast_GLOBAL 17.704 s [17.704 s, 17.704 s] 2.138 s (13.7%)
profiling 14.663 s [14.663 s, 14.663 s] -903.0 ms (-5.8%)
tracing 14.829 s [14.829 s, 14.829 s] -737.0 ms (-4.7%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.045 s [15.045 s, 15.045 s] -
appsec 14.515 s [14.515 s, 14.515 s] -530.0 ms (-3.5%)
iast 18.447 s [18.447 s, 18.447 s] 3.402 s (22.6%)
iast_GLOBAL 17.882 s [17.882 s, 17.882 s] 2.837 s (18.9%)
profiling 14.954 s [14.954 s, 14.954 s] -91.0 ms (-0.6%)
tracing 14.694 s [14.694 s, 14.694 s] -351.0 ms (-2.3%)

PerfectSlayer
PerfectSlayer reviewed Dec 22, 2025
View reviewed changes
@PerfectSlayer PerfectSlayer removed inst: jdbc JDBC instrumentation comp: api Tracer public API inst: mongodb MongoDB instrumentation labels Dec 22, 2025
@na-ji na-ji force-pushed the naji.astier/refactor-trace-parent-building branch from 3aa1a03 to 4a4b35f Compare December 22, 2025 13:13
@na-ji na-ji requested a review from PerfectSlayer December 22, 2025 13:53
@na-ji na-ji force-pushed the naji.astier/refactor-trace-parent-building branch from 14d9bcc to 625a498 Compare December 22, 2025 14:58
@na-ji na-ji requested review from PerfectSlayer and removed request for PerfectSlayer December 23, 2025 09:42
PerfectSlayer
PerfectSlayer approved these changes Dec 23, 2025
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 praise: ‏Thanks for the follow up changes!

@na-ji na-ji merged commit ab049bd into master Dec 23, 2025
721 of 723 checks passed
@na-ji na-ji deleted the naji.astier/refactor-trace-parent-building branch December 23, 2025 15:30
@github-actions github-actions bot added this to the 1.58.0 milestone Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@mhlidd mhlidd mhlidd approved these changes

@cecile75 cecile75 Awaiting requested review from cecile75 cecile75 is a code owner automatically assigned from DataDog/apm-sdk-capabilities-java

Assignees

@na-ji na-ji

Labels

comp: core Tracer core type: refactoring

Projects

None yet

Milestone

1.58.0

Development

Successfully merging this pull request may close these issues.

4 participants

@na-ji @PerfectSlayer @mhlidd