-
Notifications
You must be signed in to change notification settings - Fork 322
Ensure the class name is valid when enhancing with SerialVersionUIDAdder #10270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcculls
approved these changes
Dec 29, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.58.0-SNAPSHOT~953b0eda6b, baseline=1.58.0-SNAPSHOT~ab049bd23d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.083 s) : 0, 1083162
Total [baseline] (8.771 s) : 0, 8771475
Agent [candidate] (1.084 s) : 0, 1083744
Total [candidate] (8.78 s) : 0, 8780040
section iast
Agent [baseline] (1.228 s) : 0, 1228114
Total [baseline] (9.37 s) : 0, 9370441
Agent [candidate] (1.224 s) : 0, 1224353
Total [candidate] (9.302 s) : 0, 9302122
gantt
title insecure-bank - break down per module: candidate=1.58.0-SNAPSHOT~953b0eda6b, baseline=1.58.0-SNAPSHOT~ab049bd23d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.179 ms) : 0, 1179
crashtracking [candidate] (1.207 ms) : 0, 1207
BytebuddyAgent [baseline] (651.301 ms) : 0, 651301
BytebuddyAgent [candidate] (651.752 ms) : 0, 651752
GlobalTracer [baseline] (281.973 ms) : 0, 281973
GlobalTracer [candidate] (282.136 ms) : 0, 282136
AppSec [baseline] (32.533 ms) : 0, 32533
AppSec [candidate] (32.675 ms) : 0, 32675
Debugger [baseline] (67.325 ms) : 0, 67325
Debugger [candidate] (67.013 ms) : 0, 67013
Remote Config [baseline] (668.68 µs) : 0, 669
Remote Config [candidate] (643.803 µs) : 0, 644
Telemetry [baseline] (8.983 ms) : 0, 8983
Telemetry [candidate] (9.014 ms) : 0, 9014
Flare Poller [baseline] (3.701 ms) : 0, 3701
Flare Poller [candidate] (3.724 ms) : 0, 3724
section iast
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (795.301 ms) : 0, 795301
BytebuddyAgent [candidate] (792.964 ms) : 0, 792964
GlobalTracer [baseline] (256.429 ms) : 0, 256429
GlobalTracer [candidate] (255.807 ms) : 0, 255807
AppSec [baseline] (34.776 ms) : 0, 34776
AppSec [candidate] (33.456 ms) : 0, 33456
Debugger [baseline] (65.072 ms) : 0, 65072
Debugger [candidate] (65.656 ms) : 0, 65656
Remote Config [baseline] (590.856 µs) : 0, 591
Remote Config [candidate] (578.731 µs) : 0, 579
Telemetry [baseline] (8.528 ms) : 0, 8528
Telemetry [candidate] (8.53 ms) : 0, 8530
Flare Poller [baseline] (3.492 ms) : 0, 3492
Flare Poller [candidate] (3.505 ms) : 0, 3505
IAST [baseline] (27.262 ms) : 0, 27262
IAST [candidate] (27.127 ms) : 0, 27127
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.58.0-SNAPSHOT~953b0eda6b, baseline=1.58.0-SNAPSHOT~ab049bd23d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.087 s) : 0, 1086863
Total [baseline] (10.965 s) : 0, 10965344
Agent [candidate] (1.103 s) : 0, 1103209
Total [candidate] (10.912 s) : 0, 10911646
section appsec
Agent [baseline] (1.269 s) : 0, 1268898
Total [baseline] (11.001 s) : 0, 11001400
Agent [candidate] (1.269 s) : 0, 1268542
Total [candidate] (10.977 s) : 0, 10976610
section iast
Agent [baseline] (1.225 s) : 0, 1224698
Total [baseline] (11.19 s) : 0, 11190413
Agent [candidate] (1.232 s) : 0, 1232169
Total [candidate] (11.129 s) : 0, 11129173
section profiling
Agent [baseline] (1.204 s) : 0, 1204329
Total [baseline] (10.882 s) : 0, 10882049
Agent [candidate] (1.206 s) : 0, 1205587
Total [candidate] (10.892 s) : 0, 10892454
gantt
title petclinic - break down per module: candidate=1.58.0-SNAPSHOT~953b0eda6b, baseline=1.58.0-SNAPSHOT~ab049bd23d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.203 ms) : 0, 1203
BytebuddyAgent [baseline] (652.5 ms) : 0, 652500
BytebuddyAgent [candidate] (661.824 ms) : 0, 661824
GlobalTracer [baseline] (282.915 ms) : 0, 282915
GlobalTracer [candidate] (287.435 ms) : 0, 287435
AppSec [baseline] (32.662 ms) : 0, 32662
AppSec [candidate] (33.372 ms) : 0, 33372
Debugger [baseline] (68.695 ms) : 0, 68695
Debugger [candidate] (69.804 ms) : 0, 69804
Remote Config [baseline] (622.652 µs) : 0, 623
Remote Config [candidate] (625.319 µs) : 0, 625
Telemetry [baseline] (8.978 ms) : 0, 8978
Telemetry [candidate] (9.079 ms) : 0, 9079
Flare Poller [baseline] (3.751 ms) : 0, 3751
Flare Poller [candidate] (3.85 ms) : 0, 3850
section appsec
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (692.297 ms) : 0, 692297
BytebuddyAgent [candidate] (694.169 ms) : 0, 694169
GlobalTracer [baseline] (258.125 ms) : 0, 258125
GlobalTracer [candidate] (258.842 ms) : 0, 258842
IAST [baseline] (24.784 ms) : 0, 24784
IAST [candidate] (24.813 ms) : 0, 24813
AppSec [baseline] (175.963 ms) : 0, 175963
AppSec [candidate] (174.348 ms) : 0, 174348
Debugger [baseline] (67.23 ms) : 0, 67230
Debugger [candidate] (65.89 ms) : 0, 65890
Remote Config [baseline] (792.484 µs) : 0, 792
Remote Config [candidate] (755.619 µs) : 0, 756
Telemetry [baseline] (9.408 ms) : 0, 9408
Telemetry [candidate] (9.31 ms) : 0, 9310
Flare Poller [baseline] (3.681 ms) : 0, 3681
Flare Poller [candidate] (3.719 ms) : 0, 3719
section iast
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (792.164 ms) : 0, 792164
BytebuddyAgent [candidate] (798.713 ms) : 0, 798713
GlobalTracer [baseline] (255.771 ms) : 0, 255771
GlobalTracer [candidate] (257.363 ms) : 0, 257363
IAST [baseline] (27.33 ms) : 0, 27330
IAST [candidate] (27.428 ms) : 0, 27428
AppSec [baseline] (33.657 ms) : 0, 33657
AppSec [candidate] (34.965 ms) : 0, 34965
Debugger [baseline] (66.562 ms) : 0, 66562
Debugger [candidate] (64.347 ms) : 0, 64347
Remote Config [baseline] (550.102 µs) : 0, 550
Remote Config [candidate] (568.563 µs) : 0, 569
Telemetry [baseline] (8.444 ms) : 0, 8444
Telemetry [candidate] (8.441 ms) : 0, 8441
Flare Poller [baseline] (3.489 ms) : 0, 3489
Flare Poller [candidate] (3.534 ms) : 0, 3534
section profiling
crashtracking [baseline] (1.214 ms) : 0, 1214
crashtracking [candidate] (1.213 ms) : 0, 1213
BytebuddyAgent [baseline] (703.375 ms) : 0, 703375
BytebuddyAgent [candidate] (703.645 ms) : 0, 703645
GlobalTracer [baseline] (220.229 ms) : 0, 220229
GlobalTracer [candidate] (220.058 ms) : 0, 220058
AppSec [baseline] (32.104 ms) : 0, 32104
AppSec [candidate] (32.16 ms) : 0, 32160
Debugger [baseline] (67.713 ms) : 0, 67713
Debugger [candidate] (68.503 ms) : 0, 68503
Remote Config [baseline] (600.228 µs) : 0, 600
Remote Config [candidate] (630.294 µs) : 0, 630
Telemetry [baseline] (8.717 ms) : 0, 8717
Telemetry [candidate] (8.737 ms) : 0, 8737
Flare Poller [baseline] (3.629 ms) : 0, 3629
Flare Poller [candidate] (3.691 ms) : 0, 3691
ProfilingAgent [baseline] (97.008 ms) : 0, 97008
ProfilingAgent [candidate] (97.09 ms) : 0, 97090
Profiling [baseline] (97.588 ms) : 0, 97588
Profiling [candidate] (97.674 ms) : 0, 97674
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 17 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~953b0eda6b, baseline=1.58.0-SNAPSHOT~ab049bd23d
dateFormat X
axisFormat %s
section baseline
no_agent (1.212 ms) : 1200, 1224
. : milestone, 1212,
iast (3.207 ms) : 3163, 3252
. : milestone, 3207,
iast_FULL (5.695 ms) : 5638, 5751
. : milestone, 5695,
iast_GLOBAL (3.671 ms) : 3613, 3730
. : milestone, 3671,
profiling (1.957 ms) : 1939, 1975
. : milestone, 1957,
tracing (1.805 ms) : 1790, 1820
. : milestone, 1805,
section candidate
no_agent (1.187 ms) : 1176, 1198
. : milestone, 1187,
iast (3.318 ms) : 3274, 3363
. : milestone, 3318,
iast_FULL (5.848 ms) : 5788, 5907
. : milestone, 5848,
iast_GLOBAL (3.505 ms) : 3449, 3560
. : milestone, 3505,
profiling (1.952 ms) : 1936, 1969
. : milestone, 1952,
tracing (1.792 ms) : 1776, 1807
. : milestone, 1792,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~953b0eda6b, baseline=1.58.0-SNAPSHOT~ab049bd23d
dateFormat X
axisFormat %s
section baseline
no_agent (17.821 ms) : 17639, 18002
. : milestone, 17821,
appsec (18.6 ms) : 18408, 18792
. : milestone, 18600,
code_origins (18.436 ms) : 18254, 18618
. : milestone, 18436,
iast (17.904 ms) : 17726, 18082
. : milestone, 17904,
profiling (18.644 ms) : 18456, 18832
. : milestone, 18644,
tracing (17.49 ms) : 17316, 17664
. : milestone, 17490,
section candidate
no_agent (19.559 ms) : 19353, 19765
. : milestone, 19559,
appsec (18.862 ms) : 18668, 19056
. : milestone, 18862,
code_origins (17.678 ms) : 17501, 17855
. : milestone, 17678,
iast (17.686 ms) : 17512, 17861
. : milestone, 17686,
profiling (18.581 ms) : 18395, 18768
. : milestone, 18581,
tracing (17.481 ms) : 17310, 17651
. : milestone, 17481,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~953b0eda6b, baseline=1.58.0-SNAPSHOT~ab049bd23d
dateFormat X
axisFormat %s
section baseline
no_agent (14.867 s) : 14867000, 14867000
. : milestone, 14867000,
appsec (14.841 s) : 14841000, 14841000
. : milestone, 14841000,
iast (17.836 s) : 17836000, 17836000
. : milestone, 17836000,
iast_GLOBAL (17.842 s) : 17842000, 17842000
. : milestone, 17842000,
profiling (15.003 s) : 15003000, 15003000
. : milestone, 15003000,
tracing (14.724 s) : 14724000, 14724000
. : milestone, 14724000,
section candidate
no_agent (15.292 s) : 15292000, 15292000
. : milestone, 15292000,
appsec (15.066 s) : 15066000, 15066000
. : milestone, 15066000,
iast (17.907 s) : 17907000, 17907000
. : milestone, 17907000,
iast_GLOBAL (17.937 s) : 17937000, 17937000
. : milestone, 17937000,
profiling (15.102 s) : 15102000, 15102000
. : milestone, 15102000,
tracing (14.821 s) : 14821000, 14821000
. : milestone, 14821000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~953b0eda6b, baseline=1.58.0-SNAPSHOT~ab049bd23d
dateFormat X
axisFormat %s
section baseline
no_agent (1.47 ms) : 1458, 1481
. : milestone, 1470,
appsec (3.584 ms) : 3374, 3794
. : milestone, 3584,
iast (2.199 ms) : 2135, 2263
. : milestone, 2199,
iast_GLOBAL (2.241 ms) : 2176, 2305
. : milestone, 2241,
profiling (2.053 ms) : 2001, 2105
. : milestone, 2053,
tracing (2.032 ms) : 1982, 2083
. : milestone, 2032,
section candidate
no_agent (1.468 ms) : 1457, 1480
. : milestone, 1468,
appsec (3.655 ms) : 3436, 3874
. : milestone, 3655,
iast (2.203 ms) : 2139, 2268
. : milestone, 2203,
iast_GLOBAL (2.251 ms) : 2186, 2316
. : milestone, 2251,
profiling (2.474 ms) : 2313, 2636
. : milestone, 2474,
tracing (2.037 ms) : 1987, 2088
. : milestone, 2037,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: core
Tracer core
tag: telemetry error reported
Reported by error telemetry
type: bug
Bug report and fix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
According to that telemetry issue it seems that the class name can be null while visiting it:
This PR avoid trigger a computation when the required meta are missing
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]