-
Notifications
You must be signed in to change notification settings - Fork 323
Convert downstream requests header keys to lower case #10319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert downstream requests header keys to lower case #10319
Conversation
jandro996
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~85670c04df, baseline=1.59.0-SNAPSHOT~8ef6e7ab7b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.089 s) : 0, 1088987
Total [baseline] (8.778 s) : 0, 8778306
Agent [candidate] (1.085 s) : 0, 1084737
Total [candidate] (8.742 s) : 0, 8742422
section iast
Agent [baseline] (1.229 s) : 0, 1229198
Total [baseline] (9.332 s) : 0, 9332424
Agent [candidate] (1.22 s) : 0, 1220226
Total [candidate] (9.267 s) : 0, 9267232
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~85670c04df, baseline=1.59.0-SNAPSHOT~8ef6e7ab7b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.205 ms) : 0, 1205
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (654.561 ms) : 0, 654561
BytebuddyAgent [candidate] (651.861 ms) : 0, 651861
GlobalTracer [baseline] (283.944 ms) : 0, 283944
GlobalTracer [candidate] (282.859 ms) : 0, 282859
AppSec [baseline] (32.973 ms) : 0, 32973
AppSec [candidate] (32.581 ms) : 0, 32581
Debugger [baseline] (67.404 ms) : 0, 67404
Debugger [candidate] (67.285 ms) : 0, 67285
Remote Config [baseline] (624.328 µs) : 0, 624
Remote Config [candidate] (618.713 µs) : 0, 619
Telemetry [baseline] (8.964 ms) : 0, 8964
Telemetry [candidate] (9.079 ms) : 0, 9079
Flare Poller [baseline] (3.748 ms) : 0, 3748
Flare Poller [candidate] (3.792 ms) : 0, 3792
section iast
crashtracking [baseline] (1.179 ms) : 0, 1179
crashtracking [candidate] (1.175 ms) : 0, 1175
BytebuddyAgent [baseline] (795.583 ms) : 0, 795583
BytebuddyAgent [candidate] (789.956 ms) : 0, 789956
GlobalTracer [baseline] (257.233 ms) : 0, 257233
GlobalTracer [candidate] (255.076 ms) : 0, 255076
IAST [baseline] (27.172 ms) : 0, 27172
IAST [candidate] (27.006 ms) : 0, 27006
AppSec [baseline] (34.309 ms) : 0, 34309
AppSec [candidate] (34.38 ms) : 0, 34380
Debugger [baseline] (65.482 ms) : 0, 65482
Debugger [candidate] (64.747 ms) : 0, 64747
Remote Config [baseline] (590.202 µs) : 0, 590
Remote Config [candidate] (594.33 µs) : 0, 594
Telemetry [baseline] (8.548 ms) : 0, 8548
Telemetry [candidate] (8.414 ms) : 0, 8414
Flare Poller [baseline] (3.58 ms) : 0, 3580
Flare Poller [candidate] (3.534 ms) : 0, 3534
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~85670c04df, baseline=1.59.0-SNAPSHOT~8ef6e7ab7b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.09 s) : 0, 1089902
Total [baseline] (10.743 s) : 0, 10742955
Agent [candidate] (1.087 s) : 0, 1086891
Total [candidate] (10.718 s) : 0, 10718089
section appsec
Agent [baseline] (1.272 s) : 0, 1272473
Total [baseline] (11.013 s) : 0, 11013461
Agent [candidate] (1.268 s) : 0, 1267937
Total [candidate] (10.944 s) : 0, 10944464
section iast
Agent [baseline] (1.223 s) : 0, 1223285
Total [baseline] (11.178 s) : 0, 11178173
Agent [candidate] (1.224 s) : 0, 1223817
Total [candidate] (11.182 s) : 0, 11181992
section profiling
Agent [baseline] (1.228 s) : 0, 1228073
Total [baseline] (11.049 s) : 0, 11048571
Agent [candidate] (1.21 s) : 0, 1210125
Total [candidate] (10.94 s) : 0, 10940195
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~85670c04df, baseline=1.59.0-SNAPSHOT~8ef6e7ab7b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (654.378 ms) : 0, 654378
BytebuddyAgent [candidate] (652.75 ms) : 0, 652750
GlobalTracer [baseline] (283.755 ms) : 0, 283755
GlobalTracer [candidate] (282.841 ms) : 0, 282841
AppSec [baseline] (32.921 ms) : 0, 32921
AppSec [candidate] (32.827 ms) : 0, 32827
Debugger [baseline] (68.483 ms) : 0, 68483
Debugger [candidate] (68.403 ms) : 0, 68403
Remote Config [baseline] (632.886 µs) : 0, 633
Remote Config [candidate] (632.592 µs) : 0, 633
Telemetry [baseline] (9.081 ms) : 0, 9081
Telemetry [candidate] (8.987 ms) : 0, 8987
Flare Poller [baseline] (3.809 ms) : 0, 3809
Flare Poller [candidate] (3.741 ms) : 0, 3741
section appsec
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (694.952 ms) : 0, 694952
BytebuddyAgent [candidate] (691.814 ms) : 0, 691814
GlobalTracer [baseline] (259.443 ms) : 0, 259443
GlobalTracer [candidate] (259.398 ms) : 0, 259398
AppSec [baseline] (174.272 ms) : 0, 174272
AppSec [candidate] (173.634 ms) : 0, 173634
Debugger [baseline] (68.54 ms) : 0, 68540
Debugger [candidate] (67.908 ms) : 0, 67908
Remote Config [baseline] (757.457 µs) : 0, 757
Remote Config [candidate] (727.613 µs) : 0, 728
Telemetry [baseline] (9.38 ms) : 0, 9380
Telemetry [candidate] (9.474 ms) : 0, 9474
Flare Poller [baseline] (3.693 ms) : 0, 3693
Flare Poller [candidate] (3.737 ms) : 0, 3737
IAST [baseline] (24.776 ms) : 0, 24776
IAST [candidate] (24.66 ms) : 0, 24660
section iast
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.178 ms) : 0, 1178
BytebuddyAgent [baseline] (790.701 ms) : 0, 790701
BytebuddyAgent [candidate] (791.369 ms) : 0, 791369
GlobalTracer [baseline] (255.731 ms) : 0, 255731
GlobalTracer [candidate] (256.143 ms) : 0, 256143
AppSec [baseline] (34.29 ms) : 0, 34290
AppSec [candidate] (35.138 ms) : 0, 35138
Debugger [baseline] (66.294 ms) : 0, 66294
Debugger [candidate] (65.057 ms) : 0, 65057
Remote Config [baseline] (593.21 µs) : 0, 593
Remote Config [candidate] (599.92 µs) : 0, 600
Telemetry [baseline] (8.628 ms) : 0, 8628
Telemetry [candidate] (8.508 ms) : 0, 8508
Flare Poller [baseline] (3.568 ms) : 0, 3568
Flare Poller [candidate] (3.538 ms) : 0, 3538
IAST [baseline] (26.994 ms) : 0, 26994
IAST [candidate] (26.979 ms) : 0, 26979
section profiling
ProfilingAgent [baseline] (97.596 ms) : 0, 97596
ProfilingAgent [candidate] (96.834 ms) : 0, 96834
crashtracking [baseline] (1.238 ms) : 0, 1238
crashtracking [candidate] (1.219 ms) : 0, 1219
BytebuddyAgent [baseline] (718.131 ms) : 0, 718131
BytebuddyAgent [candidate] (706.402 ms) : 0, 706402
GlobalTracer [baseline] (224.744 ms) : 0, 224744
GlobalTracer [candidate] (221.811 ms) : 0, 221811
AppSec [baseline] (33.265 ms) : 0, 33265
AppSec [candidate] (32.402 ms) : 0, 32402
Debugger [baseline] (68.803 ms) : 0, 68803
Debugger [candidate] (68.452 ms) : 0, 68452
Remote Config [baseline] (648.361 µs) : 0, 648
Remote Config [candidate] (619.358 µs) : 0, 619
Telemetry [baseline] (8.881 ms) : 0, 8881
Telemetry [candidate] (8.642 ms) : 0, 8642
Flare Poller [baseline] (3.671 ms) : 0, 3671
Flare Poller [candidate] (3.601 ms) : 0, 3601
Profiling [baseline] (98.194 ms) : 0, 98194
Profiling [candidate] (97.409 ms) : 0, 97409
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 19 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~85670c04df, baseline=1.59.0-SNAPSHOT~8ef6e7ab7b
dateFormat X
axisFormat %s
section baseline
no_agent (18.024 ms) : 17839, 18209
. : milestone, 18024,
appsec (18.555 ms) : 18365, 18746
. : milestone, 18555,
code_origins (17.828 ms) : 17652, 18004
. : milestone, 17828,
iast (17.745 ms) : 17568, 17922
. : milestone, 17745,
profiling (18.424 ms) : 18240, 18607
. : milestone, 18424,
tracing (17.806 ms) : 17629, 17984
. : milestone, 17806,
section candidate
no_agent (19.358 ms) : 19161, 19556
. : milestone, 19358,
appsec (18.543 ms) : 18350, 18736
. : milestone, 18543,
code_origins (17.564 ms) : 17389, 17739
. : milestone, 17564,
iast (17.688 ms) : 17513, 17863
. : milestone, 17688,
profiling (18.505 ms) : 18318, 18692
. : milestone, 18505,
tracing (17.859 ms) : 17680, 18039
. : milestone, 17859,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~85670c04df, baseline=1.59.0-SNAPSHOT~8ef6e7ab7b
dateFormat X
axisFormat %s
section baseline
no_agent (1.193 ms) : 1181, 1205
. : milestone, 1193,
iast (3.189 ms) : 3143, 3235
. : milestone, 3189,
iast_FULL (5.596 ms) : 5541, 5651
. : milestone, 5596,
iast_GLOBAL (3.538 ms) : 3479, 3597
. : milestone, 3538,
profiling (2.002 ms) : 1983, 2021
. : milestone, 2002,
tracing (1.755 ms) : 1741, 1769
. : milestone, 1755,
section candidate
no_agent (1.179 ms) : 1168, 1190
. : milestone, 1179,
iast (3.158 ms) : 3123, 3192
. : milestone, 3158,
iast_FULL (5.735 ms) : 5678, 5791
. : milestone, 5735,
iast_GLOBAL (3.474 ms) : 3424, 3524
. : milestone, 3474,
profiling (2.054 ms) : 2035, 2073
. : milestone, 2054,
tracing (1.776 ms) : 1761, 1791
. : milestone, 1776,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~85670c04df, baseline=1.59.0-SNAPSHOT~8ef6e7ab7b
dateFormat X
axisFormat %s
section baseline
no_agent (15.08 s) : 15080000, 15080000
. : milestone, 15080000,
appsec (14.708 s) : 14708000, 14708000
. : milestone, 14708000,
iast (18.204 s) : 18204000, 18204000
. : milestone, 18204000,
iast_GLOBAL (17.923 s) : 17923000, 17923000
. : milestone, 17923000,
profiling (14.774 s) : 14774000, 14774000
. : milestone, 14774000,
tracing (14.457 s) : 14457000, 14457000
. : milestone, 14457000,
section candidate
no_agent (14.917 s) : 14917000, 14917000
. : milestone, 14917000,
appsec (14.595 s) : 14595000, 14595000
. : milestone, 14595000,
iast (18.392 s) : 18392000, 18392000
. : milestone, 18392000,
iast_GLOBAL (17.972 s) : 17972000, 17972000
. : milestone, 17972000,
profiling (14.586 s) : 14586000, 14586000
. : milestone, 14586000,
tracing (14.787 s) : 14787000, 14787000
. : milestone, 14787000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~85670c04df, baseline=1.59.0-SNAPSHOT~8ef6e7ab7b
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (3.689 ms) : 3472, 3906
. : milestone, 3689,
iast (2.215 ms) : 2150, 2280
. : milestone, 2215,
iast_GLOBAL (2.269 ms) : 2204, 2334
. : milestone, 2269,
profiling (2.142 ms) : 2086, 2198
. : milestone, 2142,
tracing (2.043 ms) : 1992, 2094
. : milestone, 2043,
section candidate
no_agent (1.481 ms) : 1469, 1492
. : milestone, 1481,
appsec (3.665 ms) : 3451, 3879
. : milestone, 3665,
iast (2.227 ms) : 2162, 2291
. : milestone, 2227,
iast_GLOBAL (2.274 ms) : 2208, 2340
. : milestone, 2274,
profiling (2.056 ms) : 2004, 2108
. : milestone, 2056,
tracing (2.053 ms) : 2002, 2104
. : milestone, 2053,
|
What Does This Do
Convert header keys to lower case before being set to the WAF
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: APPSEC-60515