Refine service name sources for configuration options#10658
Refine service name sources for configuration options#10658gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomasterfrom
Conversation
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 2 metrics, 0 unstable metrics.
See unchanged results
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~1962e89aec, baseline=1.60.0-SNAPSHOT~d7515c8b3c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1081372
Total [baseline] (11.03 s) : 0, 11029715
Agent [candidate] (1.064 s) : 0, 1063681
Total [candidate] (10.769 s) : 0, 10768930
section appsec
Agent [baseline] (1.236 s) : 0, 1236026
Total [baseline] (10.955 s) : 0, 10955447
Agent [candidate] (1.24 s) : 0, 1239603
Total [candidate] (11.053 s) : 0, 11052821
section iast
Agent [baseline] (1.247 s) : 0, 1247090
Total [baseline] (11.333 s) : 0, 11333198
Agent [candidate] (1.232 s) : 0, 1231516
Total [candidate] (11.17 s) : 0, 11169879
section profiling
Agent [baseline] (1.188 s) : 0, 1188073
Total [baseline] (10.91 s) : 0, 10909917
Agent [candidate] (1.19 s) : 0, 1190219
Total [candidate] (10.887 s) : 0, 10886849
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~1962e89aec, baseline=1.60.0-SNAPSHOT~d7515c8b3c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.202 ms) : 0, 1202
crashtracking [candidate] (1.201 ms) : 0, 1201
BytebuddyAgent [baseline] (637.796 ms) : 0, 637796
BytebuddyAgent [candidate] (626.499 ms) : 0, 626499
AgentMeter [baseline] (29.575 ms) : 0, 29575
AgentMeter [candidate] (29.017 ms) : 0, 29017
GlobalTracer [baseline] (260.846 ms) : 0, 260846
GlobalTracer [candidate] (257.171 ms) : 0, 257171
AppSec [baseline] (33.435 ms) : 0, 33435
AppSec [candidate] (32.811 ms) : 0, 32811
Debugger [baseline] (64.637 ms) : 0, 64637
Debugger [candidate] (63.644 ms) : 0, 63644
Remote Config [baseline] (623.135 µs) : 0, 623
Remote Config [candidate] (621.982 µs) : 0, 622
Telemetry [baseline] (10.002 ms) : 0, 10002
Telemetry [candidate] (11.418 ms) : 0, 11418
Flare Poller [baseline] (6.736 ms) : 0, 6736
Flare Poller [candidate] (5.274 ms) : 0, 5274
section appsec
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (656.707 ms) : 0, 656707
BytebuddyAgent [candidate] (658.664 ms) : 0, 658664
AgentMeter [baseline] (11.886 ms) : 0, 11886
AgentMeter [candidate] (12.008 ms) : 0, 12008
GlobalTracer [baseline] (257.243 ms) : 0, 257243
GlobalTracer [candidate] (258.614 ms) : 0, 258614
IAST [baseline] (25.288 ms) : 0, 25288
IAST [candidate] (25.384 ms) : 0, 25384
AppSec [baseline] (167.583 ms) : 0, 167583
AppSec [candidate] (168.55 ms) : 0, 168550
Debugger [baseline] (66.368 ms) : 0, 66368
Debugger [candidate] (65.578 ms) : 0, 65578
Remote Config [baseline] (649.616 µs) : 0, 650
Remote Config [candidate] (637.016 µs) : 0, 637
Telemetry [baseline] (9.454 ms) : 0, 9454
Telemetry [candidate] (9.412 ms) : 0, 9412
Flare Poller [baseline] (3.757 ms) : 0, 3757
Flare Poller [candidate] (3.643 ms) : 0, 3643
section iast
crashtracking [baseline] (1.217 ms) : 0, 1217
crashtracking [candidate] (1.207 ms) : 0, 1207
BytebuddyAgent [baseline] (806.945 ms) : 0, 806945
BytebuddyAgent [candidate] (795.834 ms) : 0, 795834
AgentMeter [baseline] (11.776 ms) : 0, 11776
AgentMeter [candidate] (11.321 ms) : 0, 11321
GlobalTracer [baseline] (249.849 ms) : 0, 249849
GlobalTracer [candidate] (247.693 ms) : 0, 247693
IAST [baseline] (27.377 ms) : 0, 27377
IAST [candidate] (26.97 ms) : 0, 26970
AppSec [baseline] (33.988 ms) : 0, 33988
AppSec [candidate] (35.518 ms) : 0, 35518
Debugger [baseline] (67.141 ms) : 0, 67141
Debugger [candidate] (64.438 ms) : 0, 64438
Remote Config [baseline] (540.284 µs) : 0, 540
Remote Config [candidate] (535.398 µs) : 0, 535
Telemetry [baseline] (8.634 ms) : 0, 8634
Telemetry [candidate] (8.632 ms) : 0, 8632
Flare Poller [baseline] (3.425 ms) : 0, 3425
Flare Poller [candidate] (3.468 ms) : 0, 3468
section profiling
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (680.601 ms) : 0, 680601
BytebuddyAgent [candidate] (681.379 ms) : 0, 681379
AgentMeter [baseline] (8.502 ms) : 0, 8502
AgentMeter [candidate] (8.523 ms) : 0, 8523
GlobalTracer [baseline] (215.756 ms) : 0, 215756
GlobalTracer [candidate] (215.844 ms) : 0, 215844
AppSec [baseline] (32.515 ms) : 0, 32515
AppSec [candidate] (32.472 ms) : 0, 32472
Debugger [baseline] (66.765 ms) : 0, 66765
Debugger [candidate] (67.027 ms) : 0, 67027
Remote Config [baseline] (628.879 µs) : 0, 629
Remote Config [candidate] (639.568 µs) : 0, 640
Telemetry [baseline] (8.934 ms) : 0, 8934
Telemetry [candidate] (9.011 ms) : 0, 9011
Flare Poller [baseline] (3.779 ms) : 0, 3779
Flare Poller [candidate] (3.778 ms) : 0, 3778
ProfilingAgent [baseline] (98.946 ms) : 0, 98946
ProfilingAgent [candidate] (99.781 ms) : 0, 99781
Profiling [baseline] (99.512 ms) : 0, 99512
Profiling [candidate] (100.366 ms) : 0, 100366
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~1962e89aec, baseline=1.60.0-SNAPSHOT~d7515c8b3c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1060900
Total [baseline] (8.697 s) : 0, 8696684
Agent [candidate] (1.064 s) : 0, 1064434
Total [candidate] (8.762 s) : 0, 8762406
section iast
Agent [baseline] (1.238 s) : 0, 1237811
Total [baseline] (9.398 s) : 0, 9397960
Agent [candidate] (1.235 s) : 0, 1235237
Total [candidate] (9.346 s) : 0, 9346251
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~1962e89aec, baseline=1.60.0-SNAPSHOT~d7515c8b3c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.233 ms) : 0, 1233
BytebuddyAgent [baseline] (625.166 ms) : 0, 625166
BytebuddyAgent [candidate] (627.156 ms) : 0, 627156
AgentMeter [baseline] (28.949 ms) : 0, 28949
AgentMeter [candidate] (29.036 ms) : 0, 29036
GlobalTracer [baseline] (256.401 ms) : 0, 256401
GlobalTracer [candidate] (257.405 ms) : 0, 257405
AppSec [baseline] (32.974 ms) : 0, 32974
AppSec [candidate] (32.902 ms) : 0, 32902
Debugger [baseline] (63.72 ms) : 0, 63720
Debugger [candidate] (63.665 ms) : 0, 63665
Remote Config [baseline] (618.12 µs) : 0, 618
Remote Config [candidate] (634.093 µs) : 0, 634
Telemetry [baseline] (10.683 ms) : 0, 10683
Telemetry [candidate] (11.509 ms) : 0, 11509
Flare Poller [baseline] (5.261 ms) : 0, 5261
Flare Poller [candidate] (4.586 ms) : 0, 4586
section iast
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.208 ms) : 0, 1208
BytebuddyAgent [baseline] (800.328 ms) : 0, 800328
BytebuddyAgent [candidate] (801.041 ms) : 0, 801041
AgentMeter [baseline] (11.539 ms) : 0, 11539
AgentMeter [candidate] (11.555 ms) : 0, 11555
GlobalTracer [baseline] (248.481 ms) : 0, 248481
GlobalTracer [candidate] (247.188 ms) : 0, 247188
IAST [baseline] (27.19 ms) : 0, 27190
IAST [candidate] (26.915 ms) : 0, 26915
AppSec [baseline] (34.211 ms) : 0, 34211
AppSec [candidate] (33.867 ms) : 0, 33867
Debugger [baseline] (66.006 ms) : 0, 66006
Debugger [candidate] (64.881 ms) : 0, 64881
Remote Config [baseline] (540.962 µs) : 0, 541
Remote Config [candidate] (527.892 µs) : 0, 528
Telemetry [baseline] (8.718 ms) : 0, 8718
Telemetry [candidate] (8.589 ms) : 0, 8589
Flare Poller [baseline] (3.521 ms) : 0, 3521
Flare Poller [candidate] (3.452 ms) : 0, 3452
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 0 performance regressions! Performance is the same for 16 metrics, 17 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~1962e89aec, baseline=1.60.0-SNAPSHOT~d7515c8b3c
dateFormat X
axisFormat %s
section baseline
no_agent (19.478 ms) : 19281, 19674
. : milestone, 19478,
appsec (18.573 ms) : 18382, 18763
. : milestone, 18573,
code_origins (18.494 ms) : 18306, 18683
. : milestone, 18494,
iast (17.55 ms) : 17377, 17723
. : milestone, 17550,
profiling (18.563 ms) : 18377, 18749
. : milestone, 18563,
tracing (17.593 ms) : 17418, 17768
. : milestone, 17593,
section candidate
no_agent (18.249 ms) : 18061, 18437
. : milestone, 18249,
appsec (18.385 ms) : 18202, 18569
. : milestone, 18385,
code_origins (18.361 ms) : 18177, 18546
. : milestone, 18361,
iast (17.423 ms) : 17250, 17595
. : milestone, 17423,
profiling (18.649 ms) : 18464, 18834
. : milestone, 18649,
tracing (17.776 ms) : 17601, 17952
. : milestone, 17776,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~1962e89aec, baseline=1.60.0-SNAPSHOT~d7515c8b3c
dateFormat X
axisFormat %s
section baseline
no_agent (1.188 ms) : 1176, 1200
. : milestone, 1188,
iast (3.166 ms) : 3124, 3208
. : milestone, 3166,
iast_FULL (5.983 ms) : 5923, 6044
. : milestone, 5983,
iast_GLOBAL (3.661 ms) : 3600, 3721
. : milestone, 3661,
profiling (2.173 ms) : 2152, 2194
. : milestone, 2173,
tracing (1.755 ms) : 1740, 1770
. : milestone, 1755,
section candidate
no_agent (1.195 ms) : 1183, 1206
. : milestone, 1195,
iast (3.249 ms) : 3200, 3297
. : milestone, 3249,
iast_FULL (5.842 ms) : 5783, 5900
. : milestone, 5842,
iast_GLOBAL (3.446 ms) : 3401, 3491
. : milestone, 3446,
profiling (2.172 ms) : 2153, 2192
. : milestone, 2172,
tracing (1.76 ms) : 1745, 1775
. : milestone, 1760,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~1962e89aec, baseline=1.60.0-SNAPSHOT~d7515c8b3c
dateFormat X
axisFormat %s
section baseline
no_agent (14.968 s) : 14968000, 14968000
. : milestone, 14968000,
appsec (14.861 s) : 14861000, 14861000
. : milestone, 14861000,
iast (18.325 s) : 18325000, 18325000
. : milestone, 18325000,
iast_GLOBAL (17.798 s) : 17798000, 17798000
. : milestone, 17798000,
profiling (14.978 s) : 14978000, 14978000
. : milestone, 14978000,
tracing (14.592 s) : 14592000, 14592000
. : milestone, 14592000,
section candidate
no_agent (15.319 s) : 15319000, 15319000
. : milestone, 15319000,
appsec (15.154 s) : 15154000, 15154000
. : milestone, 15154000,
iast (18.328 s) : 18328000, 18328000
. : milestone, 18328000,
iast_GLOBAL (17.775 s) : 17775000, 17775000
. : milestone, 17775000,
profiling (15.578 s) : 15578000, 15578000
. : milestone, 15578000,
tracing (14.61 s) : 14610000, 14610000
. : milestone, 14610000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~1962e89aec, baseline=1.60.0-SNAPSHOT~d7515c8b3c
dateFormat X
axisFormat %s
section baseline
no_agent (1.482 ms) : 1471, 1494
. : milestone, 1482,
appsec (3.79 ms) : 3570, 4011
. : milestone, 3790,
iast (2.254 ms) : 2185, 2322
. : milestone, 2254,
iast_GLOBAL (2.293 ms) : 2224, 2362
. : milestone, 2293,
profiling (2.069 ms) : 2014, 2123
. : milestone, 2069,
tracing (2.078 ms) : 2024, 2131
. : milestone, 2078,
section candidate
no_agent (1.474 ms) : 1463, 1485
. : milestone, 1474,
appsec (2.579 ms) : 2522, 2637
. : milestone, 2579,
iast (2.255 ms) : 2186, 2323
. : milestone, 2255,
iast_GLOBAL (2.303 ms) : 2234, 2373
. : milestone, 2303,
profiling (2.098 ms) : 2042, 2153
. : milestone, 2098,
tracing (2.068 ms) : 2015, 2121
. : milestone, 2068,
|
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
This PR refines the service name source introduced with #10607 and refines even more the source when it comes from a configuration option.
In order to keep it as x-tracer as possible, the name of the source is
opt.<value>where<value>is the snake case version of the configuration option, stripping dd, dd.trace, etc.For this, we introduce a
ServiceNameSourcesconst holder class containing main sources as UTF8BytesString.Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.