Workaround for latest maven-failsafe-plugin test#10659
Open
daniel-mohedano wants to merge 3 commits intomasterfrom
Open
Workaround for latest maven-failsafe-plugin test#10659daniel-mohedano wants to merge 3 commits intomasterfrom
daniel-mohedano wants to merge 3 commits intomasterfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 10 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~6fe1b50a7c, baseline=1.60.0-SNAPSHOT~a249dd3265
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.07 s) : 0, 1070446
Total [baseline] (10.957 s) : 0, 10956749
Agent [candidate] (1.066 s) : 0, 1066035
Total [candidate] (10.859 s) : 0, 10858559
section appsec
Agent [baseline] (1.24 s) : 0, 1240377
Total [baseline] (11.042 s) : 0, 11042126
Agent [candidate] (1.249 s) : 0, 1249388
Total [candidate] (11.086 s) : 0, 11085937
section iast
Agent [baseline] (1.235 s) : 0, 1235486
Total [baseline] (11.277 s) : 0, 11276985
Agent [candidate] (1.237 s) : 0, 1236838
Total [candidate] (11.366 s) : 0, 11366355
section profiling
Agent [baseline] (1.203 s) : 0, 1202937
Total [baseline] (11.041 s) : 0, 11041415
Agent [candidate] (1.19 s) : 0, 1190041
Total [candidate] (11.019 s) : 0, 11018758
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~6fe1b50a7c, baseline=1.60.0-SNAPSHOT~a249dd3265
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.216 ms) : 0, 1216
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (628.828 ms) : 0, 628828
BytebuddyAgent [candidate] (627.717 ms) : 0, 627717
AgentMeter [baseline] (29.111 ms) : 0, 29111
AgentMeter [candidate] (29.087 ms) : 0, 29087
GlobalTracer [baseline] (259.448 ms) : 0, 259448
GlobalTracer [candidate] (257.811 ms) : 0, 257811
AppSec [baseline] (33.307 ms) : 0, 33307
AppSec [candidate] (32.782 ms) : 0, 32782
Debugger [baseline] (65.056 ms) : 0, 65056
Debugger [candidate] (65.698 ms) : 0, 65698
Remote Config [baseline] (635.116 µs) : 0, 635
Remote Config [candidate] (618.983 µs) : 0, 619
Telemetry [baseline] (11.426 ms) : 0, 11426
Telemetry [candidate] (10.583 ms) : 0, 10583
Flare Poller [baseline] (5.314 ms) : 0, 5314
Flare Poller [candidate] (4.504 ms) : 0, 4504
section appsec
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.218 ms) : 0, 1218
BytebuddyAgent [baseline] (659.353 ms) : 0, 659353
BytebuddyAgent [candidate] (663.91 ms) : 0, 663910
AgentMeter [baseline] (11.955 ms) : 0, 11955
AgentMeter [candidate] (12.058 ms) : 0, 12058
GlobalTracer [baseline] (258.189 ms) : 0, 258189
GlobalTracer [candidate] (260.097 ms) : 0, 260097
IAST [baseline] (25.489 ms) : 0, 25489
IAST [candidate] (25.729 ms) : 0, 25729
AppSec [baseline] (168.182 ms) : 0, 168182
AppSec [candidate] (169.175 ms) : 0, 169175
Debugger [baseline] (66.329 ms) : 0, 66329
Debugger [candidate] (67.293 ms) : 0, 67293
Remote Config [baseline] (648.672 µs) : 0, 649
Remote Config [candidate] (656.179 µs) : 0, 656
Telemetry [baseline] (9.294 ms) : 0, 9294
Telemetry [candidate] (9.416 ms) : 0, 9416
Flare Poller [baseline] (3.653 ms) : 0, 3653
Flare Poller [candidate] (3.654 ms) : 0, 3654
section iast
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.218 ms) : 0, 1218
BytebuddyAgent [baseline] (797.63 ms) : 0, 797630
BytebuddyAgent [candidate] (799.84 ms) : 0, 799840
AgentMeter [baseline] (11.322 ms) : 0, 11322
AgentMeter [candidate] (11.314 ms) : 0, 11314
GlobalTracer [baseline] (248.538 ms) : 0, 248538
GlobalTracer [candidate] (247.605 ms) : 0, 247605
IAST [baseline] (27.169 ms) : 0, 27169
IAST [candidate] (27.015 ms) : 0, 27015
AppSec [baseline] (33.172 ms) : 0, 33172
AppSec [candidate] (34.818 ms) : 0, 34818
Debugger [baseline] (67.676 ms) : 0, 67676
Debugger [candidate] (65.941 ms) : 0, 65941
Remote Config [baseline] (543.217 µs) : 0, 543
Remote Config [candidate] (543.481 µs) : 0, 543
Telemetry [baseline] (8.698 ms) : 0, 8698
Telemetry [candidate] (8.751 ms) : 0, 8751
Flare Poller [baseline] (3.48 ms) : 0, 3480
Flare Poller [candidate] (3.59 ms) : 0, 3590
section profiling
crashtracking [baseline] (1.202 ms) : 0, 1202
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (688.309 ms) : 0, 688309
BytebuddyAgent [candidate] (680.982 ms) : 0, 680982
AgentMeter [baseline] (8.695 ms) : 0, 8695
AgentMeter [candidate] (8.529 ms) : 0, 8529
GlobalTracer [baseline] (217.831 ms) : 0, 217831
GlobalTracer [candidate] (215.747 ms) : 0, 215747
AppSec [baseline] (33.04 ms) : 0, 33040
AppSec [candidate] (32.439 ms) : 0, 32439
Debugger [baseline] (68.128 ms) : 0, 68128
Debugger [candidate] (67.298 ms) : 0, 67298
Remote Config [baseline] (661.246 µs) : 0, 661
Remote Config [candidate] (632.561 µs) : 0, 633
Telemetry [baseline] (9.209 ms) : 0, 9209
Telemetry [candidate] (9.041 ms) : 0, 9041
Flare Poller [baseline] (3.821 ms) : 0, 3821
Flare Poller [candidate] (3.721 ms) : 0, 3721
ProfilingAgent [baseline] (100.782 ms) : 0, 100782
ProfilingAgent [candidate] (99.81 ms) : 0, 99810
Profiling [baseline] (101.374 ms) : 0, 101374
Profiling [candidate] (100.372 ms) : 0, 100372
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~6fe1b50a7c, baseline=1.60.0-SNAPSHOT~a249dd3265
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1060393
Total [baseline] (8.738 s) : 0, 8737805
Agent [candidate] (1.07 s) : 0, 1069821
Total [candidate] (8.784 s) : 0, 8784297
section iast
Agent [baseline] (1.233 s) : 0, 1232696
Total [baseline] (9.397 s) : 0, 9396671
Agent [candidate] (1.235 s) : 0, 1235029
Total [candidate] (9.4 s) : 0, 9399754
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~6fe1b50a7c, baseline=1.60.0-SNAPSHOT~a249dd3265
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.203 ms) : 0, 1203
BytebuddyAgent [baseline] (625.211 ms) : 0, 625211
BytebuddyAgent [candidate] (631.851 ms) : 0, 631851
AgentMeter [baseline] (29.013 ms) : 0, 29013
AgentMeter [candidate] (29.046 ms) : 0, 29046
GlobalTracer [baseline] (256.658 ms) : 0, 256658
GlobalTracer [candidate] (257.735 ms) : 0, 257735
AppSec [baseline] (32.766 ms) : 0, 32766
AppSec [candidate] (32.906 ms) : 0, 32906
Debugger [baseline] (63.449 ms) : 0, 63449
Debugger [candidate] (65.043 ms) : 0, 65043
Remote Config [baseline] (614.479 µs) : 0, 614
Remote Config [candidate] (609.552 µs) : 0, 610
Telemetry [baseline] (9.883 ms) : 0, 9883
Telemetry [candidate] (9.063 ms) : 0, 9063
Flare Poller [baseline] (5.336 ms) : 0, 5336
Flare Poller [candidate] (6.087 ms) : 0, 6087
section iast
crashtracking [baseline] (1.203 ms) : 0, 1203
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (796.689 ms) : 0, 796689
BytebuddyAgent [candidate] (797.529 ms) : 0, 797529
AgentMeter [baseline] (11.33 ms) : 0, 11330
AgentMeter [candidate] (11.372 ms) : 0, 11372
GlobalTracer [baseline] (247.998 ms) : 0, 247998
GlobalTracer [candidate] (248.889 ms) : 0, 248889
IAST [baseline] (27.076 ms) : 0, 27076
IAST [candidate] (27.277 ms) : 0, 27277
AppSec [baseline] (33.161 ms) : 0, 33161
AppSec [candidate] (34.209 ms) : 0, 34209
Debugger [baseline] (66.474 ms) : 0, 66474
Debugger [candidate] (65.714 ms) : 0, 65714
Remote Config [baseline] (535.431 µs) : 0, 535
Remote Config [candidate] (537.553 µs) : 0, 538
Telemetry [baseline] (8.643 ms) : 0, 8643
Telemetry [candidate] (8.656 ms) : 0, 8656
Flare Poller [baseline] (3.468 ms) : 0, 3468
Flare Poller [candidate] (3.507 ms) : 0, 3507
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 1 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~6fe1b50a7c, baseline=1.60.0-SNAPSHOT~a249dd3265
dateFormat X
axisFormat %s
section baseline
no_agent (1.286 ms) : 1273, 1298
. : milestone, 1286,
iast (3.362 ms) : 3321, 3403
. : milestone, 3362,
iast_FULL (6.274 ms) : 6209, 6338
. : milestone, 6274,
iast_GLOBAL (3.735 ms) : 3668, 3802
. : milestone, 3735,
profiling (2.53 ms) : 2503, 2557
. : milestone, 2530,
tracing (2.04 ms) : 2020, 2059
. : milestone, 2040,
section candidate
no_agent (1.295 ms) : 1283, 1308
. : milestone, 1295,
iast (3.444 ms) : 3397, 3491
. : milestone, 3444,
iast_FULL (6.398 ms) : 6330, 6466
. : milestone, 6398,
iast_GLOBAL (3.867 ms) : 3798, 3935
. : milestone, 3867,
profiling (2.551 ms) : 2524, 2578
. : milestone, 2551,
tracing (1.935 ms) : 1918, 1951
. : milestone, 1935,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~6fe1b50a7c, baseline=1.60.0-SNAPSHOT~a249dd3265
dateFormat X
axisFormat %s
section baseline
no_agent (19.521 ms) : 19318, 19723
. : milestone, 19521,
appsec (20.203 ms) : 19994, 20412
. : milestone, 20203,
code_origins (18.367 ms) : 18178, 18555
. : milestone, 18367,
iast (18.286 ms) : 18097, 18475
. : milestone, 18286,
profiling (19.215 ms) : 19022, 19408
. : milestone, 19215,
tracing (18.163 ms) : 17982, 18344
. : milestone, 18163,
section candidate
no_agent (18.849 ms) : 18651, 19046
. : milestone, 18849,
appsec (19.059 ms) : 18865, 19253
. : milestone, 19059,
code_origins (18.424 ms) : 18237, 18612
. : milestone, 18424,
iast (17.961 ms) : 17779, 18144
. : milestone, 17961,
profiling (19.176 ms) : 18982, 19370
. : milestone, 19176,
tracing (18.313 ms) : 18127, 18499
. : milestone, 18313,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~6fe1b50a7c, baseline=1.60.0-SNAPSHOT~a249dd3265
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (3.785 ms) : 3563, 4006
. : milestone, 3785,
iast (2.26 ms) : 2190, 2330
. : milestone, 2260,
iast_GLOBAL (2.308 ms) : 2237, 2378
. : milestone, 2308,
profiling (2.106 ms) : 2049, 2164
. : milestone, 2106,
tracing (2.07 ms) : 2016, 2124
. : milestone, 2070,
section candidate
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (3.808 ms) : 3585, 4031
. : milestone, 3808,
iast (2.26 ms) : 2190, 2330
. : milestone, 2260,
iast_GLOBAL (2.31 ms) : 2239, 2380
. : milestone, 2310,
profiling (2.116 ms) : 2059, 2174
. : milestone, 2116,
tracing (2.083 ms) : 2028, 2138
. : milestone, 2083,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~6fe1b50a7c, baseline=1.60.0-SNAPSHOT~a249dd3265
dateFormat X
axisFormat %s
section baseline
no_agent (14.853 s) : 14853000, 14853000
. : milestone, 14853000,
appsec (14.946 s) : 14946000, 14946000
. : milestone, 14946000,
iast (18.337 s) : 18337000, 18337000
. : milestone, 18337000,
iast_GLOBAL (17.682 s) : 17682000, 17682000
. : milestone, 17682000,
profiling (14.864 s) : 14864000, 14864000
. : milestone, 14864000,
tracing (15.106 s) : 15106000, 15106000
. : milestone, 15106000,
section candidate
no_agent (14.841 s) : 14841000, 14841000
. : milestone, 14841000,
appsec (14.891 s) : 14891000, 14891000
. : milestone, 14891000,
iast (18.611 s) : 18611000, 18611000
. : milestone, 18611000,
iast_GLOBAL (17.896 s) : 17896000, 17896000
. : milestone, 17896000,
profiling (14.96 s) : 14960000, 14960000
. : milestone, 14960000,
tracing (14.495 s) : 14495000, 14495000
. : milestone, 14495000,
|
nikita-tkachenko-datadog
approved these changes
Feb 23, 2026
AlexeyKuznetsov-DD
approved these changes
Feb 23, 2026
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in Use ⏳ Processing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
MavenInstrumentationTest.test_maven_build_with_unit_and_integration_tests_generates_spansonlatestDepTestby initializing the MDC context map withMDC.put()on test setup.Motivation
The
latestDepTestfortest_maven_build_with_unit_and_integration_tests_generates_spansstarted failing after the 3.5.5 release with:The new release added MDC context propagation in apache/maven-surefire#3241 to
ThreadedStreamConsumer$Pumperby capturing MDC context map on parent thread and setting it in daemon threads.This causes an NPE with
logback-classicwhenLogbackMDCAdapter.getCopyOfContextMap()returnsnulland is later set withLogbackMDCAdapter.setContextMap(null)(https://jira.qos.ch/browse/LOGBACK-944). When there is noslf4jbinding it defaults to aNOPMDCAdapter, which doesn't trigger the NPE. For the instrumentation tests, the Logback adapter seems to be active due toMavenCli.doMain()being used and Logback being available in the host JVM's classloader. The issue was also fixed in Logback in 1.4.2, but we are limited to1.2.13due to Java 8 compatibility.Additional Notes
test-environment-trigger: skip
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.