Refactored smoke tests to start agent before smock application started to reduce potential flakiness.#10662
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomasterfrom Feb 23, 2026
Conversation
…d to reduce potential flakiness.
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 64 metrics, 6 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~d3fe671c8a, baseline=1.60.0-SNAPSHOT~2ec3a87e2d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1060217
Total [baseline] (8.753 s) : 0, 8752904
Agent [candidate] (1.063 s) : 0, 1063265
Total [candidate] (8.735 s) : 0, 8735178
section iast
Agent [baseline] (1.234 s) : 0, 1234005
Total [baseline] (9.4 s) : 0, 9400266
Agent [candidate] (1.231 s) : 0, 1231290
Total [candidate] (9.356 s) : 0, 9356048
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~d3fe671c8a, baseline=1.60.0-SNAPSHOT~2ec3a87e2d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.201 ms) : 0, 1201
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (625.959 ms) : 0, 625959
BytebuddyAgent [candidate] (626.604 ms) : 0, 626604
AgentMeter [baseline] (28.983 ms) : 0, 28983
AgentMeter [candidate] (28.968 ms) : 0, 28968
GlobalTracer [baseline] (257.412 ms) : 0, 257412
GlobalTracer [candidate] (257.303 ms) : 0, 257303
AppSec [baseline] (32.61 ms) : 0, 32610
AppSec [candidate] (32.795 ms) : 0, 32795
Debugger [baseline] (62.142 ms) : 0, 62142
Debugger [candidate] (66.939 ms) : 0, 66939
Remote Config [baseline] (617.371 µs) : 0, 617
Remote Config [candidate] (613.623 µs) : 0, 614
Telemetry [baseline] (11.438 ms) : 0, 11438
Telemetry [candidate] (9.041 ms) : 0, 9041
Flare Poller [baseline] (3.685 ms) : 0, 3685
Flare Poller [candidate] (3.73 ms) : 0, 3730
section iast
crashtracking [baseline] (1.202 ms) : 0, 1202
crashtracking [candidate] (1.219 ms) : 0, 1219
BytebuddyAgent [baseline] (796.759 ms) : 0, 796759
BytebuddyAgent [candidate] (796.107 ms) : 0, 796107
AgentMeter [baseline] (11.375 ms) : 0, 11375
AgentMeter [candidate] (11.321 ms) : 0, 11321
GlobalTracer [baseline] (248.616 ms) : 0, 248616
GlobalTracer [candidate] (247.953 ms) : 0, 247953
IAST [baseline] (27.188 ms) : 0, 27188
IAST [candidate] (26.919 ms) : 0, 26919
AppSec [baseline] (35.897 ms) : 0, 35897
AppSec [candidate] (35.425 ms) : 0, 35425
Debugger [baseline] (64.134 ms) : 0, 64134
Debugger [candidate] (63.54 ms) : 0, 63540
Remote Config [baseline] (546.847 µs) : 0, 547
Remote Config [candidate] (533.653 µs) : 0, 534
Telemetry [baseline] (8.712 ms) : 0, 8712
Telemetry [candidate] (8.677 ms) : 0, 8677
Flare Poller [baseline] (3.478 ms) : 0, 3478
Flare Poller [candidate] (3.532 ms) : 0, 3532
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~d3fe671c8a, baseline=1.60.0-SNAPSHOT~2ec3a87e2d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1063013
Total [baseline] (10.76 s) : 0, 10760308
Agent [candidate] (1.071 s) : 0, 1070540
Total [candidate] (10.973 s) : 0, 10972757
section appsec
Agent [baseline] (1.237 s) : 0, 1237420
Total [baseline] (10.97 s) : 0, 10970004
Agent [candidate] (1.237 s) : 0, 1237094
Total [candidate] (10.983 s) : 0, 10982972
section iast
Agent [baseline] (1.236 s) : 0, 1236139
Total [baseline] (11.233 s) : 0, 11232550
Agent [candidate] (1.231 s) : 0, 1231459
Total [candidate] (11.189 s) : 0, 11189285
section profiling
Agent [baseline] (1.193 s) : 0, 1193469
Total [baseline] (10.928 s) : 0, 10927733
Agent [candidate] (1.193 s) : 0, 1192831
Total [candidate] (11.016 s) : 0, 11015721
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~d3fe671c8a, baseline=1.60.0-SNAPSHOT~2ec3a87e2d
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.21 ms) : 0, 1210
BytebuddyAgent [baseline] (626.385 ms) : 0, 626385
BytebuddyAgent [candidate] (631.301 ms) : 0, 631301
AgentMeter [baseline] (29.062 ms) : 0, 29062
AgentMeter [candidate] (29.155 ms) : 0, 29155
GlobalTracer [baseline] (257.217 ms) : 0, 257217
GlobalTracer [candidate] (258.585 ms) : 0, 258585
AppSec [baseline] (32.937 ms) : 0, 32937
AppSec [candidate] (33.11 ms) : 0, 33110
Debugger [baseline] (64.438 ms) : 0, 64438
Debugger [candidate] (65.037 ms) : 0, 65037
Remote Config [baseline] (623.427 µs) : 0, 623
Remote Config [candidate] (624.06 µs) : 0, 624
Telemetry [baseline] (9.961 ms) : 0, 9961
Telemetry [candidate] (10.765 ms) : 0, 10765
Flare Poller [baseline] (5.22 ms) : 0, 5220
Flare Poller [candidate] (4.575 ms) : 0, 4575
section appsec
crashtracking [baseline] (1.206 ms) : 0, 1206
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (656.057 ms) : 0, 656057
BytebuddyAgent [candidate] (656.795 ms) : 0, 656795
AgentMeter [baseline] (11.954 ms) : 0, 11954
AgentMeter [candidate] (11.909 ms) : 0, 11909
GlobalTracer [baseline] (257.942 ms) : 0, 257942
GlobalTracer [candidate] (258.055 ms) : 0, 258055
AppSec [baseline] (169.301 ms) : 0, 169301
AppSec [candidate] (167.737 ms) : 0, 167737
Debugger [baseline] (65.752 ms) : 0, 65752
Debugger [candidate] (66.282 ms) : 0, 66282
Remote Config [baseline] (657.779 µs) : 0, 658
Remote Config [candidate] (636.96 µs) : 0, 637
Telemetry [baseline] (9.494 ms) : 0, 9494
Telemetry [candidate] (9.383 ms) : 0, 9383
Flare Poller [baseline] (3.636 ms) : 0, 3636
Flare Poller [candidate] (3.626 ms) : 0, 3626
IAST [baseline] (25.354 ms) : 0, 25354
IAST [candidate] (25.433 ms) : 0, 25433
section iast
crashtracking [baseline] (1.226 ms) : 0, 1226
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (799.526 ms) : 0, 799526
BytebuddyAgent [candidate] (795.722 ms) : 0, 795722
AgentMeter [baseline] (11.285 ms) : 0, 11285
AgentMeter [candidate] (11.272 ms) : 0, 11272
GlobalTracer [baseline] (247.588 ms) : 0, 247588
GlobalTracer [candidate] (247.379 ms) : 0, 247379
AppSec [baseline] (34.972 ms) : 0, 34972
AppSec [candidate] (34.715 ms) : 0, 34715
Debugger [baseline] (65.525 ms) : 0, 65525
Debugger [candidate] (65.479 ms) : 0, 65479
Remote Config [baseline] (535.782 µs) : 0, 536
Remote Config [candidate] (536.35 µs) : 0, 536
Telemetry [baseline] (8.718 ms) : 0, 8718
Telemetry [candidate] (8.683 ms) : 0, 8683
Flare Poller [baseline] (3.495 ms) : 0, 3495
Flare Poller [candidate] (3.448 ms) : 0, 3448
IAST [baseline] (27.089 ms) : 0, 27089
IAST [candidate] (27.004 ms) : 0, 27004
section profiling
ProfilingAgent [baseline] (99.882 ms) : 0, 99882
ProfilingAgent [candidate] (99.563 ms) : 0, 99563
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (683.518 ms) : 0, 683518
BytebuddyAgent [candidate] (683.232 ms) : 0, 683232
AgentMeter [baseline] (8.584 ms) : 0, 8584
AgentMeter [candidate] (8.597 ms) : 0, 8597
GlobalTracer [baseline] (216.433 ms) : 0, 216433
GlobalTracer [candidate] (216.451 ms) : 0, 216451
AppSec [baseline] (32.53 ms) : 0, 32530
AppSec [candidate] (32.422 ms) : 0, 32422
Debugger [baseline] (67.028 ms) : 0, 67028
Debugger [candidate] (67.114 ms) : 0, 67114
Remote Config [baseline] (628.48 µs) : 0, 628
Remote Config [candidate] (628.417 µs) : 0, 628
Telemetry [baseline] (9.059 ms) : 0, 9059
Telemetry [candidate] (8.995 ms) : 0, 8995
Flare Poller [baseline] (3.765 ms) : 0, 3765
Flare Poller [candidate] (3.782 ms) : 0, 3782
Profiling [baseline] (100.454 ms) : 0, 100454
Profiling [candidate] (100.152 ms) : 0, 100152
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 3 performance regressions! Performance is the same for 13 metrics, 18 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~d3fe671c8a, baseline=1.60.0-SNAPSHOT~2ec3a87e2d
dateFormat X
axisFormat %s
section baseline
no_agent (1.208 ms) : 1197, 1219
. : milestone, 1208,
iast (3.128 ms) : 3084, 3171
. : milestone, 3128,
iast_FULL (5.813 ms) : 5754, 5871
. : milestone, 5813,
iast_GLOBAL (3.589 ms) : 3528, 3649
. : milestone, 3589,
profiling (2.225 ms) : 2203, 2246
. : milestone, 2225,
tracing (1.76 ms) : 1745, 1774
. : milestone, 1760,
section candidate
no_agent (1.178 ms) : 1167, 1190
. : milestone, 1178,
iast (3.246 ms) : 3207, 3284
. : milestone, 3246,
iast_FULL (5.858 ms) : 5798, 5917
. : milestone, 5858,
iast_GLOBAL (3.35 ms) : 3298, 3402
. : milestone, 3350,
profiling (2.14 ms) : 2121, 2158
. : milestone, 2140,
tracing (1.768 ms) : 1753, 1782
. : milestone, 1768,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~d3fe671c8a, baseline=1.60.0-SNAPSHOT~2ec3a87e2d
dateFormat X
axisFormat %s
section baseline
no_agent (18.145 ms) : 17958, 18333
. : milestone, 18145,
appsec (18.931 ms) : 18736, 19126
. : milestone, 18931,
code_origins (17.769 ms) : 17592, 17946
. : milestone, 17769,
iast (17.692 ms) : 17516, 17868
. : milestone, 17692,
profiling (18.709 ms) : 18522, 18896
. : milestone, 18709,
tracing (17.476 ms) : 17302, 17651
. : milestone, 17476,
section candidate
no_agent (19.063 ms) : 18869, 19257
. : milestone, 19063,
appsec (19.65 ms) : 19446, 19854
. : milestone, 19650,
code_origins (17.502 ms) : 17327, 17677
. : milestone, 17502,
iast (17.66 ms) : 17485, 17835
. : milestone, 17660,
profiling (18.688 ms) : 18500, 18876
. : milestone, 18688,
tracing (18.588 ms) : 18395, 18781
. : milestone, 18588,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~d3fe671c8a, baseline=1.60.0-SNAPSHOT~2ec3a87e2d
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (3.771 ms) : 3550, 3992
. : milestone, 3771,
iast (2.251 ms) : 2182, 2320
. : milestone, 2251,
iast_GLOBAL (2.306 ms) : 2236, 2376
. : milestone, 2306,
profiling (2.085 ms) : 2030, 2140
. : milestone, 2085,
tracing (2.07 ms) : 2017, 2124
. : milestone, 2070,
section candidate
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (3.774 ms) : 3553, 3996
. : milestone, 3774,
iast (2.26 ms) : 2190, 2329
. : milestone, 2260,
iast_GLOBAL (2.305 ms) : 2236, 2375
. : milestone, 2305,
profiling (2.072 ms) : 2017, 2126
. : milestone, 2072,
tracing (2.067 ms) : 2013, 2120
. : milestone, 2067,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~d3fe671c8a, baseline=1.60.0-SNAPSHOT~2ec3a87e2d
dateFormat X
axisFormat %s
section baseline
no_agent (14.759 s) : 14759000, 14759000
. : milestone, 14759000,
appsec (14.755 s) : 14755000, 14755000
. : milestone, 14755000,
iast (18.525 s) : 18525000, 18525000
. : milestone, 18525000,
iast_GLOBAL (17.95 s) : 17950000, 17950000
. : milestone, 17950000,
profiling (14.537 s) : 14537000, 14537000
. : milestone, 14537000,
tracing (14.533 s) : 14533000, 14533000
. : milestone, 14533000,
section candidate
no_agent (15.282 s) : 15282000, 15282000
. : milestone, 15282000,
appsec (14.737 s) : 14737000, 14737000
. : milestone, 14737000,
iast (18.343 s) : 18343000, 18343000
. : milestone, 18343000,
iast_GLOBAL (18.112 s) : 18112000, 18112000
. : milestone, 18112000,
profiling (15.023 s) : 15023000, 15023000
. : milestone, 15023000,
tracing (14.653 s) : 14653000, 14653000
. : milestone, 14653000,
|
dougqh
approved these changes
Feb 23, 2026
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR moves the agent startup before the smock application is launched.
Previously, there was a potential race condition where the smock application could emit traces before the mock agent was fully initialized. As a result, some traces might not be captured, leading to flaky smoke tests.
By starting the agent earlier, we ensure it is ready to receive traces as soon as the application begins sending them.
Motivation
Reduce flakiness in smoke tests
Additional Notes
Initially, I considered placing this logic inside
beforeProcessBuilders()to better align with existing patterns. However, that approach would require all existing overrides ofbeforeProcessBuilders()to callsuper.beforeProcessBuilders(), increasing the scope of the change and introducing a risk of future omissions.To keep the change minimal and safer, I introduced
setupTracesConsumer()instead.Currently,
ProcessManagerhas only one subclass (AbstractSmokeTest), so this approach keeps the implementation simple without broad refactoring.