Skip to content

Conversation

@sezen-datadog
Copy link
Contributor

@sezen-datadog sezen-datadog commented Sep 17, 2025

What Does This Do

Adds the new http.endpoint tag and modifies the cases where http.route is utilized accordingly

Motivation

Additional Notes

Contributor Checklist

Jira ticket: APPSEC-58611

@github-actions
Copy link
Contributor

Hi! 👋 Looks like you updated a Git Submodule.
If this was not intentional please make sure to:

@sezen-datadog sezen-datadog force-pushed the sezen.leblay/apm-metrics-tag branch from 746bf88 to b3676e3 Compare September 17, 2025 10:30
@github-actions
Copy link
Contributor

Hi! 👋 Looks like you updated a Git Submodule.
If this was not intentional please make sure to:

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Sep 17, 2025

🎯 Code Coverage
Patch Coverage: 70.27%
Total Coverage: 59.61% (-0.20%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f10792d | Docs | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Sep 17, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master sezen.leblay/apm-metrics-tag
git_commit_date 1760465547 1760471202
git_commit_sha 47f955b f10792d
release_version 1.55.0-SNAPSHOT~47f955b5dc 1.54.0-SNAPSHOT~f10792d75b
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1760472987 1760472987
ci_job_id 1179107237 1179107237
ci_pipeline_id 79293055 79293055
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-uwwcb9q6 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-uwwcb9q6 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics.

Startup time reports for petclinic
gantt
    title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~f10792d75b, baseline=1.55.0-SNAPSHOT~47f955b5dc

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.016 s) : 0, 1016188
Total [baseline] (10.615 s) : 0, 10615069
Agent [candidate] (1.015 s) : 0, 1014710
Total [candidate] (10.668 s) : 0, 10667677
section appsec
Agent [baseline] (1.194 s) : 0, 1193540
Total [baseline] (11.031 s) : 0, 11031434
Agent [candidate] (1.195 s) : 0, 1194630
Total [candidate] (11.054 s) : 0, 11053514
section iast
Agent [baseline] (1.168 s) : 0, 1167731
Total [baseline] (11.113 s) : 0, 11112520
Agent [candidate] (1.162 s) : 0, 1162361
Total [candidate] (11.017 s) : 0, 11016507
section profiling
Agent [baseline] (1.167 s) : 0, 1167237
Total [baseline] (10.992 s) : 0, 10991760
Agent [candidate] (1.163 s) : 0, 1162728
Total [candidate] (11.059 s) : 0, 11059346
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.016 s -
Agent appsec 1.194 s 177.353 ms (17.5%)
Agent iast 1.168 s 151.543 ms (14.9%)
Agent profiling 1.167 s 151.05 ms (14.9%)
Total tracing 10.615 s -
Total appsec 11.031 s 416.365 ms (3.9%)
Total iast 11.113 s 497.451 ms (4.7%)
Total profiling 10.992 s 376.691 ms (3.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.015 s -
Agent appsec 1.195 s 179.92 ms (17.7%)
Agent iast 1.162 s 147.651 ms (14.6%)
Agent profiling 1.163 s 148.018 ms (14.6%)
Total tracing 10.668 s -
Total appsec 11.054 s 385.837 ms (3.6%)
Total iast 11.017 s 348.83 ms (3.3%)
Total profiling 11.059 s 391.669 ms (3.7%)
gantt
    title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~f10792d75b, baseline=1.55.0-SNAPSHOT~47f955b5dc

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.469 ms) : 0, 1469
crashtracking [candidate] (1.473 ms) : 0, 1473
BytebuddyAgent [baseline] (692.947 ms) : 0, 692947
BytebuddyAgent [candidate] (691.656 ms) : 0, 691656
GlobalTracer [baseline] (241.77 ms) : 0, 241770
GlobalTracer [candidate] (241.619 ms) : 0, 241619
AppSec [baseline] (32.371 ms) : 0, 32371
AppSec [candidate] (32.365 ms) : 0, 32365
Debugger [baseline] (6.358 ms) : 0, 6358
Debugger [candidate] (6.384 ms) : 0, 6384
Remote Config [baseline] (713.347 µs) : 0, 713
Remote Config [candidate] (693.558 µs) : 0, 694
Telemetry [baseline] (9.283 ms) : 0, 9283
Telemetry [candidate] (9.24 ms) : 0, 9240
Flare Poller [baseline] (10.082 ms) : 0, 10082
Flare Poller [candidate] (10.179 ms) : 0, 10179
section appsec
crashtracking [baseline] (1.482 ms) : 0, 1482
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (717.182 ms) : 0, 717182
BytebuddyAgent [candidate] (718.284 ms) : 0, 718284
GlobalTracer [baseline] (234.425 ms) : 0, 234425
GlobalTracer [candidate] (234.737 ms) : 0, 234737
AppSec [baseline] (175.396 ms) : 0, 175396
AppSec [candidate] (174.524 ms) : 0, 174524
Debugger [baseline] (6.138 ms) : 0, 6138
Debugger [candidate] (6.103 ms) : 0, 6103
Remote Config [baseline] (635.52 µs) : 0, 636
Remote Config [candidate] (627.03 µs) : 0, 627
Telemetry [baseline] (8.516 ms) : 0, 8516
Telemetry [candidate] (9.172 ms) : 0, 9172
Flare Poller [baseline] (3.954 ms) : 0, 3954
Flare Poller [candidate] (3.908 ms) : 0, 3908
IAST [baseline] (24.754 ms) : 0, 24754
IAST [candidate] (24.703 ms) : 0, 24703
section iast
crashtracking [baseline] (1.493 ms) : 0, 1493
crashtracking [candidate] (1.483 ms) : 0, 1483
BytebuddyAgent [baseline] (827.627 ms) : 0, 827627
BytebuddyAgent [candidate] (823.561 ms) : 0, 823561
GlobalTracer [baseline] (234.264 ms) : 0, 234264
GlobalTracer [candidate] (233.393 ms) : 0, 233393
AppSec [baseline] (35.543 ms) : 0, 35543
AppSec [candidate] (35.496 ms) : 0, 35496
Debugger [baseline] (6.203 ms) : 0, 6203
Debugger [candidate] (6.249 ms) : 0, 6249
Remote Config [baseline] (628.595 µs) : 0, 629
Remote Config [candidate] (623.919 µs) : 0, 624
Telemetry [baseline] (8.876 ms) : 0, 8876
Telemetry [candidate] (8.806 ms) : 0, 8806
Flare Poller [baseline] (4.319 ms) : 0, 4319
Flare Poller [candidate] (4.418 ms) : 0, 4418
IAST [baseline] (27.105 ms) : 0, 27105
IAST [candidate] (26.648 ms) : 0, 26648
section profiling
crashtracking [baseline] (1.453 ms) : 0, 1453
crashtracking [candidate] (1.441 ms) : 0, 1441
BytebuddyAgent [baseline] (724.418 ms) : 0, 724418
BytebuddyAgent [candidate] (721.272 ms) : 0, 721272
GlobalTracer [baseline] (218.792 ms) : 0, 218792
GlobalTracer [candidate] (217.769 ms) : 0, 217769
AppSec [baseline] (32.645 ms) : 0, 32645
AppSec [candidate] (32.29 ms) : 0, 32290
Debugger [baseline] (7.34 ms) : 0, 7340
Debugger [candidate] (6.479 ms) : 0, 6479
Remote Config [baseline] (747.64 µs) : 0, 748
Remote Config [candidate] (803.403 µs) : 0, 803
Telemetry [baseline] (15.567 ms) : 0, 15567
Telemetry [candidate] (16.124 ms) : 0, 16124
Flare Poller [baseline] (4.221 ms) : 0, 4221
Flare Poller [candidate] (4.184 ms) : 0, 4184
ProfilingAgent [baseline] (108.785 ms) : 0, 108785
ProfilingAgent [candidate] (109.322 ms) : 0, 109322
Profiling [baseline] (109.646 ms) : 0, 109646
Profiling [candidate] (110.311 ms) : 0, 110311
Loading
Startup time reports for insecure-bank
gantt
    title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~f10792d75b, baseline=1.55.0-SNAPSHOT~47f955b5dc

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.015 s) : 0, 1015213
Total [baseline] (8.66 s) : 0, 8660253
Agent [candidate] (1.016 s) : 0, 1016496
Total [candidate] (8.714 s) : 0, 8713690
section iast
Agent [baseline] (1.151 s) : 0, 1150504
Total [baseline] (9.309 s) : 0, 9308920
Agent [candidate] (1.16 s) : 0, 1159895
Total [candidate] (9.295 s) : 0, 9294955
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.015 s -
Agent iast 1.151 s 135.292 ms (13.3%)
Total tracing 8.66 s -
Total iast 9.309 s 648.667 ms (7.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.016 s -
Agent iast 1.16 s 143.399 ms (14.1%)
Total tracing 8.714 s -
Total iast 9.295 s 581.265 ms (6.7%)
gantt
    title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~f10792d75b, baseline=1.55.0-SNAPSHOT~47f955b5dc

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.477 ms) : 0, 1477
crashtracking [candidate] (1.468 ms) : 0, 1468
BytebuddyAgent [baseline] (694.069 ms) : 0, 694069
BytebuddyAgent [candidate] (693.258 ms) : 0, 693258
GlobalTracer [baseline] (241.781 ms) : 0, 241781
GlobalTracer [candidate] (241.77 ms) : 0, 241770
AppSec [baseline] (32.269 ms) : 0, 32269
AppSec [candidate] (32.365 ms) : 0, 32365
Debugger [baseline] (6.381 ms) : 0, 6381
Debugger [candidate] (6.42 ms) : 0, 6420
Remote Config [baseline] (713.485 µs) : 0, 713
Remote Config [candidate] (705.802 µs) : 0, 706
Telemetry [baseline] (9.41 ms) : 0, 9410
Telemetry [candidate] (9.208 ms) : 0, 9208
Flare Poller [baseline] (7.84 ms) : 0, 7840
Flare Poller [candidate] (10.146 ms) : 0, 10146
section iast
crashtracking [baseline] (1.486 ms) : 0, 1486
crashtracking [candidate] (1.512 ms) : 0, 1512
BytebuddyAgent [baseline] (814.404 ms) : 0, 814404
BytebuddyAgent [candidate] (821.951 ms) : 0, 821951
GlobalTracer [baseline] (231.555 ms) : 0, 231555
GlobalTracer [candidate] (232.793 ms) : 0, 232793
AppSec [baseline] (34.351 ms) : 0, 34351
AppSec [candidate] (35.619 ms) : 0, 35619
Debugger [baseline] (7.14 ms) : 0, 7140
Debugger [candidate] (6.168 ms) : 0, 6168
Remote Config [baseline] (624.792 µs) : 0, 625
Remote Config [candidate] (620.505 µs) : 0, 621
Telemetry [baseline] (8.705 ms) : 0, 8705
Telemetry [candidate] (8.793 ms) : 0, 8793
Flare Poller [baseline] (4.207 ms) : 0, 4207
Flare Poller [candidate] (4.246 ms) : 0, 4246
IAST [baseline] (26.549 ms) : 0, 26549
IAST [candidate] (26.6 ms) : 0, 26600
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master sezen.leblay/apm-metrics-tag
git_commit_date 1760465547 1760471202
git_commit_sha 47f955b f10792d
release_version 1.55.0-SNAPSHOT~47f955b5dc 1.54.0-SNAPSHOT~f10792d75b
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1760472656 1760472656
ci_job_id 1179107238 1179107238
ci_pipeline_id 79293055 79293055
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-wlxa8uds 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-wlxa8uds 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 5 performance improvements and 2 performance regressions! Performance is the same for 5 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:insecure-bank:tracing:high_load worse
[+516.352µs; +776.884µs] or [+6.548%; +9.852%]
unstable
[-119.202op/s; +31.077op/s] or [-20.292%; +5.290%]
8.532ms 543.375op/s 7.886ms 587.438op/s
scenario:load:insecure-bank:profiling:high_load better
[-760.514µs; -450.683µs] or [-8.082%; -4.789%]
unstable
[-34.991op/s; +101.741op/s] or [-7.093%; +20.624%]
8.804ms 526.688op/s 9.410ms 493.312op/s
scenario:load:insecure-bank:iast_GLOBAL:high_load better
[-853.523µs; -435.342µs] or [-7.627%; -3.890%]
unstable
[-29.695op/s; +79.945op/s] or [-7.147%; +19.241%]
10.547ms 440.625op/s 11.191ms 415.500op/s
scenario:load:insecure-bank:iast_FULL:high_load better
[-1.435ms; -0.831ms] or [-9.789%; -5.673%]
unstable
[-14.714op/s; +67.589op/s] or [-4.626%; +21.248%]
13.523ms 344.531op/s 14.656ms 318.094op/s
scenario:load:petclinic:appsec:high_load worse
[+1.549ms; +2.448ms] or [+3.294%; +5.208%]
unstable
[-10.848op/s; +2.648op/s] or [-10.896%; +2.660%]
49.010ms 95.463op/s 47.012ms 99.562op/s
scenario:load:petclinic:code_origins:high_load better
[-1.887ms; -1.106ms] or [-4.291%; -2.514%]
unstable
[-3.562op/s; +10.912op/s] or [-3.348%; +10.255%]
42.480ms 110.075op/s 43.976ms 106.400op/s
scenario:load:petclinic:no_agent:high_load better
[-1.548ms; -0.905ms] or [-4.140%; -2.422%]
unstable
[-4.372op/s; +12.722op/s] or [-3.495%; +10.170%]
36.158ms 129.275op/s 37.385ms 125.100op/s
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~f10792d75b, baseline=1.55.0-SNAPSHOT~47f955b5dc
    dateFormat X
    axisFormat %s
section baseline
no_agent (37.385 ms) : 37086, 37683
.   : milestone, 37385,
appsec (47.012 ms) : 46606, 47418
.   : milestone, 47012,
code_origins (43.976 ms) : 43599, 44353
.   : milestone, 43976,
iast (44.127 ms) : 43769, 44485
.   : milestone, 44127,
profiling (47.775 ms) : 47298, 48253
.   : milestone, 47775,
tracing (44.026 ms) : 43641, 44411
.   : milestone, 44026,
section candidate
no_agent (36.158 ms) : 35860, 36456
.   : milestone, 36158,
appsec (49.01 ms) : 48580, 49440
.   : milestone, 49010,
code_origins (42.48 ms) : 42131, 42829
.   : milestone, 42480,
iast (44.332 ms) : 43956, 44709
.   : milestone, 44332,
profiling (48.312 ms) : 47874, 48750
.   : milestone, 48312,
tracing (45.188 ms) : 44807, 45569
.   : milestone, 45188,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 37.385 ms [37.086 ms, 37.683 ms] -
appsec 47.012 ms [46.606 ms, 47.418 ms] 9.627 ms (25.8%)
code_origins 43.976 ms [43.599 ms, 44.353 ms] 6.592 ms (17.6%)
iast 44.127 ms [43.769 ms, 44.485 ms] 6.742 ms (18.0%)
profiling 47.775 ms [47.298 ms, 48.253 ms] 10.391 ms (27.8%)
tracing 44.026 ms [43.641 ms, 44.411 ms] 6.642 ms (17.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 36.158 ms [35.86 ms, 36.456 ms] -
appsec 49.01 ms [48.58 ms, 49.44 ms] 12.852 ms (35.5%)
code_origins 42.48 ms [42.131 ms, 42.829 ms] 6.322 ms (17.5%)
iast 44.332 ms [43.956 ms, 44.709 ms] 8.174 ms (22.6%)
profiling 48.312 ms [47.874 ms, 48.75 ms] 12.154 ms (33.6%)
tracing 45.188 ms [44.807 ms, 45.569 ms] 9.03 ms (25.0%)
Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~f10792d75b, baseline=1.55.0-SNAPSHOT~47f955b5dc
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.226 ms) : 4174, 4278
.   : milestone, 4226,
iast (9.278 ms) : 9115, 9440
.   : milestone, 9278,
iast_FULL (14.656 ms) : 14362, 14950
.   : milestone, 14656,
iast_GLOBAL (11.191 ms) : 10989, 11393
.   : milestone, 11191,
profiling (9.41 ms) : 9260, 9560
.   : milestone, 9410,
tracing (7.886 ms) : 7769, 8002
.   : milestone, 7886,
section candidate
no_agent (4.361 ms) : 4304, 4417
.   : milestone, 4361,
iast (9.6 ms) : 9438, 9761
.   : milestone, 9600,
iast_FULL (13.523 ms) : 13257, 13789
.   : milestone, 13523,
iast_GLOBAL (10.547 ms) : 10361, 10733
.   : milestone, 10547,
profiling (8.804 ms) : 8666, 8942
.   : milestone, 8804,
tracing (8.532 ms) : 8407, 8658
.   : milestone, 8532,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.226 ms [4.174 ms, 4.278 ms] -
iast 9.278 ms [9.115 ms, 9.44 ms] 5.052 ms (119.5%)
iast_FULL 14.656 ms [14.362 ms, 14.95 ms] 10.43 ms (246.8%)
iast_GLOBAL 11.191 ms [10.989 ms, 11.393 ms] 6.965 ms (164.8%)
profiling 9.41 ms [9.26 ms, 9.56 ms] 5.184 ms (122.7%)
tracing 7.886 ms [7.769 ms, 8.002 ms] 3.66 ms (86.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.361 ms [4.304 ms, 4.417 ms] -
iast 9.6 ms [9.438 ms, 9.761 ms] 5.239 ms (120.1%)
iast_FULL 13.523 ms [13.257 ms, 13.789 ms] 9.162 ms (210.1%)
iast_GLOBAL 10.547 ms [10.361 ms, 10.733 ms] 6.186 ms (141.9%)
profiling 8.804 ms [8.666 ms, 8.942 ms] 4.444 ms (101.9%)
tracing 8.532 ms [8.407 ms, 8.658 ms] 4.172 ms (95.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master sezen.leblay/apm-metrics-tag
git_commit_date 1760465547 1760471202
git_commit_sha 47f955b f10792d
release_version 1.55.0-SNAPSHOT~47f955b5dc 1.54.0-SNAPSHOT~f10792d75b
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1760473263 1760473263
ci_job_id 1179107239 1179107239
ci_pipeline_id 79293055 79293055
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-v358vyfe 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-v358vyfe 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:dacapo:tomcat:appsec better
[-1.460ms; -1.116ms] or [-38.800%; -29.661%]
2.474ms 3.762ms
Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~f10792d75b, baseline=1.55.0-SNAPSHOT~47f955b5dc
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.485 ms) : 1473, 1497
.   : milestone, 1485,
appsec (3.762 ms) : 3542, 3982
.   : milestone, 3762,
iast (2.219 ms) : 2156, 2283
.   : milestone, 2219,
iast_GLOBAL (2.268 ms) : 2204, 2332
.   : milestone, 2268,
profiling (2.089 ms) : 2036, 2141
.   : milestone, 2089,
tracing (2.037 ms) : 1988, 2087
.   : milestone, 2037,
section candidate
no_agent (1.482 ms) : 1470, 1494
.   : milestone, 1482,
appsec (2.474 ms) : 2424, 2525
.   : milestone, 2474,
iast (2.217 ms) : 2153, 2280
.   : milestone, 2217,
iast_GLOBAL (2.275 ms) : 2210, 2339
.   : milestone, 2275,
profiling (2.081 ms) : 2028, 2133
.   : milestone, 2081,
tracing (2.034 ms) : 1984, 2083
.   : milestone, 2034,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.485 ms [1.473 ms, 1.497 ms] -
appsec 3.762 ms [3.542 ms, 3.982 ms] 2.277 ms (153.4%)
iast 2.219 ms [2.156 ms, 2.283 ms] 734.237 µs (49.4%)
iast_GLOBAL 2.268 ms [2.204 ms, 2.332 ms] 783.439 µs (52.8%)
profiling 2.089 ms [2.036 ms, 2.141 ms] 603.667 µs (40.7%)
tracing 2.037 ms [1.988 ms, 2.087 ms] 552.163 µs (37.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.482 ms [1.47 ms, 1.494 ms] -
appsec 2.474 ms [2.424 ms, 2.525 ms] 992.351 µs (67.0%)
iast 2.217 ms [2.153 ms, 2.28 ms] 734.701 µs (49.6%)
iast_GLOBAL 2.275 ms [2.21 ms, 2.339 ms] 792.876 µs (53.5%)
profiling 2.081 ms [2.028 ms, 2.133 ms] 598.617 µs (40.4%)
tracing 2.034 ms [1.984 ms, 2.083 ms] 551.928 µs (37.2%)
Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~f10792d75b, baseline=1.55.0-SNAPSHOT~47f955b5dc
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.842 s) : 14842000, 14842000
.   : milestone, 14842000,
appsec (15.263 s) : 15263000, 15263000
.   : milestone, 15263000,
iast (18.242 s) : 18242000, 18242000
.   : milestone, 18242000,
iast_GLOBAL (18.032 s) : 18032000, 18032000
.   : milestone, 18032000,
profiling (15.163 s) : 15163000, 15163000
.   : milestone, 15163000,
tracing (15.214 s) : 15214000, 15214000
.   : milestone, 15214000,
section candidate
no_agent (15.509 s) : 15509000, 15509000
.   : milestone, 15509000,
appsec (15.047 s) : 15047000, 15047000
.   : milestone, 15047000,
iast (18.682 s) : 18682000, 18682000
.   : milestone, 18682000,
iast_GLOBAL (18.276 s) : 18276000, 18276000
.   : milestone, 18276000,
profiling (15.143 s) : 15143000, 15143000
.   : milestone, 15143000,
tracing (15.177 s) : 15177000, 15177000
.   : milestone, 15177000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.842 s [14.842 s, 14.842 s] -
appsec 15.263 s [15.263 s, 15.263 s] 421.0 ms (2.8%)
iast 18.242 s [18.242 s, 18.242 s] 3.4 s (22.9%)
iast_GLOBAL 18.032 s [18.032 s, 18.032 s] 3.19 s (21.5%)
profiling 15.163 s [15.163 s, 15.163 s] 321.0 ms (2.2%)
tracing 15.214 s [15.214 s, 15.214 s] 372.0 ms (2.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.509 s [15.509 s, 15.509 s] -
appsec 15.047 s [15.047 s, 15.047 s] -462.0 ms (-3.0%)
iast 18.682 s [18.682 s, 18.682 s] 3.173 s (20.5%)
iast_GLOBAL 18.276 s [18.276 s, 18.276 s] 2.767 s (17.8%)
profiling 15.143 s [15.143 s, 15.143 s] -366.0 ms (-2.4%)
tracing 15.177 s [15.177 s, 15.177 s] -332.0 ms (-2.1%)

@sezen-datadog sezen-datadog force-pushed the sezen.leblay/apm-metrics-tag branch from b3676e3 to 7b7ad49 Compare September 17, 2025 12:21
@github-actions
Copy link
Contributor

Hi! 👋 Looks like you updated a Git Submodule.
If this was not intentional please make sure to:

@sezen-datadog sezen-datadog force-pushed the sezen.leblay/apm-metrics-tag branch from 7b7ad49 to f0b3d92 Compare September 17, 2025 12:29
@github-actions
Copy link
Contributor

Hi! 👋 Looks like you updated a Git Submodule.
If this was not intentional please make sure to:

1 similar comment
@github-actions
Copy link
Contributor

Hi! 👋 Looks like you updated a Git Submodule.
If this was not intentional please make sure to:

@sezen-datadog sezen-datadog force-pushed the sezen.leblay/apm-metrics-tag branch from 7506773 to c4dcdb5 Compare September 19, 2025 08:00
@github-actions
Copy link
Contributor

Hi! 👋 Looks like you updated a Git Submodule.
If this was not intentional please make sure to:

Signed-off-by: sezen.leblay <sezen.leblay@datadoghq.com>
@sezen-datadog sezen-datadog force-pushed the sezen.leblay/apm-metrics-tag branch from c4dcdb5 to 5ff30b6 Compare September 19, 2025 08:19
@sezen-datadog sezen-datadog added type: enhancement Enhancements and improvements comp: metrics Metrics labels Oct 8, 2025
@sezen-datadog sezen-datadog marked this pull request as ready for review October 8, 2025 11:58
@sezen-datadog sezen-datadog requested review from a team as code owners October 8, 2025 11:58
@sezen-datadog sezen-datadog requested review from amarziali and mtoffl01 and removed request for a team October 8, 2025 11:58
Signed-off-by: sezen.leblay <sezen.leblay@datadoghq.com>
Copy link
Contributor

@amarziali amarziali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a first pass. There are some comments to address especially the one concerning the design. In particular, the tagging engine should be moved away from the metrics since concerning mostly the span (tracing). Moving to tagPostProcessor is a first step.
I will do another pass once the first set of comments are resolved

@sezen-datadog sezen-datadog force-pushed the sezen.leblay/apm-metrics-tag branch from eb38ab8 to b3ffd63 Compare October 9, 2025 11:55
Signed-off-by: sezen.leblay <sezen.leblay@datadoghq.com>
@sezen-datadog sezen-datadog force-pushed the sezen.leblay/apm-metrics-tag branch from b3ffd63 to 3f778ee Compare October 9, 2025 13:30
Signed-off-by: sezen.leblay <sezen.leblay@datadoghq.com>
Signed-off-by: sezen.leblay <sezen.leblay@datadoghq.com>
@sezen-datadog sezen-datadog enabled auto-merge (squash) October 10, 2025 09:23
@jandro996
Copy link
Member

🎯 Code Coverage• Patch Coverage: 68.99%• Total Coverage: 59.63% (-0.22%) View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 97ee9c3 | Docs | Was this helpful? Give us feedback!

Is it possible to increase this coverage with more tests? :)

Copy link
Contributor

@amarziali amarziali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left few more comments. Code wise: tag access in the postprocessor can be done directly using the provided map. Also, the postProcessor can just not be instantiated if not enabled in the config.
An important point about the bucket aggregation: the HTTP method is already available today as a tag and this can cause changes in the behaviour even when the feature is disabled. I recommend an additional guard on aggregating those two new fields

@sezen-datadog sezen-datadog force-pushed the sezen.leblay/apm-metrics-tag branch from 73f00c5 to 07f3244 Compare October 13, 2025 10:27
Signed-off-by: sezen.leblay <sezen.leblay@datadoghq.com>
@sezen-datadog sezen-datadog force-pushed the sezen.leblay/apm-metrics-tag branch from e570ee4 to a13e396 Compare October 13, 2025 11:44
Comment on lines +342 to +343
final CharSequence httpMethod = resourceRenamingEnabled ? span.getTag(HTTP_METHOD, "") : "";
final CharSequence httpEndpoint = resourceRenamingEnabled ? span.getTag(HTTP_ENDPOINT, "") : "";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: are they mandatory in the payload? if not they should be nullified here and not sent in the msgpack payload later on

Copy link
Contributor Author

@sezen-datadog sezen-datadog Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jandro996 can i let you guys take over please?

@mtoffl01 mtoffl01 removed their request for review November 7, 2025 16:28
Copy link
Contributor

@mtoffl01 mtoffl01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing from the Config side. I'm not following the distinction between "resource renaming" versus "resource renaming always simplified endpoint." Can you either link an RFC so I can understand it better, or provide documentation in the code?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: metrics Metrics type: enhancement Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants