-
Notifications
You must be signed in to change notification settings - Fork 323
Regroup jdk related instrumentations #9663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: 122cc85 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~122cc8558e, baseline=1.54.0-SNAPSHOT~20dac8a306
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.022 s) : 0, 1022327
Total [baseline] (8.669 s) : 0, 8668719
Agent [candidate] (1.021 s) : 0, 1021093
Total [candidate] (8.682 s) : 0, 8682399
section iast
Agent [baseline] (1.152 s) : 0, 1151837
Total [baseline] (9.248 s) : 0, 9247536
Agent [candidate] (1.149 s) : 0, 1149421
Total [candidate] (9.274 s) : 0, 9273799
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~122cc8558e, baseline=1.54.0-SNAPSHOT~20dac8a306
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (695.909 ms) : 0, 695909
BytebuddyAgent [candidate] (695.44 ms) : 0, 695440
GlobalTracer [baseline] (242.061 ms) : 0, 242061
GlobalTracer [candidate] (243.018 ms) : 0, 243018
AppSec [baseline] (33.274 ms) : 0, 33274
AppSec [candidate] (33.042 ms) : 0, 33042
Debugger [baseline] (6.498 ms) : 0, 6498
Debugger [candidate] (6.44 ms) : 0, 6440
Remote Config [baseline] (685.771 µs) : 0, 686
Remote Config [candidate] (691.093 µs) : 0, 691
Telemetry [baseline] (9.378 ms) : 0, 9378
Telemetry [candidate] (9.289 ms) : 0, 9289
Flare Poller [baseline] (11.927 ms) : 0, 11927
Flare Poller [candidate] (10.74 ms) : 0, 10740
section iast
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.456 ms) : 0, 1456
BytebuddyAgent [baseline] (815.015 ms) : 0, 815015
BytebuddyAgent [candidate] (813.87 ms) : 0, 813870
GlobalTracer [baseline] (232.228 ms) : 0, 232228
GlobalTracer [candidate] (231.762 ms) : 0, 231762
AppSec [baseline] (35.641 ms) : 0, 35641
AppSec [candidate] (35.018 ms) : 0, 35018
Debugger [baseline] (6.104 ms) : 0, 6104
Debugger [candidate] (6.113 ms) : 0, 6113
Remote Config [baseline] (613.027 µs) : 0, 613
Remote Config [candidate] (603.91 µs) : 0, 604
Telemetry [baseline] (8.523 ms) : 0, 8523
Telemetry [candidate] (8.711 ms) : 0, 8711
Flare Poller [baseline] (4.164 ms) : 0, 4164
Flare Poller [candidate] (4.211 ms) : 0, 4211
IAST [baseline] (26.856 ms) : 0, 26856
IAST [candidate] (26.545 ms) : 0, 26545
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~122cc8558e, baseline=1.54.0-SNAPSHOT~20dac8a306
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.026 s) : 0, 1026298
Total [baseline] (10.691 s) : 0, 10690618
Agent [candidate] (1.023 s) : 0, 1023411
Total [candidate] (10.784 s) : 0, 10783558
section appsec
Agent [baseline] (1.2 s) : 0, 1199936
Total [baseline] (10.997 s) : 0, 10997160
Agent [candidate] (1.199 s) : 0, 1199151
Total [candidate] (11.085 s) : 0, 11085319
section iast
Agent [baseline] (1.151 s) : 0, 1151423
Total [baseline] (10.902 s) : 0, 10902257
Agent [candidate] (1.152 s) : 0, 1151807
Total [candidate] (10.983 s) : 0, 10982563
section profiling
Agent [baseline] (1.162 s) : 0, 1162300
Total [baseline] (11.059 s) : 0, 11058636
Agent [candidate] (1.172 s) : 0, 1172088
Total [candidate] (11.029 s) : 0, 11028503
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~122cc8558e, baseline=1.54.0-SNAPSHOT~20dac8a306
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.476 ms) : 0, 1476
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (699.964 ms) : 0, 699964
BytebuddyAgent [candidate] (699.107 ms) : 0, 699107
GlobalTracer [baseline] (243.728 ms) : 0, 243728
GlobalTracer [candidate] (241.574 ms) : 0, 241574
AppSec [baseline] (32.972 ms) : 0, 32972
AppSec [candidate] (32.838 ms) : 0, 32838
Debugger [baseline] (6.494 ms) : 0, 6494
Debugger [candidate] (6.43 ms) : 0, 6430
Remote Config [baseline] (700.443 µs) : 0, 700
Remote Config [candidate] (680.508 µs) : 0, 681
Telemetry [baseline] (9.371 ms) : 0, 9371
Telemetry [candidate] (9.386 ms) : 0, 9386
Flare Poller [baseline] (10.423 ms) : 0, 10423
Flare Poller [candidate] (10.736 ms) : 0, 10736
section appsec
crashtracking [baseline] (1.472 ms) : 0, 1472
crashtracking [candidate] (1.474 ms) : 0, 1474
BytebuddyAgent [baseline] (721.121 ms) : 0, 721121
BytebuddyAgent [candidate] (721.85 ms) : 0, 721850
GlobalTracer [baseline] (235.622 ms) : 0, 235622
GlobalTracer [candidate] (235.125 ms) : 0, 235125
AppSec [baseline] (173.406 ms) : 0, 173406
AppSec [candidate] (175.559 ms) : 0, 175559
Debugger [baseline] (6.199 ms) : 0, 6199
Debugger [candidate] (6.126 ms) : 0, 6126
Remote Config [baseline] (652.138 µs) : 0, 652
Remote Config [candidate] (645.122 µs) : 0, 645
Telemetry [baseline] (10.23 ms) : 0, 10230
Telemetry [candidate] (8.406 ms) : 0, 8406
Flare Poller [baseline] (4.936 ms) : 0, 4936
Flare Poller [candidate] (3.938 ms) : 0, 3938
IAST [baseline] (25.166 ms) : 0, 25166
IAST [candidate] (24.884 ms) : 0, 24884
section iast
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (815.155 ms) : 0, 815155
BytebuddyAgent [candidate] (815.6 ms) : 0, 815600
GlobalTracer [baseline] (232.539 ms) : 0, 232539
GlobalTracer [candidate] (232.251 ms) : 0, 232251
AppSec [baseline] (35.07 ms) : 0, 35070
AppSec [candidate] (35.242 ms) : 0, 35242
Debugger [baseline] (6.019 ms) : 0, 6019
Debugger [candidate] (6.051 ms) : 0, 6051
Remote Config [baseline] (589.525 µs) : 0, 590
Remote Config [candidate] (597.707 µs) : 0, 598
Telemetry [baseline] (8.34 ms) : 0, 8340
Telemetry [candidate] (8.6 ms) : 0, 8600
Flare Poller [baseline] (4.168 ms) : 0, 4168
Flare Poller [candidate] (4.212 ms) : 0, 4212
IAST [baseline] (26.86 ms) : 0, 26860
IAST [candidate] (26.621 ms) : 0, 26621
section profiling
crashtracking [baseline] (1.426 ms) : 0, 1426
crashtracking [candidate] (1.432 ms) : 0, 1432
BytebuddyAgent [baseline] (722.02 ms) : 0, 722020
BytebuddyAgent [candidate] (728.03 ms) : 0, 728030
GlobalTracer [baseline] (217.922 ms) : 0, 217922
GlobalTracer [candidate] (219.186 ms) : 0, 219186
AppSec [baseline] (33.112 ms) : 0, 33112
AppSec [candidate] (33.526 ms) : 0, 33526
Debugger [baseline] (7.287 ms) : 0, 7287
Debugger [candidate] (7.259 ms) : 0, 7259
Remote Config [baseline] (698.726 µs) : 0, 699
Remote Config [candidate] (698.177 µs) : 0, 698
Telemetry [baseline] (15.869 ms) : 0, 15869
Telemetry [candidate] (15.64 ms) : 0, 15640
Flare Poller [baseline] (4.161 ms) : 0, 4161
Flare Poller [candidate] (4.287 ms) : 0, 4287
ProfilingAgent [baseline] (107.048 ms) : 0, 107048
ProfilingAgent [candidate] (108.281 ms) : 0, 108281
Profiling [baseline] (107.929 ms) : 0, 107929
Profiling [candidate] (109.682 ms) : 0, 109682
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 2 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~122cc8558e, baseline=1.54.0-SNAPSHOT~20dac8a306
dateFormat X
axisFormat %s
section baseline
no_agent (37.014 ms) : 36724, 37305
. : milestone, 37014,
appsec (48.506 ms) : 48083, 48929
. : milestone, 48506,
code_origins (44.315 ms) : 43935, 44694
. : milestone, 44315,
iast (45.682 ms) : 45287, 46078
. : milestone, 45682,
profiling (50.15 ms) : 49660, 50640
. : milestone, 50150,
tracing (44.871 ms) : 44479, 45262
. : milestone, 44871,
section candidate
no_agent (38.604 ms) : 38290, 38917
. : milestone, 38604,
appsec (48.482 ms) : 48046, 48918
. : milestone, 48482,
code_origins (44.419 ms) : 44036, 44802
. : milestone, 44419,
iast (44.615 ms) : 44224, 45007
. : milestone, 44615,
profiling (51.124 ms) : 50656, 51592
. : milestone, 51124,
tracing (44.58 ms) : 44197, 44963
. : milestone, 44580,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~122cc8558e, baseline=1.54.0-SNAPSHOT~20dac8a306
dateFormat X
axisFormat %s
section baseline
no_agent (4.424 ms) : 4366, 4481
. : milestone, 4424,
iast (9.876 ms) : 9712, 10041
. : milestone, 9876,
iast_FULL (14.297 ms) : 14008, 14586
. : milestone, 14297,
iast_GLOBAL (11.146 ms) : 10947, 11344
. : milestone, 11146,
profiling (8.753 ms) : 8619, 8888
. : milestone, 8753,
tracing (7.885 ms) : 7772, 7999
. : milestone, 7885,
section candidate
no_agent (4.443 ms) : 4393, 4494
. : milestone, 4443,
iast (10.039 ms) : 9871, 10207
. : milestone, 10039,
iast_FULL (14.049 ms) : 13766, 14332
. : milestone, 14049,
iast_GLOBAL (10.775 ms) : 10584, 10965
. : milestone, 10775,
profiling (9.192 ms) : 9048, 9336
. : milestone, 9192,
tracing (7.698 ms) : 7583, 7814
. : milestone, 7698,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~122cc8558e, baseline=1.54.0-SNAPSHOT~20dac8a306
dateFormat X
axisFormat %s
section baseline
no_agent (1.481 ms) : 1469, 1492
. : milestone, 1481,
appsec (3.746 ms) : 3529, 3963
. : milestone, 3746,
iast (2.223 ms) : 2159, 2287
. : milestone, 2223,
iast_GLOBAL (2.263 ms) : 2199, 2327
. : milestone, 2263,
profiling (2.078 ms) : 2025, 2130
. : milestone, 2078,
tracing (2.04 ms) : 1991, 2090
. : milestone, 2040,
section candidate
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (3.772 ms) : 3555, 3989
. : milestone, 3772,
iast (2.22 ms) : 2156, 2283
. : milestone, 2220,
iast_GLOBAL (2.261 ms) : 2197, 2325
. : milestone, 2261,
profiling (2.051 ms) : 2001, 2102
. : milestone, 2051,
tracing (2.032 ms) : 1983, 2081
. : milestone, 2032,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~122cc8558e, baseline=1.54.0-SNAPSHOT~20dac8a306
dateFormat X
axisFormat %s
section baseline
no_agent (15.579 s) : 15579000, 15579000
. : milestone, 15579000,
appsec (14.984 s) : 14984000, 14984000
. : milestone, 14984000,
iast (18.625 s) : 18625000, 18625000
. : milestone, 18625000,
iast_GLOBAL (17.962 s) : 17962000, 17962000
. : milestone, 17962000,
profiling (15.859 s) : 15859000, 15859000
. : milestone, 15859000,
tracing (15.0 s) : 15000000, 15000000
. : milestone, 15000000,
section candidate
no_agent (15.554 s) : 15554000, 15554000
. : milestone, 15554000,
appsec (15.134 s) : 15134000, 15134000
. : milestone, 15134000,
iast (18.578 s) : 18578000, 18578000
. : milestone, 18578000,
iast_GLOBAL (18.184 s) : 18184000, 18184000
. : milestone, 18184000,
profiling (15.484 s) : 15484000, 15484000
. : milestone, 15484000,
tracing (15.161 s) : 15161000, 15161000
. : milestone, 15161000,
|
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
02684ef to
1a9256b
Compare
1a9256b to
eaacced
Compare
manuel-alvarez-alvarez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What Does This Do
Refactor gradle modules of jdk related instrumentation under a big
javaumbrella.Notable changes:
Other profiling modules (wallclock, exception) will be moved later
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]