-
Notifications
You must be signed in to change notification settings - Fork 323
Tweak shadowJar/archive configurations #9732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PerfectSlayer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have limited knowledge about this part but so far, it looks good to me 👍
9dd58ad to
bb3eeb2
Compare
|
🎯 Code Coverage 🔗 Commit SHA: be4b392 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~be4b392616, baseline=1.55.0-SNAPSHOT~4985d55399
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.018 s) : 0, 1017988
Total [baseline] (10.741 s) : 0, 10740925
Agent [candidate] (1.015 s) : 0, 1015376
Total [candidate] (10.718 s) : 0, 10717663
section appsec
Agent [baseline] (1.203 s) : 0, 1203016
Total [baseline] (10.918 s) : 0, 10917785
Agent [candidate] (1.196 s) : 0, 1195553
Total [candidate] (10.849 s) : 0, 10848950
section iast
Agent [baseline] (1.156 s) : 0, 1155651
Total [baseline] (11.167 s) : 0, 11167069
Agent [candidate] (1.158 s) : 0, 1157501
Total [candidate] (11.095 s) : 0, 11095363
section profiling
Agent [baseline] (1.165 s) : 0, 1165312
Total [baseline] (10.925 s) : 0, 10925408
Agent [candidate] (1.169 s) : 0, 1169008
Total [candidate] (10.828 s) : 0, 10827618
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~be4b392616, baseline=1.55.0-SNAPSHOT~4985d55399
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.438 ms) : 0, 1438
BytebuddyAgent [baseline] (693.548 ms) : 0, 693548
BytebuddyAgent [candidate] (692.367 ms) : 0, 692367
GlobalTracer [baseline] (243.246 ms) : 0, 243246
GlobalTracer [candidate] (242.254 ms) : 0, 242254
AppSec [baseline] (32.196 ms) : 0, 32196
AppSec [candidate] (32.282 ms) : 0, 32282
Debugger [baseline] (6.279 ms) : 0, 6279
Debugger [candidate] (6.285 ms) : 0, 6285
Remote Config [baseline] (676.482 µs) : 0, 676
Remote Config [candidate] (677.294 µs) : 0, 677
Telemetry [baseline] (9.318 ms) : 0, 9318
Telemetry [candidate] (9.288 ms) : 0, 9288
Flare Poller [baseline] (10.132 ms) : 0, 10132
Flare Poller [candidate] (9.676 ms) : 0, 9676
section appsec
crashtracking [baseline] (1.476 ms) : 0, 1476
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (723.44 ms) : 0, 723440
BytebuddyAgent [candidate] (718.808 ms) : 0, 718808
GlobalTracer [baseline] (236.432 ms) : 0, 236432
GlobalTracer [candidate] (234.956 ms) : 0, 234956
AppSec [baseline] (175.879 ms) : 0, 175879
AppSec [candidate] (173.956 ms) : 0, 173956
Debugger [baseline] (6.142 ms) : 0, 6142
Debugger [candidate] (6.129 ms) : 0, 6129
Remote Config [baseline] (645.345 µs) : 0, 645
Remote Config [candidate] (629.044 µs) : 0, 629
Telemetry [baseline] (8.643 ms) : 0, 8643
Telemetry [candidate] (9.424 ms) : 0, 9424
Flare Poller [baseline] (3.886 ms) : 0, 3886
Flare Poller [candidate] (3.914 ms) : 0, 3914
IAST [baseline] (25.122 ms) : 0, 25122
IAST [candidate] (25.123 ms) : 0, 25123
section iast
crashtracking [baseline] (1.469 ms) : 0, 1469
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (817.907 ms) : 0, 817907
BytebuddyAgent [candidate] (819.985 ms) : 0, 819985
GlobalTracer [baseline] (232.458 ms) : 0, 232458
GlobalTracer [candidate] (232.636 ms) : 0, 232636
AppSec [baseline] (35.446 ms) : 0, 35446
AppSec [candidate] (35.216 ms) : 0, 35216
Debugger [baseline] (6.269 ms) : 0, 6269
Debugger [candidate] (6.137 ms) : 0, 6137
Remote Config [baseline] (608.733 µs) : 0, 609
Remote Config [candidate] (607.249 µs) : 0, 607
Telemetry [baseline] (8.851 ms) : 0, 8851
Telemetry [candidate] (8.745 ms) : 0, 8745
Flare Poller [baseline] (4.287 ms) : 0, 4287
Flare Poller [candidate] (4.213 ms) : 0, 4213
IAST [baseline] (26.87 ms) : 0, 26870
IAST [candidate] (26.99 ms) : 0, 26990
section profiling
ProfilingAgent [baseline] (109.838 ms) : 0, 109838
ProfilingAgent [candidate] (109.453 ms) : 0, 109453
crashtracking [baseline] (1.477 ms) : 0, 1477
crashtracking [candidate] (1.483 ms) : 0, 1483
BytebuddyAgent [baseline] (721.332 ms) : 0, 721332
BytebuddyAgent [candidate] (724.375 ms) : 0, 724375
GlobalTracer [baseline] (218.943 ms) : 0, 218943
GlobalTracer [candidate] (219.642 ms) : 0, 219642
AppSec [baseline] (32.29 ms) : 0, 32290
AppSec [candidate] (32.466 ms) : 0, 32466
Debugger [baseline] (6.737 ms) : 0, 6737
Debugger [candidate] (7.571 ms) : 0, 7571
Remote Config [baseline] (694.891 µs) : 0, 695
Remote Config [candidate] (688.638 µs) : 0, 689
Telemetry [baseline] (15.933 ms) : 0, 15933
Telemetry [candidate] (14.348 ms) : 0, 14348
Flare Poller [baseline] (4.258 ms) : 0, 4258
Flare Poller [candidate] (4.96 ms) : 0, 4960
Profiling [baseline] (110.449 ms) : 0, 110449
Profiling [candidate] (110.066 ms) : 0, 110066
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~be4b392616, baseline=1.55.0-SNAPSHOT~4985d55399
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.027 s) : 0, 1026511
Total [baseline] (8.707 s) : 0, 8707497
Agent [candidate] (1.017 s) : 0, 1017174
Total [candidate] (8.661 s) : 0, 8661333
section iast
Agent [baseline] (1.152 s) : 0, 1152017
Total [baseline] (9.315 s) : 0, 9315394
Agent [candidate] (1.159 s) : 0, 1159124
Total [candidate] (9.325 s) : 0, 9324738
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~be4b392616, baseline=1.55.0-SNAPSHOT~4985d55399
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.477 ms) : 0, 1477
crashtracking [candidate] (1.466 ms) : 0, 1466
BytebuddyAgent [baseline] (700.145 ms) : 0, 700145
BytebuddyAgent [candidate] (692.758 ms) : 0, 692758
GlobalTracer [baseline] (245.432 ms) : 0, 245432
GlobalTracer [candidate] (242.594 ms) : 0, 242594
AppSec [baseline] (32.911 ms) : 0, 32911
AppSec [candidate] (32.118 ms) : 0, 32118
Debugger [baseline] (6.427 ms) : 0, 6427
Debugger [candidate] (6.25 ms) : 0, 6250
Remote Config [baseline] (687.966 µs) : 0, 688
Remote Config [candidate] (675.171 µs) : 0, 675
Telemetry [baseline] (9.481 ms) : 0, 9481
Telemetry [candidate] (9.216 ms) : 0, 9216
Flare Poller [baseline] (8.683 ms) : 0, 8683
Flare Poller [candidate] (11.015 ms) : 0, 11015
section iast
crashtracking [baseline] (1.483 ms) : 0, 1483
crashtracking [candidate] (1.491 ms) : 0, 1491
BytebuddyAgent [baseline] (814.542 ms) : 0, 814542
BytebuddyAgent [candidate] (820.19 ms) : 0, 820190
GlobalTracer [baseline] (232.24 ms) : 0, 232240
GlobalTracer [candidate] (233.382 ms) : 0, 233382
AppSec [baseline] (35.359 ms) : 0, 35359
AppSec [candidate] (35.491 ms) : 0, 35491
Debugger [baseline] (6.234 ms) : 0, 6234
Debugger [candidate] (6.21 ms) : 0, 6210
Remote Config [baseline] (632.216 µs) : 0, 632
Remote Config [candidate] (605.061 µs) : 0, 605
Telemetry [baseline] (8.821 ms) : 0, 8821
Telemetry [candidate] (8.824 ms) : 0, 8824
Flare Poller [baseline] (4.286 ms) : 0, 4286
Flare Poller [candidate] (4.322 ms) : 0, 4322
IAST [baseline] (26.936 ms) : 0, 26936
IAST [candidate] (27.133 ms) : 0, 27133
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 4 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~be4b392616, baseline=1.55.0-SNAPSHOT~4985d55399
dateFormat X
axisFormat %s
section baseline
no_agent (37.222 ms) : 36926, 37518
. : milestone, 37222,
appsec (48.735 ms) : 48321, 49150
. : milestone, 48735,
code_origins (42.623 ms) : 42265, 42981
. : milestone, 42623,
iast (46.166 ms) : 45775, 46556
. : milestone, 46166,
profiling (48.187 ms) : 47751, 48623
. : milestone, 48187,
tracing (43.498 ms) : 43118, 43877
. : milestone, 43498,
section candidate
no_agent (37.099 ms) : 36800, 37398
. : milestone, 37099,
appsec (47.88 ms) : 47462, 48298
. : milestone, 47880,
code_origins (44.775 ms) : 44381, 45169
. : milestone, 44775,
iast (44.893 ms) : 44496, 45289
. : milestone, 44893,
profiling (50.051 ms) : 49551, 50552
. : milestone, 50051,
tracing (43.469 ms) : 43096, 43843
. : milestone, 43469,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~be4b392616, baseline=1.55.0-SNAPSHOT~4985d55399
dateFormat X
axisFormat %s
section baseline
no_agent (4.536 ms) : 4484, 4587
. : milestone, 4536,
iast (9.706 ms) : 9544, 9867
. : milestone, 9706,
iast_FULL (13.583 ms) : 13317, 13850
. : milestone, 13583,
iast_GLOBAL (11.166 ms) : 10964, 11369
. : milestone, 11166,
profiling (8.878 ms) : 8735, 9020
. : milestone, 8878,
tracing (7.855 ms) : 7742, 7969
. : milestone, 7855,
section candidate
no_agent (4.495 ms) : 4444, 4546
. : milestone, 4495,
iast (10.399 ms) : 10223, 10575
. : milestone, 10399,
iast_FULL (14.579 ms) : 14286, 14873
. : milestone, 14579,
iast_GLOBAL (11.401 ms) : 11193, 11608
. : milestone, 11401,
profiling (8.953 ms) : 8806, 9101
. : milestone, 8953,
tracing (7.636 ms) : 7522, 7751
. : milestone, 7636,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~be4b392616, baseline=1.55.0-SNAPSHOT~4985d55399
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1457, 1480
. : milestone, 1469,
appsec (3.724 ms) : 3505, 3943
. : milestone, 3724,
iast (2.202 ms) : 2137, 2266
. : milestone, 2202,
iast_GLOBAL (2.255 ms) : 2191, 2320
. : milestone, 2255,
profiling (2.507 ms) : 2336, 2678
. : milestone, 2507,
tracing (2.035 ms) : 1984, 2085
. : milestone, 2035,
section candidate
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (3.695 ms) : 3478, 3912
. : milestone, 3695,
iast (2.209 ms) : 2145, 2273
. : milestone, 2209,
iast_GLOBAL (2.241 ms) : 2176, 2305
. : milestone, 2241,
profiling (2.063 ms) : 2010, 2116
. : milestone, 2063,
tracing (2.017 ms) : 1967, 2067
. : milestone, 2017,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~be4b392616, baseline=1.55.0-SNAPSHOT~4985d55399
dateFormat X
axisFormat %s
section baseline
no_agent (15.364 s) : 15364000, 15364000
. : milestone, 15364000,
appsec (15.129 s) : 15129000, 15129000
. : milestone, 15129000,
iast (18.616 s) : 18616000, 18616000
. : milestone, 18616000,
iast_GLOBAL (18.064 s) : 18064000, 18064000
. : milestone, 18064000,
profiling (15.616 s) : 15616000, 15616000
. : milestone, 15616000,
tracing (14.921 s) : 14921000, 14921000
. : milestone, 14921000,
section candidate
no_agent (15.622 s) : 15622000, 15622000
. : milestone, 15622000,
appsec (15.038 s) : 15038000, 15038000
. : milestone, 15038000,
iast (18.663 s) : 18663000, 18663000
. : milestone, 18663000,
iast_GLOBAL (18.024 s) : 18024000, 18024000
. : milestone, 18024000,
profiling (15.224 s) : 15224000, 15224000
. : milestone, 15224000,
tracing (15.217 s) : 15217000, 15217000
. : milestone, 15217000,
|
99603c0 to
2f85fdb
Compare
sarahchen6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
Co-authored-by: Sarah Chen <sarah.chen@datadoghq.com>
What Does This Do
Avoids accessing the archive configuration directly, preferring lazy API.
Also, prepares for reproducible archives coming in Gradle 9.0.0 gradle/gradle#33598, https://docs.gradle.org/current/userguide/upgrading_major_version_9.html#reproducible_archives_by_default
Motivation
The replaced code has two eager access:
configurations.archives(equivalent toconfigurations.getByName("archives"))artifacts { archives shadowJar }which is is doing under the hood, aconfigurations.getByName("archives")Also the previous code uses internal API ; it's not visible because groovy access this property via reflection and as such hides this detail.
Additional Notes
This configuration dates back from this 2017 commit 02d8f15, and was refactored in a4c20a0 to support Gradle 4.9.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]