-
Notifications
You must be signed in to change notification settings - Fork 323
Fix forbiddenApiFilters #9800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix forbiddenApiFilters #9800
Conversation
94fff75 to
03334b6
Compare
|
🎯 Code Coverage 🔗 Commit SHA: 7518e55 | Docs | Was this helpful? Give us feedback! |
03334b6 to
5c66018
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 5 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~7518e55f71, baseline=1.55.0-SNAPSHOT~52a8cc719b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.032 s) : 0, 1032023
Total [baseline] (8.696 s) : 0, 8695525
Agent [candidate] (1.02 s) : 0, 1020463
Total [candidate] (8.703 s) : 0, 8703274
section iast
Agent [baseline] (1.157 s) : 0, 1157376
Total [baseline] (9.319 s) : 0, 9319315
Agent [candidate] (1.161 s) : 0, 1161324
Total [candidate] (9.31 s) : 0, 9310107
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~7518e55f71, baseline=1.55.0-SNAPSHOT~52a8cc719b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.49 ms) : 0, 1490
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (703.547 ms) : 0, 703547
BytebuddyAgent [candidate] (693.818 ms) : 0, 693818
GlobalTracer [baseline] (244.502 ms) : 0, 244502
GlobalTracer [candidate] (243.462 ms) : 0, 243462
AppSec [baseline] (32.697 ms) : 0, 32697
AppSec [candidate] (32.433 ms) : 0, 32433
Debugger [baseline] (6.388 ms) : 0, 6388
Debugger [candidate] (6.284 ms) : 0, 6284
Remote Config [baseline] (688.692 µs) : 0, 689
Remote Config [candidate] (682.855 µs) : 0, 683
Telemetry [baseline] (9.47 ms) : 0, 9470
Telemetry [candidate] (9.329 ms) : 0, 9329
Flare Poller [baseline] (11.842 ms) : 0, 11842
Flare Poller [candidate] (11.84 ms) : 0, 11840
section iast
crashtracking [baseline] (1.479 ms) : 0, 1479
crashtracking [candidate] (1.49 ms) : 0, 1490
BytebuddyAgent [baseline] (818.217 ms) : 0, 818217
BytebuddyAgent [candidate] (822.817 ms) : 0, 822817
GlobalTracer [baseline] (233.226 ms) : 0, 233226
GlobalTracer [candidate] (233.425 ms) : 0, 233425
IAST [baseline] (27.057 ms) : 0, 27057
IAST [candidate] (27.06 ms) : 0, 27060
AppSec [baseline] (35.733 ms) : 0, 35733
AppSec [candidate] (35.244 ms) : 0, 35244
Debugger [baseline] (6.282 ms) : 0, 6282
Debugger [candidate] (6.187 ms) : 0, 6187
Remote Config [baseline] (637.892 µs) : 0, 638
Remote Config [candidate] (618.016 µs) : 0, 618
Telemetry [baseline] (8.859 ms) : 0, 8859
Telemetry [candidate] (8.773 ms) : 0, 8773
Flare Poller [baseline] (4.353 ms) : 0, 4353
Flare Poller [candidate] (4.24 ms) : 0, 4240
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~7518e55f71, baseline=1.55.0-SNAPSHOT~52a8cc719b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.02 s) : 0, 1020056
Total [baseline] (10.563 s) : 0, 10562762
Agent [candidate] (1.02 s) : 0, 1020247
Total [candidate] (10.801 s) : 0, 10800859
section appsec
Agent [baseline] (1.194 s) : 0, 1194460
Total [baseline] (10.908 s) : 0, 10907986
Agent [candidate] (1.209 s) : 0, 1209023
Total [candidate] (10.869 s) : 0, 10868962
section iast
Agent [baseline] (1.157 s) : 0, 1156820
Total [baseline] (11.034 s) : 0, 11034153
Agent [candidate] (1.154 s) : 0, 1153881
Total [candidate] (11.112 s) : 0, 11111680
section profiling
Agent [baseline] (1.165 s) : 0, 1165045
Total [baseline] (10.946 s) : 0, 10946185
Agent [candidate] (1.167 s) : 0, 1167222
Total [candidate] (10.913 s) : 0, 10913340
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~7518e55f71, baseline=1.55.0-SNAPSHOT~52a8cc719b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.472 ms) : 0, 1472
BytebuddyAgent [baseline] (694.305 ms) : 0, 694305
BytebuddyAgent [candidate] (696.333 ms) : 0, 696333
GlobalTracer [baseline] (242.763 ms) : 0, 242763
GlobalTracer [candidate] (243.963 ms) : 0, 243963
AppSec [baseline] (32.119 ms) : 0, 32119
AppSec [candidate] (32.235 ms) : 0, 32235
Debugger [baseline] (6.291 ms) : 0, 6291
Debugger [candidate] (6.319 ms) : 0, 6319
Remote Config [baseline] (683.706 µs) : 0, 684
Remote Config [candidate] (683.106 µs) : 0, 683
Telemetry [baseline] (9.364 ms) : 0, 9364
Telemetry [candidate] (9.309 ms) : 0, 9309
Flare Poller [baseline] (11.799 ms) : 0, 11799
Flare Poller [candidate] (8.724 ms) : 0, 8724
section appsec
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.486 ms) : 0, 1486
BytebuddyAgent [baseline] (717.536 ms) : 0, 717536
BytebuddyAgent [candidate] (729.175 ms) : 0, 729175
GlobalTracer [baseline] (234.774 ms) : 0, 234774
GlobalTracer [candidate] (237.054 ms) : 0, 237054
IAST [baseline] (24.843 ms) : 0, 24843
IAST [candidate] (25.075 ms) : 0, 25075
AppSec [baseline] (174.738 ms) : 0, 174738
AppSec [candidate] (175.537 ms) : 0, 175537
Debugger [baseline] (6.086 ms) : 0, 6086
Debugger [candidate] (6.08 ms) : 0, 6080
Remote Config [baseline] (640.613 µs) : 0, 641
Remote Config [candidate] (636.431 µs) : 0, 636
Telemetry [baseline] (9.308 ms) : 0, 9308
Telemetry [candidate] (8.622 ms) : 0, 8622
Flare Poller [baseline] (3.906 ms) : 0, 3906
Flare Poller [candidate] (3.925 ms) : 0, 3925
section iast
crashtracking [baseline] (1.476 ms) : 0, 1476
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (820.285 ms) : 0, 820285
BytebuddyAgent [candidate] (816.927 ms) : 0, 816927
GlobalTracer [baseline] (231.948 ms) : 0, 231948
GlobalTracer [candidate] (232.089 ms) : 0, 232089
IAST [baseline] (26.755 ms) : 0, 26755
IAST [candidate] (26.766 ms) : 0, 26766
AppSec [baseline] (35.1 ms) : 0, 35100
AppSec [candidate] (35.389 ms) : 0, 35389
Debugger [baseline] (6.149 ms) : 0, 6149
Debugger [candidate] (6.123 ms) : 0, 6123
Remote Config [baseline] (604.273 µs) : 0, 604
Remote Config [candidate] (605.839 µs) : 0, 606
Telemetry [baseline] (8.603 ms) : 0, 8603
Telemetry [candidate] (8.719 ms) : 0, 8719
Flare Poller [baseline] (4.269 ms) : 0, 4269
Flare Poller [candidate] (4.313 ms) : 0, 4313
section profiling
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.466 ms) : 0, 1466
BytebuddyAgent [baseline] (720.464 ms) : 0, 720464
BytebuddyAgent [candidate] (722.517 ms) : 0, 722517
GlobalTracer [baseline] (219.479 ms) : 0, 219479
GlobalTracer [candidate] (218.64 ms) : 0, 218640
AppSec [baseline] (32.128 ms) : 0, 32128
AppSec [candidate] (32.103 ms) : 0, 32103
Debugger [baseline] (6.711 ms) : 0, 6711
Debugger [candidate] (6.624 ms) : 0, 6624
Remote Config [baseline] (705.221 µs) : 0, 705
Remote Config [candidate] (695.215 µs) : 0, 695
Telemetry [baseline] (15.125 ms) : 0, 15125
Telemetry [candidate] (15.659 ms) : 0, 15659
Flare Poller [baseline] (5.095 ms) : 0, 5095
Flare Poller [candidate] (5.027 ms) : 0, 5027
ProfilingAgent [baseline] (110.044 ms) : 0, 110044
ProfilingAgent [candidate] (110.618 ms) : 0, 110618
Profiling [baseline] (110.7 ms) : 0, 110700
Profiling [candidate] (111.294 ms) : 0, 111294
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~7518e55f71, baseline=1.55.0-SNAPSHOT~52a8cc719b
dateFormat X
axisFormat %s
section baseline
no_agent (36.724 ms) : 36422, 37026
. : milestone, 36724,
appsec (49.672 ms) : 49223, 50121
. : milestone, 49672,
code_origins (43.822 ms) : 43437, 44207
. : milestone, 43822,
iast (42.997 ms) : 42623, 43370
. : milestone, 42997,
profiling (48.788 ms) : 48318, 49259
. : milestone, 48788,
tracing (43.009 ms) : 42660, 43358
. : milestone, 43009,
section candidate
no_agent (35.76 ms) : 35476, 36043
. : milestone, 35760,
appsec (48.224 ms) : 47788, 48661
. : milestone, 48224,
code_origins (43.282 ms) : 42917, 43648
. : milestone, 43282,
iast (44.728 ms) : 44334, 45122
. : milestone, 44728,
profiling (48.225 ms) : 47760, 48690
. : milestone, 48225,
tracing (44.361 ms) : 43983, 44738
. : milestone, 44361,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~7518e55f71, baseline=1.55.0-SNAPSHOT~52a8cc719b
dateFormat X
axisFormat %s
section baseline
no_agent (4.301 ms) : 4253, 4349
. : milestone, 4301,
iast (9.989 ms) : 9821, 10158
. : milestone, 9989,
iast_FULL (14.956 ms) : 14655, 15256
. : milestone, 14956,
iast_GLOBAL (11.177 ms) : 10973, 11380
. : milestone, 11177,
profiling (8.654 ms) : 8502, 8807
. : milestone, 8654,
tracing (7.49 ms) : 7375, 7604
. : milestone, 7490,
section candidate
no_agent (4.408 ms) : 4353, 4464
. : milestone, 4408,
iast (9.641 ms) : 9478, 9803
. : milestone, 9641,
iast_FULL (14.666 ms) : 14376, 14955
. : milestone, 14666,
iast_GLOBAL (10.161 ms) : 9971, 10350
. : milestone, 10161,
profiling (8.813 ms) : 8679, 8947
. : milestone, 8813,
tracing (7.733 ms) : 7617, 7849
. : milestone, 7733,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~7518e55f71, baseline=1.55.0-SNAPSHOT~52a8cc719b
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (3.67 ms) : 3456, 3883
. : milestone, 3670,
iast (2.224 ms) : 2159, 2288
. : milestone, 2224,
iast_GLOBAL (2.252 ms) : 2188, 2316
. : milestone, 2252,
profiling (2.061 ms) : 2009, 2112
. : milestone, 2061,
tracing (2.024 ms) : 1974, 2074
. : milestone, 2024,
section candidate
no_agent (1.483 ms) : 1471, 1495
. : milestone, 1483,
appsec (3.729 ms) : 3511, 3946
. : milestone, 3729,
iast (2.233 ms) : 2168, 2297
. : milestone, 2233,
iast_GLOBAL (2.26 ms) : 2196, 2325
. : milestone, 2260,
profiling (2.075 ms) : 2022, 2127
. : milestone, 2075,
tracing (2.036 ms) : 1986, 2086
. : milestone, 2036,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~7518e55f71, baseline=1.55.0-SNAPSHOT~52a8cc719b
dateFormat X
axisFormat %s
section baseline
no_agent (15.242 s) : 15242000, 15242000
. : milestone, 15242000,
appsec (14.957 s) : 14957000, 14957000
. : milestone, 14957000,
iast (18.419 s) : 18419000, 18419000
. : milestone, 18419000,
iast_GLOBAL (17.974 s) : 17974000, 17974000
. : milestone, 17974000,
profiling (15.116 s) : 15116000, 15116000
. : milestone, 15116000,
tracing (15.237 s) : 15237000, 15237000
. : milestone, 15237000,
section candidate
no_agent (15.69 s) : 15690000, 15690000
. : milestone, 15690000,
appsec (14.961 s) : 14961000, 14961000
. : milestone, 14961000,
iast (18.621 s) : 18621000, 18621000
. : milestone, 18621000,
iast_GLOBAL (18.133 s) : 18133000, 18133000
. : milestone, 18133000,
profiling (15.086 s) : 15086000, 15086000
. : milestone, 15086000,
tracing (15.041 s) : 15041000, 15041000
. : milestone, 15041000,
|
5c66018 to
93335ea
Compare
93335ea to
fdfbe33
Compare
PerfectSlayer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix 👍
Motivation
should be a
#between the class and method not.Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]