fix(prisma): use real trace context in getTraceParent for DBM correlation. #7104
+69
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion This fixes the Prisma instrumentation to return actual trace IDs instead of hardcoded placeholder values, enabling proper Database Monitoring (DBM) correlation. The implementation: - Retrieves active span context from async local storage - Calls toTraceparent() to get the W3C traceparent with real trace IDs - Forces sampled flag to ensure Prisma generates engine spans - Falls back to placeholder when no active span exists Fixes database monitoring correlation issues where Prisma was injecting fake trace IDs into SQL comments.
|
Thank you for picking up this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #6063
This fixes the Prisma instrumentation to return actual trace IDs instead of hardcoded placeholder values, enabling proper Database Monitoring (DBM) correlation. The implementation:
Motivation
Database Monitoring correlation requires real trace IDs to link database queries with application traces. The hardcoded placeholder prevents this correlation from working, making it impossible to identify which application requests are causing database load.
Plugin Checklist
Additional Notes
This is a bug fix (should be labeled
semver-patch). The change maintains backward compatibility while fixing the DBM correlation issue.Reviewer's Guide
The forced 01 sampling flag ensures Prisma generates engine spans, while dd-trace still makes the actual sampling decision when recording/sending those spans.