Skip to content

Conversation

@calvinbayer
Copy link
Contributor

What does this PR do?

This PR removes a condition that causes the Datadog backend not to be queried for advanced feature settings in case a kill-switch for ITR is provided through the environment variables.

Motivation

In the past, ITR was the only advanced feature, so calling the endpoint to receive feature configuration wasn't necessary with the kill-switch being provided. With more advanced features being added, this causes unwanted side-effects - users might want to toggle off ITR through environment variables but use other features that are being toggled on using the backend request.
In other tracers, this logic was already removed in the past, e.g., dd-trace-py

…switch is passed through environment variables
@github-actions
Copy link

Overall package size

Self size: 4.35 MB
Deduped: 5.18 MB
No deduping: 5.18 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.0 | 68.46 kB | 797.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@datadog-official

This comment has been minimized.

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.77%. Comparing base (7c979d2) to head (3653974).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7141      +/-   ##
==========================================
- Coverage   84.78%   84.77%   -0.02%     
==========================================
  Files         521      521              
  Lines       22159    22152       -7     
==========================================
- Hits        18788    18779       -9     
- Misses       3371     3373       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Dec 18, 2025

Benchmarks

Benchmark execution time: 2025-12-18 16:42:59

Comparing candidate commit 3653974 in PR branch calvin.bayer/fix/features-not-working-with-itr-kill-switch with baseline commit 7c979d2 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 290 metrics, 30 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants