FIx: Ws -add guardrail to bindAsyncStart in Publisher. #7149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7149 +/- ##
==========================================
- Coverage 84.48% 84.47% -0.02%
==========================================
Files 523 523
Lines 22448 22452 +4
==========================================
+ Hits 18966 18967 +1
- Misses 3482 3485 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Overall package sizeSelf size: 4.39 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.0 | 68.46 kB | 797.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
crysmags
changed the title
tlhunter
approved these changes
Dec 22, 2025
crysmags
force-pushed
the
crysmags/er-dec
branch
from
b7b4547 to
890fbf0
Compare
|
BridgeAR
requested changes
Dec 23, 2025
Collaborator
BridgeAR
left a comment
BridgeAR
left a comment
There was a problem hiding this comment.
Please also add a regression test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding a check to verify the span is present on the context before calling finish.
Motivation
There is a current escalation where the customer is using a long standing websocket connection and migrating traffic kubernetes pods while maintaining the same websocket. In doing so it appears the span on the context, which is the is lost and when attempting to call finish there is no longer a present span.