WAF for curl requests/partial json/libddwaf v2

[cataphract]

Description

Reviewer checklist

• Test coverage seems ok.
• Appropriate labels assigned.

[pr-commenter]

Benchmarks [ tracer ]

Benchmark execution time: 2025-12-31 12:53:38

Comparing candidate commit b25e658 in PR branch glopes/appsec-curl with baseline commit 575faf4 in branch master.

Found 2 performance improvements and 6 performance regressions! Performance is the same for 185 metrics, 1 unstable metrics.

scenario:EmptyFileBench/benchEmptyFileDdprof-opcache

• 🟩 execution_time [-306.786µs; -96.614µs] or [-7.447%; -2.345%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization

• 🟥 execution_time [+6.585µs; +7.695µs] or [+6.529%; +7.630%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

• 🟥 execution_time [+7.851µs; +8.689µs] or [+7.682%; +8.502%]

scenario:SamplingRuleMatchingBench/benchRegexMatching1

• 🟥 execution_time [+94.913ns; +167.087ns] or [+8.081%; +14.226%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

• 🟥 execution_time [+37.248ns; +137.352ns] or [+3.102%; +11.439%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4

• 🟥 execution_time [+38.381ns; +137.619ns] or [+3.145%; +11.276%]

scenario:SpanBench/benchOpenTelemetryAPI

• 🟥 mem_peak [+1.269MB; +1.289MB] or [+3.039%; +3.088%]

scenario:TraceSerializationBench/benchSerializeTrace

• 🟩 execution_time [-33.274µs; -20.426µs] or [-7.481%; -4.592%]

[codecov-commenter]

Codecov Report

❌ Patch coverage is 69.43442% with 254 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.58%. Comparing base (575faf4) to head (b25e658).
⚠️ Report is 29 commits behind head on master.

Files with missing lines	Patch %	Lines
appsec/src/extension/json_truncated_parser.cpp	73.72%	47 Missing and 15 partials ⚠️
appsec/src/extension/request_lifecycle.c	12.28%	49 Missing and 1 partial ⚠️
appsec/src/extension/ddappsec.c	52.05%	23 Missing and 12 partials ⚠️
appsec/src/helper/subscriber/waf.cpp	76.92%	20 Missing and 7 partials ⚠️
appsec/src/helper/parameter.cpp	73.73%	18 Missing and 8 partials ⚠️
appsec/src/helper/parameter_view.hpp	76.19%	8 Missing and 7 partials ⚠️
appsec/src/extension/curl.c	7.14%	13 Missing ⚠️
appsec/src/helper/json_helper.cpp	68.75%	6 Missing and 4 partials ⚠️
appsec/src/helper/parameter_base.cpp	63.63%	5 Missing and 3 partials ⚠️
appsec/src/helper/parameter_base.hpp	91.66%	1 Missing and 3 partials ⚠️
... and 3 more

❌ Your patch status has failed because the patch coverage (69.43%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3467      +/-   ##
==========================================
- Coverage   61.75%   61.58%   -0.17%     
==========================================
  Files         139      141       +2     
  Lines       13051    13577     +526     
  Branches     1712     1797      +85     
==========================================
+ Hits         8059     8362     +303     
- Misses       4228     4409     +181     
- Partials      764      806      +42     

Files with missing lines	Coverage Δ
appsec/src/extension/commands/request_exec.c	100.00% <100.00%> (ø)
appsec/src/extension/configuration.h	100.00% <ø> (ø)
appsec/src/extension/php_compat.h	100.00% <ø> (ø)
appsec/src/extension/request_abort.c	70.28% <100.00%> (ø)
appsec/src/extension/user_tracking.c	75.00% <100.00%> (+0.08%)	⬆️
appsec/src/helper/client.cpp	75.98% <100.00%> (ø)
appsec/src/helper/client.hpp	94.11% <ø> (ø)
appsec/src/helper/engine.cpp	91.73% <100.00%> (ø)
appsec/src/helper/engine.hpp	100.00% <ø> (ø)
appsec/src/helper/json_helper.hpp	50.00% <ø> (ø)
... and 16 more

... and 3 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 575faf4...b25e658. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[pr-commenter]

Benchmarks [ appsec ]

Benchmark execution time: 2025-12-31 12:27:44

Comparing candidate commit b25e658 in PR branch glopes/appsec-curl with baseline commit 575faf4 in branch master.

Found 0 performance improvements and 7 performance regressions! Performance is the same for 5 metrics, 0 unstable metrics.

scenario:LaravelBench/benchLaravelBaseline-appsec

• 🟥 mem_peak [+544.720KB; +544.720KB] or [+10.657%; +10.657%]

scenario:LaravelBench/benchLaravelOverhead-appsec

• 🟥 execution_time [+361.507µs; +542.993µs] or [+2.481%; +3.727%]
• 🟥 mem_peak [+544.720KB; +544.720KB] or [+10.657%; +10.657%]

scenario:SymfonyBench/benchSymfonyBaseline-appsec

• 🟥 mem_peak [+544.720KB; +544.720KB] or [+10.657%; +10.657%]

scenario:SymfonyBench/benchSymfonyOverhead-appsec

• 🟥 execution_time [+690.805µs; +844.695µs] or [+5.860%; +7.166%]
• 🟥 mem_peak [+544.719KB; +544.722KB] or [+10.657%; +10.657%]

scenario:WordPressBench/benchWordPressOverhead-appsec

• 🟥 execution_time [+5.547ms; +5.903ms] or [+13.212%; +14.059%]