-
Notifications
You must be signed in to change notification settings - Fork 166
Improvements for appsec libxml2 usage #3564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3564 +/- ##
==========================================
+ Coverage 61.81% 62.01% +0.20%
==========================================
Files 140 140
Lines 13281 13309 +28
Branches 1758 1762 +4
==========================================
+ Hits 8209 8253 +44
+ Misses 4282 4268 -14
+ Partials 790 788 -2
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
- Generalize the vendoring script a bit - Make the vendoring script include fewer files - Add two new tests - Move to SAX2 and disable SAX1 support - Add CI job warning when we're not on the latest libxml2
250a3eb to
288e04a
Compare
|
@cataphract some benchmarks started failing with "Aborted (core dumped)" |
The error is unrelated (see e.g. https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-php/-/jobs/1332840054 also failing). I'll check if b310ddd fixes it |
Benchmarks [ appsec ]Benchmark execution time: 2026-01-13 11:11:44 Comparing candidate commit 5666782 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. |
Description
Follow up on #3558 (comment)
Reviewer checklist