Skip to content

feat(tracer): add configuration for connection mode#3573

Open
Leiyks wants to merge 10 commits intomasterfrom
leiyks/sidecar-threaded-fallback
Open

feat(tracer): add configuration for connection mode#3573
Leiyks wants to merge 10 commits intomasterfrom
leiyks/sidecar-threaded-fallback

Conversation

@Leiyks
Copy link
Contributor

@Leiyks Leiyks commented Jan 13, 2026

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@datadog-official
Copy link

datadog-official bot commented Jan 13, 2026

⚠️ Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 1071 Tests failed

    ❄️ Known flaky: testCommandWithArgument from cakephp-28-test.DDTrace\Tests\Integrations\CLI\CakePHP\V2_8\CommonScenariosTest (Fix with Cursor)

    ❄️ Known flaky: testCommandWithNoArguments from cakephp-28-test.DDTrace\Tests\Integrations\CLI\CakePHP\V2_8\CommonScenariosTest (Fix with Cursor)

❄️ Known flaky: testCommandWithArgument from cakephp-310-test.DDTrace\Tests\Integrations\CLI\CakePHP\V3_10\CommonScenariosTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\CLI\CakePHP\V3_10\CommonScenariosTest::testCommandWithArgument
TypeError: Argument 1 passed to DDTrace\Tests\Common\SpanChecker::DDTrace\Tests\Common\{closure}() must be of the type array, string given

tests/Common/SpanChecker.php:599
tests/Common/SpanChecker.php:601
tests/Common/SpanChecker.php:346
tests/Common/SpanAssertionTrait.php:19
tests/Common/IntegrationTestCase.php:197
tests/Integrations/CLI/CakePHP/V3_10/CommonScenariosTest.php:51
tests/Common/RetryTraitVersionGeneric.php:28
...
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: e4a603a | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.11%. Comparing base (a9caaa0) to head (e4a603a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3573      +/-   ##
==========================================
- Coverage   62.21%   62.11%   -0.11%     
==========================================
  Files         141      141              
  Lines       13387    13387              
  Branches     1753     1753              
==========================================
- Hits         8329     8315      -14     
- Misses       4260     4273      +13     
- Partials      798      799       +1     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9caaa0...e4a603a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Jan 13, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-02-18 15:38:40

Comparing candidate commit e4a603a in PR branch leiyks/sidecar-threaded-fallback with baseline commit a9caaa0 in branch master.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 192 metrics, 0 unstable metrics.

scenario:ComposerTelemetryBench/benchTelemetryParsing-opcache

  • 🟩 execution_time [-1461.968ns; -538.032ns] or [-10.829%; -3.985%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟩 execution_time [-6.358µs; -4.302µs] or [-5.695%; -3.853%]

@Leiyks Leiyks force-pushed the leiyks/sidecar-threaded-fallback branch 4 times, most recently from ce20a9e to 2eb0609 Compare January 14, 2026 14:41
@pr-commenter
Copy link

pr-commenter bot commented Jan 14, 2026

Benchmarks [ profiler ]

Benchmark execution time: 2026-01-14 16:24:26

Comparing candidate commit 05ebcae in PR branch leiyks/sidecar-threaded-fallback with baseline commit 88a859c in branch master.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 28 metrics, 6 unstable metrics.

scenario:php-profiler-timeline-memory-with-profiler-and-timeline

  • 🟥 cpu_user_time [+36.124ms; +78.620ms] or [+2.324%; +5.058%]
  • 🟥 execution_time [+32.293ms; +51.335ms] or [+2.645%; +4.204%]

@Leiyks Leiyks force-pushed the leiyks/sidecar-threaded-fallback branch 9 times, most recently from 06223eb to cda73e8 Compare January 16, 2026 15:24
@Leiyks Leiyks force-pushed the leiyks/sidecar-threaded-fallback branch 9 times, most recently from 211d162 to 0b1eb24 Compare January 23, 2026 12:42
@Leiyks Leiyks force-pushed the leiyks/sidecar-threaded-fallback branch 2 times, most recently from 8ffb585 to db23a4f Compare January 26, 2026 12:36
@Leiyks Leiyks marked this pull request as ready for review January 26, 2026 12:37
@Leiyks Leiyks requested review from a team as code owners January 26, 2026 12:37
@Leiyks Leiyks force-pushed the leiyks/sidecar-threaded-fallback branch from db23a4f to 1dfbc13 Compare January 26, 2026 16:04
@Leiyks Leiyks requested a review from a team as a code owner January 26, 2026 16:04
@Leiyks Leiyks force-pushed the leiyks/sidecar-threaded-fallback branch from 1dfbc13 to ec704d7 Compare January 26, 2026 16:25
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
@Leiyks Leiyks force-pushed the leiyks/sidecar-threaded-fallback branch from 1e12088 to 9961e9d Compare February 18, 2026 13:42
@Leiyks Leiyks requested a review from a team as a code owner February 18, 2026 13:42
@Leiyks Leiyks force-pushed the leiyks/sidecar-threaded-fallback branch from 9961e9d to 58e8671 Compare February 18, 2026 13:45
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
@Leiyks Leiyks force-pushed the leiyks/sidecar-threaded-fallback branch from 58e8671 to e4a603a Compare February 18, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments