Draft
Conversation
|
✨ Fix all issues with BitsAI or with Cursor
|
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (86.30%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #3581 +/- ##
===========================================
+ Coverage 62.24% 86.30% +24.05%
===========================================
Files 141 22 -119
Lines 13387 4519 -8868
Branches 1753 0 -1753
===========================================
- Hits 8333 3900 -4433
+ Misses 4257 619 -3638
+ Partials 797 0 -797
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 141 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
cataphract
force-pushed
the
glopes/helper-rust
branch
from
f4914c3 to
2fc2654
Compare
cataphract
force-pushed
the
glopes/appsec-curl
branch
from
bbc593e to
192a4a1
Compare
Benchmarks [ appsec ]Benchmark execution time: 2026-02-11 15:07:37 Comparing candidate commit a645d2e in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. |
Benchmarks [ tracer ]Benchmark execution time: 2026-02-11 15:27:23 Comparing candidate commit a645d2e in PR branch Found 0 performance improvements and 6 performance regressions! Performance is the same for 184 metrics, 4 unstable metrics. scenario:ComposerTelemetryBench/benchTelemetryParsing
scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache
scenario:SamplingRuleMatchingBench/benchRegexMatching1
scenario:SamplingRuleMatchingBench/benchRegexMatching2
scenario:SamplingRuleMatchingBench/benchRegexMatching3
scenario:SamplingRuleMatchingBench/benchRegexMatching4
|
cataphract
force-pushed
the
glopes/helper-rust
branch
9 times, most recently
from
fb4432d to
8d1029e
Compare
Collaborator
|
This PR is so large that github will only permit me to review it one file at a time. I didn't even know that was a thing! You're going to need to break it down into a series of smaller PRs, probably. |
cataphract
force-pushed
the
glopes/helper-rust
branch
2 times, most recently
from
a218cd6 to
332fd93
Compare
Collaborator
|
@morrisonlevi I've had success for very big PRs with the PHPStorm/CLion github integrations in the past. Doesn't matter for small PRs, but can definitely recommend it for extra-large PRs :-) |
cataphract
force-pushed
the
glopes/helper-rust
branch
from
fc9100c to
718f800
Compare
cataphract
force-pushed
the
glopes/helper-rust
branch
from
d68a588 to
5d247e2
Compare
Changes the request_exec message format from [rasp_rule, data] to [data, options_map]. The options map supports: - rasp_rule: string (same as before) - subctx_id: optional string (accepted but ignored) - subctx_last_call: optional bool (accepted but ignored) This prepares the protocol for curl/subcontext support while maintaining backwards compatibility. The subcontext fields are accepted by the protocol but not implemented in the business logic. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Upgrade testcontainers - Add some assertions - Better debug output for metrics
cataphract
force-pushed
the
glopes/helper-rust
branch
from
5d247e2 to
57bcc57
Compare
Adds helper_runtime identification to distinguish Rust helper from C++ helper in telemetry and tracing:
Protocol changes:
- Both helpers send runtime type ("rust" or "cpp") in client_init response as 6th field
- Extension extracts and stores helper runtime in thread-local storage
Span metadata:
- Tag `_dd.appsec.helper_runtime:rust` added to ALL spans when using Rust helper
- Tag added only for Rust helper; C++ helper does not add this span tag
- Tags added via dd_tags_add_tags() in tags.c
Telemetry:
- Extension adds `helper_runtime:rust` tag to appsec telemetry metrics (only for Rust)
- Rust helper adds `helper_runtime:rust` tag to all telemetry (metrics and logs) downstream in submitters
Tests:
- Updated protocol tests to expect 6th field in client_init response
- Updated integration tests to conditionally check for helper_runtime tag
- Updated mock helper to send correct protocol format
- Removed test cases from request_exec.phpt that pass non-array values to request_exec()
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Passing integration and system-tests.
Further integration into sidecar and protocol changes pending.
Reviewer checklist