Skip to content

chore: add supported-configurations v2#3621

Open
BridgeAR wants to merge 18 commits intomasterfrom
BridgeAR/2026-02-04-add-supported-configuration-v2
Open

chore: add supported-configurations v2#3621
BridgeAR wants to merge 18 commits intomasterfrom
BridgeAR/2026-02-04-add-supported-configuration-v2

Conversation

@BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Feb 4, 2026

This adds the supported-configurations.json to php. That file is auto generated from configuration.h. As long as they are in sync, things will work easily. The validation step verifies in the CI if the file got updated or not and would fail, if a change was added without committing.

The one pipeline CI checks are added as well to make sure new configurations are added to the central repository before the PR that adds the config lands.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 4, 2026

⚠️ Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 1065 Tests failed

❄️ Known flaky: testCommandWithArgument from cakephp-28-test.DDTrace\Tests\Integrations\CLI\CakePHP\V2_8\CommonScenariosTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\CLI\CakePHP\V2_8\CommonScenariosTest::testCommandWithArgument
TypeError: Argument 1 passed to DDTrace\Tests\Common\SpanChecker::DDTrace\Tests\Common\{closure}() must be of the type array, string given

tests/Common/SpanChecker.php:599
tests/Common/SpanChecker.php:601
tests/Common/SpanChecker.php:346
tests/Common/SpanAssertionTrait.php:19
tests/Common/IntegrationTestCase.php:197
tests/Integrations/CLI/CakePHP/V2_8/CommonScenariosTest.php:51
tests/Common/RetryTraitVersionSpecific70.php:28
...
❄️ Known flaky: testCommandWithNoArguments from cakephp-28-test.DDTrace\Tests\Integrations\CLI\CakePHP\V2_8\CommonScenariosTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\CLI\CakePHP\V2_8\CommonScenariosTest::testCommandWithNoArguments
TypeError: Argument 1 passed to DDTrace\Tests\Common\SpanChecker::DDTrace\Tests\Common\{closure}() must be of the type array, string given

tests/Common/SpanChecker.php:599
tests/Common/SpanChecker.php:601
tests/Common/SpanChecker.php:346
tests/Common/SpanAssertionTrait.php:19
tests/Common/IntegrationTestCase.php:197
tests/Integrations/CLI/CakePHP/V2_8/CommonScenariosTest.php:35
tests/Common/RetryTraitVersionSpecific70.php:28
...
❄️ Known flaky: testCommandWithArgument from cakephp-310-test.DDTrace\Tests\Integrations\CLI\CakePHP\V3_10\CommonScenariosTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\CLI\CakePHP\V3_10\CommonScenariosTest::testCommandWithArgument
TypeError: Argument 1 passed to DDTrace\Tests\Common\SpanChecker::DDTrace\Tests\Common\{closure}() must be of the type array, string given

tests/Common/SpanChecker.php:599
tests/Common/SpanChecker.php:601
tests/Common/SpanChecker.php:346
tests/Common/SpanAssertionTrait.php:19
tests/Common/IntegrationTestCase.php:197
tests/Integrations/CLI/CakePHP/V3_10/CommonScenariosTest.php:51
tests/Common/RetryTraitVersionGeneric.php:28
...
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 41d3eb5 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.08%. Comparing base (6eb0128) to head (41d3eb5).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3621      +/-   ##
==========================================
- Coverage   62.22%   62.08%   -0.14%     
==========================================
  Files         141      141              
  Lines       13387    13351      -36     
  Branches     1753     1746       -7     
==========================================
- Hits         8330     8289      -41     
- Misses       4260     4269       +9     
+ Partials      797      793       -4     
Files with missing lines Coverage Δ
appsec/src/extension/configuration.c 69.56% <ø> (-0.64%) ⬇️
appsec/src/extension/configuration.h 100.00% <ø> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eb0128...41d3eb5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BridgeAR BridgeAR marked this pull request as ready for review February 4, 2026 21:57
@BridgeAR BridgeAR requested a review from a team as a code owner February 4, 2026 21:57
@BridgeAR BridgeAR requested review from bwoebi and genesor February 4, 2026 21:57
@pr-commenter
Copy link

pr-commenter bot commented Feb 12, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-02-19 21:30:18

Comparing candidate commit 41d3eb5 in PR branch BridgeAR/2026-02-04-add-supported-configuration-v2 with baseline commit 6eb0128 in branch master.

Found 2 performance improvements and 5 performance regressions! Performance is the same for 187 metrics, 0 unstable metrics.

scenario:ComposerTelemetryBench/benchTelemetryParsing-opcache

  • 🟥 execution_time [+373.339ns; +1026.661ns] or [+2.850%; +7.837%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟩 execution_time [-8.324µs; -6.176µs] or [-7.509%; -5.571%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟩 execution_time [-10.376µs; -9.164µs] or [-9.300%; -8.214%]

scenario:SamplingRuleMatchingBench/benchRegexMatching1

  • 🟥 execution_time [+107.363ns; +159.437ns] or [+9.299%; +13.810%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

  • 🟥 execution_time [+89.601ns; +158.999ns] or [+7.639%; +13.555%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3

  • 🟥 execution_time [+113.958ns; +187.642ns] or [+9.849%; +16.217%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4

  • 🟥 execution_time [+113.241ns; +150.959ns] or [+9.857%; +13.141%]

@genesor genesor requested a review from a team as a code owner February 12, 2026 13:46
@pr-commenter
Copy link

pr-commenter bot commented Feb 13, 2026

Benchmarks [ appsec ]

Benchmark execution time: 2026-02-19 20:52:05

Comparing candidate commit 41d3eb5 in PR branch BridgeAR/2026-02-04-add-supported-configuration-v2 with baseline commit 6eb0128 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Copy link
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks!

@BridgeAR BridgeAR force-pushed the BridgeAR/2026-02-04-add-supported-configuration-v2 branch from 64bcaec to 0974e5d Compare February 19, 2026 13:59
@BridgeAR BridgeAR requested review from a team as code owners February 19, 2026 13:59
BridgeAR and others added 13 commits February 19, 2026 15:00
This adds the supported-configurations.json to php. That file is
auto generated from configuration.h. As long as they are in sync,
things will work easily. The validation step verifies in the CI
if the file got updated or not and would fail, if a change was
added without committing.

The one pipeline CI checks are added as well to make sure new
configurations are added to the central repository before the PR
that adds the config lands.
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@BridgeAR BridgeAR force-pushed the BridgeAR/2026-02-04-add-supported-configuration-v2 branch from 0974e5d to 71ab2ae Compare February 19, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments