Skip to content

test(profiling): add missing prof correctness tests for I/O profiling#3652

Open
realFlowControl wants to merge 2 commits intoflorian/macos-io-profilingfrom
florian/macos-io-profiling-tests
Open

test(profiling): add missing prof correctness tests for I/O profiling#3652
realFlowControl wants to merge 2 commits intoflorian/macos-io-profilingfrom
florian/macos-io-profiling-tests

Conversation

@realFlowControl
Copy link
Member

@realFlowControl realFlowControl commented Feb 16, 2026

Warning

this merges into #3648

Description

This PR adds missing I/O correctness tests

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@github-actions github-actions bot added the profiling Relates to the Continuous Profiler label Feb 16, 2026
@pr-commenter
Copy link

pr-commenter bot commented Feb 16, 2026

Benchmarks [ profiler ]

Benchmark execution time: 2026-02-18 16:39:44

Comparing candidate commit 5c57467 in PR branch florian/macos-io-profiling-tests with baseline commit 6bac2fd in branch florian/macos-io-profiling.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 30 metrics, 6 unstable metrics.

@realFlowControl realFlowControl force-pushed the florian/macos-io-profiling-tests branch from b198600 to 5d690e5 Compare February 16, 2026 16:31
@realFlowControl realFlowControl marked this pull request as ready for review February 16, 2026 16:37
@realFlowControl realFlowControl requested review from a team as code owners February 16, 2026 16:37
@realFlowControl realFlowControl force-pushed the florian/macos-io-profiling-tests branch from 5d690e5 to 941d06e Compare February 16, 2026 16:40
@datadog-official
Copy link

datadog-official bot commented Feb 16, 2026

⚠️ Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 1062 Tests failed

    ❄️ Known flaky: testCommandWithArgument from cakephp-28-test.DDTrace\Tests\Integrations\CLI\CakePHP\V2_8\CommonScenariosTest (Fix with Cursor)

    ❄️ Known flaky: testCommandWithNoArguments from cakephp-28-test.DDTrace\Tests\Integrations\CLI\CakePHP\V2_8\CommonScenariosTest (Fix with Cursor)

❄️ Known flaky: testCommandWithArgument from cakephp-310-test.DDTrace\Tests\Integrations\CLI\CakePHP\V3_10\CommonScenariosTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\CLI\CakePHP\V3_10\CommonScenariosTest::testCommandWithArgument
TypeError: Argument 1 passed to DDTrace\Tests\Common\SpanChecker::DDTrace\Tests\Common\{closure}() must be of the type array, string given

tests/Common/SpanChecker.php:599
tests/Common/SpanChecker.php:601
tests/Common/SpanChecker.php:346
tests/Common/SpanAssertionTrait.php:19
tests/Common/IntegrationTestCase.php:197
tests/Integrations/CLI/CakePHP/V3_10/CommonScenariosTest.php:51
tests/Common/RetryTraitVersionGeneric.php:28
...
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5c57467 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@realFlowControl realFlowControl force-pushed the florian/macos-io-profiling branch 3 times, most recently from e32fa5d to 6bac2fd Compare February 18, 2026 06:19
@realFlowControl realFlowControl force-pushed the florian/macos-io-profiling-tests branch 2 times, most recently from 13fbf30 to 3bee471 Compare February 18, 2026 06:29
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.21%. Comparing base (6bac2fd) to head (5c57467).

Additional details and impacted files

Impacted file tree graph

@@                      Coverage Diff                       @@
##           florian/macos-io-profiling    #3652      +/-   ##
==============================================================
+ Coverage                       62.11%   62.21%   +0.10%     
==============================================================
  Files                             141      141              
  Lines                           13387    13387              
  Branches                         1753     1753              
==============================================================
+ Hits                             8315     8329      +14     
+ Misses                           4273     4260      -13     
+ Partials                          799      798       -1     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bac2fd...5c57467. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@realFlowControl realFlowControl force-pushed the florian/macos-io-profiling-tests branch from 3bee471 to 17c1398 Compare February 18, 2026 06:50
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error_margin of 10 is pretty high for this deterministic benchmark, isn't it? Any particular reason it isn't tighter?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the runs and they all where at "0% error", but if we start adjusting the sampling distance, we might get some errors in the future.
I've tightened the error_margin to 2%. In case we see failures here when adjusting the sampling distance in the future, we can then make a decision of how to handle that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

profiling Relates to the Continuous Profiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments