test(profiling): add missing prof correctness tests for I/O profiling#3652
test(profiling): add missing prof correctness tests for I/O profiling#3652realFlowControl wants to merge 2 commits intoflorian/macos-io-profilingfrom
Conversation
Benchmarks [ profiler ]Benchmark execution time: 2026-02-18 16:39:44 Comparing candidate commit 5c57467 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 30 metrics, 6 unstable metrics. |
b198600 to
5d690e5
Compare
5d690e5 to
941d06e
Compare
|
✨ Fix all issues with BitsAI or with Cursor
|
e32fa5d to
6bac2fd
Compare
13fbf30 to
3bee471
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## florian/macos-io-profiling #3652 +/- ##
==============================================================
+ Coverage 62.11% 62.21% +0.10%
==============================================================
Files 141 141
Lines 13387 13387
Branches 1753 1753
==============================================================
+ Hits 8315 8329 +14
+ Misses 4273 4260 -13
+ Partials 799 798 -1 see 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
3bee471 to
17c1398
Compare
There was a problem hiding this comment.
An error_margin of 10 is pretty high for this deterministic benchmark, isn't it? Any particular reason it isn't tighter?
There was a problem hiding this comment.
I checked the runs and they all where at "0% error", but if we start adjusting the sampling distance, we might get some errors in the future.
I've tightened the error_margin to 2%. In case we see failures here when adjusting the sampling distance in the future, we can then make a decision of how to handle that.
Warning
this merges into #3648
Description
This PR adds missing I/O correctness tests
Reviewer checklist