Skip to content

Adds process tags to remote config payload#3658

Draft
dubloom wants to merge 1 commit intomasterfrom
dubloom/process-tags-rc
Draft

Adds process tags to remote config payload#3658
dubloom wants to merge 1 commit intomasterfrom
dubloom/process-tags-rc

Conversation

@dubloom
Copy link
Contributor

@dubloom dubloom commented Feb 17, 2026

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Feb 17, 2026

⚠️ Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

❄️ 32 New flaky tests detected

testCommandWithArgument from cakephp-28-test.DDTrace\Tests\Integrations\CLI\CakePHP\V2_8\CommonScenariosTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\CLI\CakePHP\V2_8\CommonScenariosTest::testCommandWithArgument
TypeError: Argument 1 passed to DDTrace\Tests\Common\SpanChecker::DDTrace\Tests\Common\{closure}() must be of the type array, string given

tests/Common/SpanChecker.php:599
tests/Common/SpanChecker.php:601
tests/Common/SpanChecker.php:346
tests/Common/SpanAssertionTrait.php:19
tests/Common/IntegrationTestCase.php:197
tests/Integrations/CLI/CakePHP/V2_8/CommonScenariosTest.php:51
tests/Common/RetryTraitVersionSpecific70.php:28
...
testCommandWithNoArguments from cakephp-28-test.DDTrace\Tests\Integrations\CLI\CakePHP\V2_8\CommonScenariosTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\CLI\CakePHP\V2_8\CommonScenariosTest::testCommandWithNoArguments
TypeError: Argument 1 passed to DDTrace\Tests\Common\SpanChecker::DDTrace\Tests\Common\{closure}() must be of the type array, string given

tests/Common/SpanChecker.php:599
tests/Common/SpanChecker.php:601
tests/Common/SpanChecker.php:346
tests/Common/SpanAssertionTrait.php:19
tests/Common/IntegrationTestCase.php:197
tests/Integrations/CLI/CakePHP/V2_8/CommonScenariosTest.php:35
tests/Common/RetryTraitVersionSpecific70.php:28
...

    testCommandWithArgument from cakephp-310-test.DDTrace\Tests\Integrations\CLI\CakePHP\V3_10\CommonScenariosTest (Fix with Cursor)

View all

🧪 1046 Tests failed

test anonymized auto user instrumentation() from com.datadog.appsec.php.integration.RemoteConfigTests (Datadog) (Fix with Cursor)
java.lang.AssertionError: No request with version 1771351625 gotten within 5000 ms for com.datadog.appsec.php.mock_agent.rem_cfg.Target(some-name, none, )

java.lang.AssertionError: No request with version 1771351625 gotten within 5000 ms for com.datadog.appsec.php.mock_agent.rem_cfg.Target(some-name, none, )
	at com.datadog.appsec.php.mock_agent.ConfigV07Handler.waitForVersion(ConfigV07Handler.groovy:72)
	at com.datadog.appsec.php.mock_agent.MockDatadogAgent.waitForRCVersion(MockDatadogAgent.groovy:80)
	at com.datadog.appsec.php.docker.AppSecContainer.waitForRCVersion(AppSecContainer.groovy:180)
	at com.datadog.appsec.php.docker.AppSecContainer$_applyRemoteConfig_closure6.doCall(AppSecContainer.groovy:232)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
...
test asm() from com.datadog.appsec.php.integration.RemoteConfigTests (Datadog) (Fix with Cursor)
java.lang.AssertionError: No request with version 1771351590 gotten within 5000 ms for com.datadog.appsec.php.mock_agent.rem_cfg.Target(some-name, none, )

java.lang.AssertionError: No request with version 1771351590 gotten within 5000 ms for com.datadog.appsec.php.mock_agent.rem_cfg.Target(some-name, none, )
	at com.datadog.appsec.php.mock_agent.ConfigV07Handler.waitForVersion(ConfigV07Handler.groovy:72)
	at com.datadog.appsec.php.mock_agent.MockDatadogAgent.waitForRCVersion(MockDatadogAgent.groovy:80)
	at com.datadog.appsec.php.docker.AppSecContainer.waitForRCVersion(AppSecContainer.groovy:180)
	at com.datadog.appsec.php.docker.AppSecContainer$_applyRemoteConfig_closure6.doCall(AppSecContainer.groovy:232)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
...
test asm_data() from com.datadog.appsec.php.integration.RemoteConfigTests (Datadog) (Fix with Cursor)
java.lang.AssertionError: No request with version 1771351610 gotten within 5000 ms for com.datadog.appsec.php.mock_agent.rem_cfg.Target(some-name, none, )

java.lang.AssertionError: No request with version 1771351610 gotten within 5000 ms for com.datadog.appsec.php.mock_agent.rem_cfg.Target(some-name, none, )
	at com.datadog.appsec.php.mock_agent.ConfigV07Handler.waitForVersion(ConfigV07Handler.groovy:72)
	at com.datadog.appsec.php.mock_agent.MockDatadogAgent.waitForRCVersion(MockDatadogAgent.groovy:80)
	at com.datadog.appsec.php.docker.AppSecContainer.waitForRCVersion(AppSecContainer.groovy:180)
	at com.datadog.appsec.php.docker.AppSecContainer$_applyRemoteConfig_closure6.doCall(AppSecContainer.groovy:232)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
...
View all
This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 23c2a15 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.20%. Comparing base (c4d3e54) to head (23c2a15).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3658      +/-   ##
==========================================
+ Coverage   62.11%   62.20%   +0.08%     
==========================================
  Files         141      141              
  Lines       13387    13387              
  Branches     1753     1753              
==========================================
+ Hits         8315     8327      +12     
+ Misses       4273     4263      -10     
+ Partials      799      797       -2     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4d3e54...23c2a15. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented Feb 17, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-02-17 19:14:55

Comparing candidate commit 23c2a15 in PR branch dubloom/process-tags-rc with baseline commit c4d3e54 in branch master.

Found 0 performance improvements and 4 performance regressions! Performance is the same for 188 metrics, 2 unstable metrics.

scenario:SamplingRuleMatchingBench/benchRegexMatching1

  • 🟥 execution_time [+92.687ns; +144.713ns] or [+8.018%; +12.518%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2

  • 🟥 execution_time [+92.695ns; +119.705ns] or [+8.063%; +10.412%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3

  • 🟥 execution_time [+93.305ns; +157.895ns] or [+8.068%; +13.653%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4

  • 🟥 execution_time [+94.593ns; +141.207ns] or [+8.219%; +12.269%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments