Skip to content

Comments

perf(profiling): cache TlsConfig#3666

Draft
morrisonlevi wants to merge 1 commit intomasterfrom
PROF-13824-ProfileExporter-new-creates-TLS-config-every-time
Draft

perf(profiling): cache TlsConfig#3666
morrisonlevi wants to merge 1 commit intomasterfrom
PROF-13824-ProfileExporter-new-creates-TLS-config-every-time

Conversation

@morrisonlevi
Copy link
Collaborator

Description

This draft PR demonstrates the improvement in DataDog/libdatadog#1619 for uploading by caching the config.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@github-actions github-actions bot added the profiling Relates to the Continuous Profiler label Feb 20, 2026
@datadog-official
Copy link

datadog-official bot commented Feb 20, 2026

⚠️ Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 1065 Tests failed

    ❄️ Known flaky: testCommandWithArgument from cakephp-28-test.DDTrace\Tests\Integrations\CLI\CakePHP\V2_8\CommonScenariosTest (Fix with Cursor)

    ❄️ Known flaky: testCommandWithNoArguments from cakephp-28-test.DDTrace\Tests\Integrations\CLI\CakePHP\V2_8\CommonScenariosTest (Fix with Cursor)

❄️ Known flaky: testCommandWithArgument from cakephp-310-test.DDTrace\Tests\Integrations\CLI\CakePHP\V3_10\CommonScenariosTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\CLI\CakePHP\V3_10\CommonScenariosTest::testCommandWithArgument
TypeError: Argument 1 passed to DDTrace\Tests\Common\SpanChecker::DDTrace\Tests\Common\{closure}() must be of the type array, string given

tests/Common/SpanChecker.php:599
tests/Common/SpanChecker.php:601
tests/Common/SpanChecker.php:346
tests/Common/SpanAssertionTrait.php:19
tests/Common/IntegrationTestCase.php:197
tests/Integrations/CLI/CakePHP/V3_10/CommonScenariosTest.php:51
tests/Common/RetryTraitVersionGeneric.php:28
...
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 4a93c31 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Feb 20, 2026

Benchmarks [ profiler ]

Benchmark execution time: 2026-02-20 20:44:31

Comparing candidate commit 4a93c31 in PR branch PROF-13824-ProfileExporter-new-creates-TLS-config-every-time with baseline commit f785afe in branch master.

Found 0 performance improvements and 4 performance regressions! Performance is the same for 24 metrics, 8 unstable metrics.

scenario:php-profiler-exceptions-control

  • 🟥 execution_time [+11.388ms; +13.322ms] or [+13.984%; +16.358%]

scenario:php-profiler-exceptions-with-profiler

  • 🟥 execution_time [+10.733ms; +13.301ms] or [+11.479%; +14.225%]

scenario:php-profiler-exceptions-with-profiler-and-timeline

  • 🟥 execution_time [+10.731ms; +13.549ms] or [+11.164%; +14.096%]

scenario:php-profiler-timeline-memory-with-profiler

  • 🟥 max_rss_usage [+606.799KB; +1082.801KB] or [+2.010%; +3.588%]

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.20%. Comparing base (f785afe) to head (4a93c31).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3666      +/-   ##
==========================================
- Coverage   62.21%   62.20%   -0.02%     
==========================================
  Files         141      141              
  Lines       13388    13388              
  Branches     1753     1753              
==========================================
- Hits         8330     8328       -2     
- Misses       4260     4263       +3     
+ Partials      798      797       -1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f785afe...4a93c31. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

profiling Relates to the Continuous Profiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants