-
Notifications
You must be signed in to change notification settings - Fork 8
Array indexing on key paths #458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
1a923cd to
c960cea
Compare
Benchmarks clang-pgoBenchmark execution time: 2025-10-28 17:08:29 Comparing candidate commit 941b2d9 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. |
6895df2 to
df3aad8
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #458 +/- ##
==========================================
- Coverage 85.21% 85.05% -0.17%
==========================================
Files 189 189
Lines 9226 9279 +53
Branches 4179 4225 +46
==========================================
+ Hits 7862 7892 +30
- Misses 528 529 +1
- Partials 836 858 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Artifact Size Comparison 📦
|
df3aad8 to
6ae5265
Compare
|
@codex review |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting |
6dd0a94 to
b7da11a
Compare
9ef0a2e to
1c7c434
Compare
|
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
🎯 Code Coverage 🔗 Commit SHA: 9e47df3 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Co-authored-by: datadog-official[bot] <214633350+datadog-official[bot]@users.noreply.github.com>
56be6a8 to
856e971
Compare
ea1e40b to
5a729ba
Compare
5a729ba to
c68a7ee
Compare
c68a7ee to
0ed3509
Compare
0ed3509 to
8e91130
Compare
8e91130 to
0c1b4fc
Compare
0c1b4fc to
bb2b407
Compare
845e604 to
9e47df3
Compare
This PR adds support for numeric key paths on rules, for the purpose of addressing elements within an array but, more specifically for addressing both starting from the front or the back. For example:
["key", 0, "other", 2].["key", -1, "other", -2].Therefore when addressing from the front, indices start at 0, while addressing from the back indices start at -1.
As a result of this new feature, key paths with negative indices will be provided as such in the rule match specification, i.e. the negative values will be maintained to ensure that the key path accurately represents what the user requested.