Skip to content

Conversation

@Anilm3
Copy link
Collaborator

@Anilm3 Anilm3 commented Nov 5, 2025

Changes:

  • Set FMT_OPTIMIZE_SIZE to reduce the size of fmtlib (also removes locale-specific code).
  • Add format.cc to reduce inlining.
  • Move templates from utils.hpp to utils.cpp and instantiate for specific type.
  • Move functions from semver.hpp to semver.cpp.
  • Enabled LTO on MacOS builds.

@Anilm3 Anilm3 temporarily deployed to dd-protected-coverage November 5, 2025 17:07 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2025

Codecov Report

❌ Patch coverage is 92.30769% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.64%. Comparing base (1d9c11e) to head (5fb6717).

Files with missing lines Patch % Lines
src/semver.cpp 88.46% 0 Missing and 3 partials ⚠️
src/ruleset_info.hpp 0.00% 0 Missing and 1 partial ⚠️
src/utils.cpp 96.77% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #479      +/-   ##
==========================================
+ Coverage   84.41%   84.64%   +0.22%     
==========================================
  Files         189      191       +2     
  Lines        9279     9266      -13     
  Branches     4229     4219      -10     
==========================================
+ Hits         7833     7843      +10     
+ Misses        529      527       -2     
+ Partials      917      896      -21     
Flag Coverage Δ
waf_test 84.64% <92.30%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@datadog-official
Copy link

datadog-official bot commented Nov 5, 2025

🎯 Code Coverage
Patch Coverage: 97.10%
Total Coverage: 94.01% (+0.01%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ddb4949 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Nov 5, 2025

Benchmarks clang-pgo

Benchmark execution time: 2025-11-07 11:14:05

Comparing candidate commit 5fb6717 in PR branch anilm3/attempt-fmt-binary-size-reduction with baseline commit 1d9c11e in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@Anilm3 Anilm3 temporarily deployed to dd-protected-coverage November 5, 2025 20:08 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

Dynamic Artifact Size Comparison 📦

Artifact Previous Release This PR Difference
darwin-arm64::libddwaf.dylib 1963024 2020880 2.94%
darwin-universal::libddwaf.dylib 4142096 4249104 2.58%
darwin-x86_64::libddwaf.dylib 2150896 2212440 2.86%
linux-aarch64::libddwaf.so 2463264 2388784 -3.02%
linux-armv7::libddwaf.so 2148796 2054576 -4.38%
linux-i386::libddwaf.so 2392820 2313604 -3.31%
linux-x86_64::libddwaf.so 2660096 2584704 -2.83%
windows-arm64::ddwaf.dll 4788736 4807680 0.39%
windows-win32::ddwaf.dll 3368448 3335168 -0.98%
windows-x64::ddwaf.dll 4101632 4073472 -0.68%

Static Artifact Size Comparison 📦

Artifact Previous Release This PR Difference
darwin-arm64::libddwaf.a 90006808 95288048 5.86%
darwin-arm64::libddwaf.a.stripped 4579664 4801216 4.83%
darwin-universal::libddwaf.a 181421048 192135080 5.90%
darwin-universal::libddwaf.a.stripped 9765560 10237592 4.83%
darwin-x86_64::libddwaf.a 91414192 96846984 5.94%
darwin-x86_64::libddwaf.a.stripped 5185848 5436328 4.83%
linux-aarch64::libddwaf.a 73159398 76946742 5.17%
linux-aarch64::libddwaf.a.stripped 11852314 12360042 4.28%
linux-armv7::libddwaf.a 64719602 68015478 5.09%
linux-armv7::libddwaf.a.stripped 10852830 11366782 4.73%
linux-i386::libddwaf.a 62843294 66177444 5.30%
linux-i386::libddwaf.a.stripped 9380114 9848572 4.99%
linux-x86_64::libddwaf.a 73646022 77460838 5.17%
linux-x86_64::libddwaf.a.stripped 11671354 12170914 4.28%
windows-arm64::ddwaf.lib 11698 16410 40.27%
windows-arm64::ddwaf_static.lib 57913956 57286204 -1.08%
windows-win32::ddwaf.lib 11922 16726 40.29%
windows-win32::ddwaf_static.lib 49534552 48884078 -1.31%
windows-x64::ddwaf.lib 11698 16410 40.27%
windows-x64::ddwaf_static.lib 57410292 57081498 -0.57%

@Anilm3 Anilm3 temporarily deployed to dd-protected-coverage November 6, 2025 08:30 — with GitHub Actions Inactive
@Anilm3 Anilm3 temporarily deployed to dd-protected-coverage November 6, 2025 11:52 — with GitHub Actions Inactive
@Anilm3 Anilm3 temporarily deployed to dd-protected-coverage November 6, 2025 12:13 — with GitHub Actions Inactive
@Anilm3 Anilm3 force-pushed the anilm3/attempt-fmt-binary-size-reduction branch from 94a517e to 5a10376 Compare November 6, 2025 13:10
@Anilm3 Anilm3 temporarily deployed to dd-protected-coverage November 6, 2025 13:20 — with GitHub Actions Inactive
@Anilm3 Anilm3 temporarily deployed to dd-protected-coverage November 6, 2025 13:40 — with GitHub Actions Inactive
@Anilm3 Anilm3 marked this pull request as ready for review November 6, 2025 13:58
@Anilm3 Anilm3 requested a review from a team as a code owner November 6, 2025 13:58
@Anilm3 Anilm3 temporarily deployed to dd-protected-coverage November 6, 2025 14:09 — with GitHub Actions Inactive
@Anilm3
Copy link
Collaborator Author

Anilm3 commented Nov 6, 2025

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Swish!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Co-authored-by: datadog-datadog-prod-us1[bot] <88084959+datadog-datadog-prod-us1[bot]@users.noreply.github.com>
@Anilm3 Anilm3 temporarily deployed to dd-protected-coverage November 6, 2025 19:37 — with GitHub Actions Inactive
@Anilm3 Anilm3 force-pushed the anilm3/attempt-fmt-binary-size-reduction branch from eccdbbe to 02da49f Compare November 7, 2025 10:17
@Anilm3 Anilm3 had a problem deploying to dd-protected-coverage November 7, 2025 10:26 — with GitHub Actions Error
@Anilm3 Anilm3 force-pushed the anilm3/attempt-fmt-binary-size-reduction branch from 02da49f to e88d389 Compare November 7, 2025 10:27
@Anilm3 Anilm3 temporarily deployed to dd-protected-coverage November 7, 2025 10:36 — with GitHub Actions Inactive
@Anilm3 Anilm3 temporarily deployed to dd-protected-coverage November 7, 2025 11:58 — with GitHub Actions Inactive
@Anilm3 Anilm3 merged commit fe3bc90 into master Nov 7, 2025
54 checks passed
@Anilm3 Anilm3 deleted the anilm3/attempt-fmt-binary-size-reduction branch November 7, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants