-
Notifications
You must be signed in to change notification settings - Fork 8
Attempt to reduce the binary size due to fmtlib #479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #479 +/- ##
==========================================
+ Coverage 84.41% 84.64% +0.22%
==========================================
Files 189 191 +2
Lines 9279 9266 -13
Branches 4229 4219 -10
==========================================
+ Hits 7833 7843 +10
+ Misses 529 527 -2
+ Partials 917 896 -21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🎯 Code Coverage 🔗 Commit SHA: ddb4949 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Benchmarks clang-pgoBenchmark execution time: 2025-11-07 11:14:05 Comparing candidate commit 5fb6717 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. |
Dynamic Artifact Size Comparison 📦
Static Artifact Size Comparison 📦
|
94a517e to
5a10376
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Co-authored-by: datadog-datadog-prod-us1[bot] <88084959+datadog-datadog-prod-us1[bot]@users.noreply.github.com>
eccdbbe to
02da49f
Compare
02da49f to
e88d389
Compare
Changes:
FMT_OPTIMIZE_SIZEto reduce the size of fmtlib (also removes locale-specific code).format.ccto reduce inlining.utils.hpptoutils.cppand instantiate for specific type.semver.hpptosemver.cpp.