Skip to content

Conversation

@Anilm3
Copy link
Collaborator

@Anilm3 Anilm3 commented Nov 24, 2025

The ruleset v1 schema was introduced as part of the beta period of Appsec / ASM / AAP. In practice, no actual tracer released has used this schema, therefore it is finally being removed.

@Anilm3 Anilm3 requested a review from a team as a code owner November 24, 2025 16:52
@github-actions
Copy link

Dynamic Artifact Size Comparison 📦

Artifact Previous Release This PR Difference
darwin-arm64::libddwaf.dylib 1963024 2004032 2.08%
darwin-universal::libddwaf.dylib 4142096 4215872 1.78%
darwin-x86_64::libddwaf.dylib 2150896 2195712 2.08%
linux-aarch64::libddwaf.so 2463264 2375936 -3.54%
linux-armv7::libddwaf.so 2148796 2041176 -5.00%
linux-i386::libddwaf.so 2392820 2297676 -3.97%
linux-x86_64::libddwaf.so 2660096 2569216 -3.41%
windows-arm64::ddwaf.dll 4788736 4781568 -0.14%
windows-win32::ddwaf.dll 3368448 3319808 -1.44%
windows-x64::ddwaf.dll 4101632 4050944 -1.23%

Static Artifact Size Comparison 📦

Artifact Previous Release This PR Difference
darwin-arm64::libddwaf.a 90006808 91933912 2.14%
darwin-arm64::libddwaf.a.stripped 4579664 4698328 2.59%
darwin-universal::libddwaf.a 181421048 185388816 2.18%
darwin-universal::libddwaf.a.stripped 9765560 10016712 2.57%
darwin-x86_64::libddwaf.a 91414192 93454856 2.23%
darwin-x86_64::libddwaf.a.stripped 5185848 5318336 2.55%
linux-aarch64::libddwaf.a 73159398 75416566 3.08%
linux-aarch64::libddwaf.a.stripped 11852314 12167458 2.65%
linux-armv7::libddwaf.a 64719602 66611544 2.92%
linux-armv7::libddwaf.a.stripped 10852830 11179240 3.00%
linux-i386::libddwaf.a 62843294 64806086 3.12%
linux-i386::libddwaf.a.stripped 9380114 9684886 3.24%
linux-x86_64::libddwaf.a 73646022 75915104 3.08%
linux-x86_64::libddwaf.a.stripped 11671354 11979412 2.63%
windows-arm64::ddwaf.lib 11698 16410 40.27%
windows-arm64::ddwaf_static.lib 57913956 55788004 -3.67%
windows-win32::ddwaf.lib 11922 16726 40.29%
windows-win32::ddwaf_static.lib 49534552 47709396 -3.68%
windows-x64::ddwaf.lib 11698 16410 40.27%
windows-x64::ddwaf_static.lib 57410292 55529532 -3.27%

@pr-commenter
Copy link

pr-commenter bot commented Nov 24, 2025

Benchmarks clang-pgo

Benchmark execution time: 2025-11-24 17:28:10

Comparing candidate commit ed654b0 in PR branch anilm3/remove-legacy-rule-schema-support with baseline commit fe3bc90 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@Anilm3 Anilm3 temporarily deployed to dd-protected-coverage November 24, 2025 17:49 — with GitHub Actions Inactive
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.91%. Comparing base (fe3bc90) to head (ed654b0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #482      +/-   ##
==========================================
+ Coverage   84.64%   84.91%   +0.27%     
==========================================
  Files         191      190       -1     
  Lines        9266     9157     -109     
  Branches     4219     4135      -84     
==========================================
- Hits         7843     7776      -67     
+ Misses        527      502      -25     
+ Partials      896      879      -17     
Flag Coverage Δ
waf_test 84.91% <100.00%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@datadog-official
Copy link

🎯 Code Coverage
Patch Coverage: 100.00%
Total Coverage: 94.22% (+0.21%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ed654b0 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@Anilm3 Anilm3 merged commit 0710687 into master Nov 25, 2025
67 of 70 checks passed
@Anilm3 Anilm3 deleted the anilm3/remove-legacy-rule-schema-support branch November 25, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants