download_huggingface_model(): allow passing rename_mapping as str#42
Merged
download_huggingface_model(): allow passing rename_mapping as str#42
download_huggingface_model(): allow passing rename_mapping as str#42Conversation
maximpavliv
changed the title
download_huggingface_model(): allow passing str as rename mapping
maximpavliv
changed the title
download_huggingface_model(): allow passing str as rename mappingdownload_huggingface_model(): allow passing rename_mapping as str
AlexEMG
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Requests introduces the possibility to pass
rename_mappingas astringwhen callingdownload_huggingface_model(). This makes snapshot name change after download easier, the user doesn't need to know how the snapshot is named on huggingface to change its name.