Skip to content

Enhance risk acceptance authorization checks #14174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Maffooch wants to merge 1 commit into
base: bugfix
Choose a base branch
from
+12 −4
Open

Enhance risk acceptance authorization checks #14174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions dojo/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

from dojo.authorization.authorization import (
user_has_configuration_permission_or_403,
user_has_global_permission,
user_has_permission,
user_has_permission_or_403,
)
Expand Down Expand Up @@ -115,10 +116,17 @@ def action_history(request, cid, oid):
elif ct.model == "risk_acceptance":
engagements = Engagement.objects.filter(risk_acceptance=obj)
authorized = False
for engagement in engagements:
if user_has_permission(request.user, engagement, Permissions.Engagement_View):
authorized = True
break
fetched_engagements = list(engagements)
# Check the case that there are no engagements associated with the risk acceptance
if len(fetched_engagements) == 0:
# Determine if the user has risk acceptance view permission globally
authorized = user_has_global_permission(request.user, Permissions.Risk_Acceptance)
else:
# Iterate through engagements to see if the user has view permission on any of them
for engagement in fetched_engagements:
if user_has_permission(request.user, engagement, Permissions.Engagement_View):
authorized = True
break
if not authorized:
raise PermissionDenied
elif ct.model == "user":
Expand Down