Pause/Resume command fix #2816
Open
Pause/Resume command fix #2816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmonkey4eva
reviewed
Feb 9, 2026
| } | ||
| pause(npc, pauseType, !scriptEntry.getCommandName().equalsIgnoreCase("RESUME")); | ||
| NPCData data = new NPCData(Utilities.getEntryNPC(scriptEntry), type); | ||
| boolean pause = scriptEntry.getCommandName().equalsIgnoreCase("PAUSE"); |
Member
There was a problem hiding this comment.
this handling does not make sense with the rewritten format
mcmonkey4eva
reviewed
Feb 9, 2026
| final ScriptEntry se = scriptEntry; | ||
| durations.put(npc.getId() + pauseType.name(), Denizen.getInstance() | ||
| final NPCData copyData = data; | ||
| final ScriptEntry copyScriptEntry = scriptEntry; |
Member
There was a problem hiding this comment.
these values are not copies. And in fact given the rewrite to format I believe no longer need to exist at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
autoCompile()resumeto its own classresumewith specified duration to actually resume for the specified durationI could probably also add prefixed arg to provide list of npcs rather than only the linked one