Conversation
|
Hi, thanks for contributing! I can't merge your request as is since I don't want to remove the English version. In order to keep these changes, we will need to implement a way of choosing between languages. This can be done by having a translations file and having the text where you made changes be read from the translations file based on the url (ex. if Another way, which is easier to do (but harder to maintain) would be to create a copy of the index file (for example, If you are able to implement one of the above options, feel free to add commits to this PR to implement it. If you need help with that, let me know. |
|
Hi Jonah Lawrence
Thank you for your recommend.
best regards
…On Wed, Oct 7, 2020 at 3:27 PM Jonah Lawrence ***@***.***> wrote:
Hi, thanks for contributing!
I can't merge your request as is since I don't want to remove the English
version.
In order to keep these changes, we will need to implement a way of
choosing between languages.
This can be done by having a translations file and having the text where
you made changes be read from the translations file based on the url (ex.
if lang=th is in the url, the Thai translation would appear instead of
English.)
Another way, which is easier to do (but harder to maintain) would be to
create a copy of the index file (for example, /th/index.php) that will
have your translation, and you would visit that url to see it in Thai.
If you are able to implement one of the above options, feel free to add
commits to this PR to implement it. If you need help with that, let me know.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAW4PBHRUYZE2DS7RBF5JBDSJQQ67ANCNFSM4SG43T5A>
.
|
|
While implementing this, please update the lang attribute in the HTML tag to "th". |
3 participants
No description provided.