fix: embed video position is wrong #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ds-user-guide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
A change to pyproject alone can be unrelated to dependencies. A change to poetry.lock is definitely a change to dependencies.
wesleyboar
added a commit
that referenced
this pull request
Jan 5, 2026
## What Did You Change? Fixed `requirements.txt` not being auto-updated. ## Do You Want Support (syntax, design, etc)? No. <!-- After you open this PR, you can preview your changes. A comment will appear with a link to the server. --> ## Any Reference Material Worth Sharing? - verified via #259 - [successful action](https://github.com/DesignSafe-CI/DS-User-Guide/actions/runs/20726221956/job/59502357547?pr=259
This reverts commit faeae22.
4 tasks
wesleyboar
added a commit
that referenced
this pull request
Jan 5, 2026
## What Did You Change? Refactored the `requirements.txt` sync and validation to avoid false negatives. ## Do You Want Support (syntax, design, etc)? No, I think I'm good. AI wrote it. I directed, reviewed, and tested: 1. [x] Dev **changes** `poetry.lock`. Bot **edits** `requirements.txt`. 2. [x] Bot **changes** `requirements.txt` from target/base branch content. Bot **allows**. 3. [x] Dev **changes** `requirements.txt`. Bot **prevents**. 4. [x] Dev **reverts** `requirements.txt` to target/base branch content. Bot **allows**. ## Any Reference Material Worth Sharing? Tested on #259. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Did You Change?
Updated dependency https://github.com/TACC/mkdocs-tacc.
Do You Want Support (syntax, design, etc)?
No. Error is clear. Fix works as expected:
https://deploy-preview-259--ds-user-guide.netlify.app/tools/simulation/opensees/opensees/
Any Reference Material Worth Sharing?
https://github.com/TACC/mkdocs-tacc/releases/tag/v1.0.2
test.fix.in.situ.mov
(There are many other commits in this PR that are cancelled out by merging main which got those same commits in separate PRs that relied on this PR for real-world testing.)