Skip to content

Conversation

@LeSe0-devexpress
Copy link

Refactor code and implement:

  • Use Context API instead of DevExtreme Options
  • Unit tests

@DevExpressExampleBot
Copy link
Contributor

Please correct the project and update this pull request by pushing a new commit.

Non-zero exit code when running test file

https://codecentralfarm.devexpress.devx/job/devextreme-datagrid-select-all-checkboxes_25.1.3+/31/console

@artem-kurchenko
Copy link
Contributor

artem-kurchenko commented Jan 13, 2026

React/src/GroupRowSelection/GroupRowSelectionHelper.ts doesn't look necessary as a separate file. Now I see that it basically now contains hooks/helper for context code. Can we move it into selection-cotext/hooks ?

setHelper(new GroupSelectionHelper(dataGrid.current.instance()));
}
}, [dataGrid, setHelper]);
const groupRowInitHandler = useEventCallback((arg: IGroupRowReadyParameter) =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this callback doesn't take any information from the current component App.tsx
I don't see that it takes information from DataGrid either.
seems it's not needed in App.tsx Can we register this callback and use hooks directly at the GroupRowSelection.tsx level?

@flagmanAndrew
Copy link
Contributor

  1. Duplicated requests when I select a group row even if I disable StrictMode. One originates from Grid.onOptionChanged and the other from useGroupSelectionHandler. Both calls getSelectedRowKeys. Requests are not duplicated in jQuery.

  2. Requests are sent when I unselect a group row. This doesn't happen in jQuery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants