-
Notifications
You must be signed in to change notification settings - Fork 6
Fix: Selection for group rows in React DataGrid #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 25.1.3+
Are you sure you want to change the base?
Fix: Selection for group rows in React DataGrid #31
Conversation
…ents for checkbox selection
…handling and selection management
…roved group row selection handling
…etter performance
…d loading handling and selection synchronization
|
Please correct the project and update this pull request by pushing a new commit. |
|
|
| setHelper(new GroupSelectionHelper(dataGrid.current.instance())); | ||
| } | ||
| }, [dataGrid, setHelper]); | ||
| const groupRowInitHandler = useEventCallback((arg: IGroupRowReadyParameter) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this callback doesn't take any information from the current component App.tsx
I don't see that it takes information from DataGrid either.
seems it's not needed in App.tsx Can we register this callback and use hooks directly at the GroupRowSelection.tsx level?
|
Refactor code and implement: