Skip to content

Fix: Vitest, the "window.getComputedStyle" error is not defined when running tests #31987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ajivanyandev wants to merge 7 commits into
base: 25_2
Choose a base branch
from
+39 −0
Open

Fix: Vitest, the "window.getComputedStyle" error is not defined when running tests #31987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1e80816
add catch to avoid error in windows
ajivanyandev Dec 16, 2025
42b673e
Merge branch '25_2' into fix/vitest-get-computed-style
ajivanyandev Dec 16, 2025
8044515
add a little more specific check
ajivanyandev Dec 23, 2025
db24067
remove catch
ajivanyandev Dec 23, 2025
6102b42
Merge branch '25_2' into fix/vitest-get-computed-style
ajivanyandev Dec 23, 2025
7de7d97
fix tests
ajivanyandev Dec 23, 2025
d0f609f
Merge branch 'fix/vitest-get-computed-style' of https://github.com/aj…
ajivanyandev Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/devextreme/js/__internal/ui/themes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ function readThemeMarker(): string | null {
let result: string;

try {
if (!window?.getComputedStyle) {
return null;
}
result = window.getComputedStyle(element.get(0)).fontFamily;
Copy link

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix only checks if window.getComputedStyle exists, but the tests expect the function to handle cases where getComputedStyle throws an error when called. The current implementation will still throw an error if getComputedStyle exists but throws when invoked. To properly handle this scenario, wrap the window.getComputedStyle call in a try-catch block within the existing try-finally structure.

Suggested change
result = window.getComputedStyle(element.get(0)).fontFamily;
let computedStyle;
try {
computedStyle = window.getComputedStyle(element.get(0));
} catch (e) {
return null;
}
// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
result = computedStyle && computedStyle.fontFamily;

Copilot uses AI. Check for mistakes.
if (!result) {
return null;
Expand Down
36 changes: 36 additions & 0 deletions packages/devextreme/testing/tests/DevExpress.ui/themes.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -825,3 +825,39 @@ QUnit.module('initialized method', (hooks) => {
});
});
});

QUnit.module('readThemeMarker error handling', () => {
test('readThemeMarker returns null when getComputedStyle throws an error', function(assert) {
const done = assert.async();
const originalGetComputedStyle = window.getComputedStyle;
window.getComputedStyle = undefined;

try {
themes.resetTheme();
const value = themes.current();
assert.strictEqual(value, null, 'current() returns null on getComputedStyle being undefined');
} finally {
window.getComputedStyle = originalGetComputedStyle;
done();
}
});

test('waitForThemeLoad resolves even if getComputedStyle continuously throws', function(assert) {
const done = assert.async();
const originalGetComputedStyle = window.getComputedStyle;
window.getComputedStyle = undefined;

const TEST_TIMEOUT = 30;
themes.resetTheme();
themes.setDefaultTimeout(TEST_TIMEOUT);

themes.ready(() => {
assert.strictEqual(themes.current(), null, 'theme remains null after timeout');
window.getComputedStyle = originalGetComputedStyle;
themes.setDefaultTimeout(defaultTimeout);
done();
});

themes.waitForThemeLoad('some.nonexistent.theme');
});
});
Loading