Skip to content

DropDownButton: list items should not have selected class on item from selectedItemKey after items runtime change (T1314783) #32059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Zedwag wants to merge 1 commit into
base: 26_1
Choose a base branch
from
Open

DropDownButton: list items should not have selected class on item from selectedItemKey after items runtime change (T1314783) #32059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/devextreme/js/__internal/ui/m_drop_down_button.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -700,16 +700,18 @@ class DropDownButton extends Widget<DropDownButtonProperties> {
}

_updateItemCollection(optionName): void {
const selectedItemKey = this.option('selectedItemKey');
const { selectedItemKey, useSelectMode } = this.option();
this._setListOption('selectedItem', null);
// @ts-expect-error ts-error
this._setWidgetOption('_list', [optionName]);

if (isDefined(selectedItemKey)) {
this._loadSelectedItem()
.done((selectedItem) => {
this._setListOption('selectedItemKeys', [selectedItemKey]);
this._setListOption('selectedItem', selectedItem);
if (useSelectMode) {
this._setListOption('selectedItemKeys', [selectedItemKey]);
this._setListOption('selectedItem', selectedItem);
}
// eslint-disable-next-line @typescript-eslint/no-unused-vars
}).fail((error) => {
this._setListOption('selectedItemKeys', []);
Expand Down
18 changes: 18 additions & 0 deletions packages/devextreme/testing/tests/DevExpress.ui.widgets/dropDownButton.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ const DROP_DOWN_EDITOR_OVERLAY_CLASS = 'dx-dropdowneditor-overlay';
const CUSTOM_CLASS = 'custom-class';
const LIST_CLASS = 'dx-list';
const LIST_ITEMS_CLASS = 'dx-list-items';
const LIST_ITEM_CLASS = 'dx-list-item';
const LIST_ITEM_SELECTED_CLASS = 'dx-list-item-selected';

const OVERLAY_CONTENT_LABEL = 'Dropdown';

Expand Down Expand Up @@ -1256,6 +1258,22 @@ QUnit.module('list integration', {}, () => {

assert.deepEqual(list.option('selectedItemKeys'), [0], 'List has correct selection');
});

QUnit.test('list items should not have selected class from ddb selectedItemKey after set items at runtime (T1314783)', function(assert) {
const dropDownButton = new DropDownButton($('#dropDownButton'), {
items: ['item1'],
useSelectMode: false,
opened: true,
selectedItemKey: 'item1',
});
const list = getList(dropDownButton);

dropDownButton.option('items', ['item1']);
const $listItems = list.itemElements();

assert.strictEqual($listItems.length, 1, 'there is one list item');
assert.strictEqual($listItems.hasClass(LIST_ITEM_SELECTED_CLASS), false, 'item does not have selected class');
});
});

QUnit.module('common use cases', {
Expand Down
Loading