Skip to content

Conversation

@pharret31
Copy link
Contributor

No description provided.

@pharret31 pharret31 self-assigned this Jan 7, 2026
@pharret31 pharret31 added the 26_1 label Jan 7, 2026
@pharret31 pharret31 marked this pull request as ready for review January 7, 2026 11:41
@pharret31 pharret31 requested a review from a team as a code owner January 7, 2026 11:41
Copilot AI review requested due to automatic review settings January 7, 2026 11:41
@pharret31 pharret31 requested review from a team as code owners January 7, 2026 11:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves linting configuration and enforcement across the demos application by enabling the import/order rule and fixing import statement ordering throughout the codebase. The changes standardize import organization and remove duplicate/conflicting ESLint rules.

Key changes:

  • Enabled import/order ESLint rule to enforce consistent import statement organization
  • Upgraded react/jsx-fragments from warning to error for stricter enforcement
  • Removed duplicate react-perf ESLint rules that had conflicting configurations

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.

Show a summary per file
File Description
apps/demos/eslint.config.mjs Enabled import/order rule, upgraded react/jsx-fragments to error, removed duplicate react-perf rules
apps/demos/Demos/TreeView/DragAndDropHierarchicalDataStructure/ReactJs/App.js Reordered imports: moved devextreme utility import before local data imports
apps/demos/Demos/TreeView/DragAndDropHierarchicalDataStructure/React/App.tsx Reordered imports: moved devextreme utility import before local data/type imports
apps/demos/Demos/Stepper/FormIntegration/Angular/app/app.component.ts Moved validationEngine import earlier, removed extra blank line
apps/demos/Demos/List/DragAndDrop/React/App.tsx Reordered imports: moved devextreme type imports before local data imports
apps/demos/Demos/Gantt/ExportToPDF/ReactJs/App.js Moved jspdf-autotable import before local data imports
apps/demos/Demos/Gantt/ExportToPDF/React/App.tsx Moved jspdf-autotable import before local data imports, removed extra blank line
apps/demos/Demos/DataGrid/RecordPaging/Vue/App.vue Separated type imports from regular imports, reordered to group types together
apps/demos/Demos/DataGrid/AIColumns/React/service.ts Moved local type import after devextreme imports, simplified return statement by removing intermediate variable
apps/demos/Demos/DataGrid/AIColumns/React/Category.tsx Moved devextreme type import before local type imports
apps/demos/Demos/Chat/AIAndChatbotIntegration/Angular/app/app.component.ts Separated type imports, moved app.service import after devextreme imports
apps/demos/Demos/Charts/PointImage/Vue/App.vue Moved devextreme type import before local data imports
apps/demos/Demos/CardView/Overview/Angular/app/app.component.ts Moved devextreme utility import before local service import, removed extra blank line
apps/demos/Demos/CardView/CardTemplate/Vue/App.vue Moved vue import earlier, separated type import from value import for same module
apps/demos/Demos/Autocomplete/Overview/ReactJs/App.js Reordered imports: moved devextreme-aspnet-data-nojquery import before local data imports
apps/demos/Demos/Autocomplete/Overview/React/App.tsx Moved devextreme-aspnet-data-nojquery import before local data imports
apps/demos/Demos/Autocomplete/Overview/Angular/app/app.component.ts Moved devextreme-aspnet-data-nojquery import before local service import
apps/demos/Demos/ActionSheet/PopoverMode/Vue/App.vue Separated type imports, moved devextreme type import after list import, reordered type and value imports

Copilot AI review requested due to automatic review settings January 7, 2026 15:24
@pharret31 pharret31 requested a review from a team as a code owner January 7, 2026 15:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 52 out of 52 changed files in this pull request and generated 1 comment.

Copilot AI review requested due to automatic review settings January 7, 2026 17:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 55 out of 55 changed files in this pull request and generated 6 comments.

Copilot AI review requested due to automatic review settings January 7, 2026 18:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 55 out of 55 changed files in this pull request and generated 2 comments.

dmlvr
dmlvr previously approved these changes Jan 8, 2026
Copilot AI review requested due to automatic review settings January 8, 2026 13:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 89 out of 91 changed files in this pull request and generated 3 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

r-farkhutdinov
r-farkhutdinov previously approved these changes Jan 8, 2026
dmlvr
dmlvr previously approved these changes Jan 8, 2026
dmirgaev
dmirgaev previously approved these changes Jan 8, 2026
Signed-off-by: Andrei Kharitonov <pharret31@gmail.com>
@pharret31 pharret31 dismissed stale reviews from dmirgaev, dmlvr, and r-farkhutdinov via ccb3a11 January 8, 2026 15:58
Tucchhaa
Tucchhaa previously approved these changes Jan 8, 2026
r-farkhutdinov
r-farkhutdinov previously approved these changes Jan 8, 2026
dmlvr
dmlvr previously approved these changes Jan 8, 2026
Copilot AI review requested due to automatic review settings January 8, 2026 16:46
@pharret31 pharret31 dismissed stale reviews from dmlvr, r-farkhutdinov, and Tucchhaa via d849784 January 8, 2026 16:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 98 out of 100 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

@pharret31 pharret31 merged commit deb33e0 into DevExpress:26_1 Jan 9, 2026
120 of 121 checks passed
@pharret31 pharret31 deleted the 26_1_3040-improve-demos-linting branch January 9, 2026 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants