-
Notifications
You must be signed in to change notification settings - Fork 663
Demos: improve linting #32104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demos: improve linting #32104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR improves linting configuration and enforcement across the demos application by enabling the import/order rule and fixing import statement ordering throughout the codebase. The changes standardize import organization and remove duplicate/conflicting ESLint rules.
Key changes:
- Enabled
import/orderESLint rule to enforce consistent import statement organization - Upgraded
react/jsx-fragmentsfrom warning to error for stricter enforcement - Removed duplicate
react-perfESLint rules that had conflicting configurations
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| apps/demos/eslint.config.mjs | Enabled import/order rule, upgraded react/jsx-fragments to error, removed duplicate react-perf rules |
| apps/demos/Demos/TreeView/DragAndDropHierarchicalDataStructure/ReactJs/App.js | Reordered imports: moved devextreme utility import before local data imports |
| apps/demos/Demos/TreeView/DragAndDropHierarchicalDataStructure/React/App.tsx | Reordered imports: moved devextreme utility import before local data/type imports |
| apps/demos/Demos/Stepper/FormIntegration/Angular/app/app.component.ts | Moved validationEngine import earlier, removed extra blank line |
| apps/demos/Demos/List/DragAndDrop/React/App.tsx | Reordered imports: moved devextreme type imports before local data imports |
| apps/demos/Demos/Gantt/ExportToPDF/ReactJs/App.js | Moved jspdf-autotable import before local data imports |
| apps/demos/Demos/Gantt/ExportToPDF/React/App.tsx | Moved jspdf-autotable import before local data imports, removed extra blank line |
| apps/demos/Demos/DataGrid/RecordPaging/Vue/App.vue | Separated type imports from regular imports, reordered to group types together |
| apps/demos/Demos/DataGrid/AIColumns/React/service.ts | Moved local type import after devextreme imports, simplified return statement by removing intermediate variable |
| apps/demos/Demos/DataGrid/AIColumns/React/Category.tsx | Moved devextreme type import before local type imports |
| apps/demos/Demos/Chat/AIAndChatbotIntegration/Angular/app/app.component.ts | Separated type imports, moved app.service import after devextreme imports |
| apps/demos/Demos/Charts/PointImage/Vue/App.vue | Moved devextreme type import before local data imports |
| apps/demos/Demos/CardView/Overview/Angular/app/app.component.ts | Moved devextreme utility import before local service import, removed extra blank line |
| apps/demos/Demos/CardView/CardTemplate/Vue/App.vue | Moved vue import earlier, separated type import from value import for same module |
| apps/demos/Demos/Autocomplete/Overview/ReactJs/App.js | Reordered imports: moved devextreme-aspnet-data-nojquery import before local data imports |
| apps/demos/Demos/Autocomplete/Overview/React/App.tsx | Moved devextreme-aspnet-data-nojquery import before local data imports |
| apps/demos/Demos/Autocomplete/Overview/Angular/app/app.component.ts | Moved devextreme-aspnet-data-nojquery import before local service import |
| apps/demos/Demos/ActionSheet/PopoverMode/Vue/App.vue | Separated type imports, moved devextreme type import after list import, reordered type and value imports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 52 out of 52 changed files in this pull request and generated 1 comment.
apps/demos/Demos/Diagram/CustomShapesWithTemplatesWithEditing/jQuery/index.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 55 out of 55 changed files in this pull request and generated 6 comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 55 out of 55 changed files in this pull request and generated 2 comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 89 out of 91 changed files in this pull request and generated 3 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Signed-off-by: Andrei Kharitonov <pharret31@gmail.com>
ccb3a11
d849784
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 98 out of 100 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
No description provided.