DropDownList: Allow null value (research) #32148
Closed
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR is labeled as "research" and attempts to add support for null values in DropDownList by introducing an allowNullValue parameter. The changes modify the _loadValue method in DataExpressionMixin to accept a new parameter and update DropDownList to pass this option when loading values.
Key changes:
- Added an
allowNullValueparameter to the_loadValuemethod in DataExpressionMixin - Modified the null/undefined check logic in
_loadValueto conditionally allow null values - Updated DropDownList's
_loadItemmethod to passthis.option('allowNullValue')to_loadValue
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/ui/editor/m_data_expression.ts | Adds allowNullValue parameter to _loadValue method and modifies the value validation logic |
| packages/devextreme/js/__internal/ui/drop_down_editor/m_drop_down_list.ts | Updates _loadItem to pass the allowNullValue option when calling _loadValue |
packages/devextreme/js/__internal/ui/editor/m_data_expression.ts
Outdated
Show resolved
Hide resolved
packages/devextreme/js/__internal/ui/drop_down_editor/m_drop_down_list.ts
Outdated
Show resolved
Hide resolved
marker-dao
force-pushed
the
26_1_allow_null_value_ddlist
branch
from
0528f9a to
252e888
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.